Closed Bug 906083 Opened 7 years ago Closed 7 years ago

[AMO Integration] Update links to addons.mozilla.org.

Categories

(SeaMonkey :: Preferences, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.23

People

(Reporter: philip.chee, Assigned: philip.chee)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Various AMO urls in our settings have bitrotted over time. Fortunately AMO does redirects. Unfortunately AMO redirects to sub-optimal pages.
> -pref("browser.search.searchEnginesURL", "https://addons.mozilla.org/%LOCALE%/%APP%/search-engines/");
> +pref("browser.search.searchEnginesURL", "https://addons.mozilla.org/%LOCALE%/%APP%/search/?atype=4");

search-engines/ now just redirects to /search-tools which is a mixture of search related extension as well as OpenSearch plugins.

> -extensions.getMoreThemesURL=https://addons.mozilla.org/%LOCALE%/%APP%/themes
> -extensions.getPersonasURL=https://addons.mozilla.org/%LOCALE%/%APP%/personas
> +extensions.getMoreThemesURL=https://addons.mozilla.org/%LOCALE%/%APP%/complete-themes/
> +extensions.getPersonasURL=https://addons.mozilla.org/%LOCALE%/%APP%/themes/?sort=up-and-coming

Themes are now "Complete Themes". Personas are now "Themes".

> -spellchecker.dictionaries.download.url=https://addons.mozilla.org/%LOCALE%/%APP%/dictionaries
> +spellchecker.dictionaries.download.url=https://addons.mozilla.org/%LOCALE%/%APP%/language-tools/

/dictionaries redirects to /language-tools/ Might as well avoid the redirect.


> -<!ENTITY getNewThemesCmd.label     "Get New Themes">
> -<!ENTITY getNewThemesCmd.accesskey "G">
> -<!ENTITY getPersonasCmd.label      "Get Personas">
> -<!ENTITY getPersonasCmd.accesskey  "P">
> +<!ENTITY getMoreThemesCmd.label      "Get More Themes">
> +<!ENTITY getMoreThemesCmd.accesskey  "G">
> +<!ENTITY getBackgroundsCmd.label     "Get Backgrounds">
> +<!ENTITY getBackgroundsCmd.accesskey "B">

I changed "Get New Themes" to "Get More Themes". Some of the themes on AMO aren't particularly new. I also changed "Personas" to "Backgrounds" (short for "Background Themes"). The latter were called lightweight-themes once upon a time.
Attachment #791347 - Flags: review?(iann_bugzilla)
Comment on attachment 791347 [details] [diff] [review]
Patch v1.0 Proposed fix

I presume help will need updating too? Could you either do that in here or spin off into another bug please.
Attachment #791347 - Flags: review?(iann_bugzilla) → review+
Blocks: 913066
Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/42681b25565a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.23
As we're changing locale files, need to flag up to localisers that brand.properties has changed:
+extensions.getMoreThemesURL=https://addons.mozilla.org/%LOCALE%/%APP%/complete-themes/
+extensions.getPersonasURL=https://addons.mozilla.org/%LOCALE%/%APP%/themes/?sort=up-and-coming
+spellchecker.dictionaries.download.url=https://addons.mozilla.org/%LOCALE%/%APP%/language-tools/

Options:
1/ Post to l10n lists/newsgroups
2/ Rename entities
3/ As no l10n seems to actually localise any of these, perhaps consider making them not localisable
Comment on attachment 791347 [details] [diff] [review]
Patch v1.0 Proposed fix

>-extensions.getMoreThemesURL=https://addons.mozilla.org/%LOCALE%/%APP%/themes
>-extensions.getPersonasURL=https://addons.mozilla.org/%LOCALE%/%APP%/personas
>-spellchecker.dictionaries.download.url=https://addons.mozilla.org/%LOCALE%/%APP%/dictionaries
>+extensions.getMoreThemesURL=https://addons.mozilla.org/%LOCALE%/%APP%/complete-themes/
>+extensions.getPersonasURL=https://addons.mozilla.org/%LOCALE%/%APP%/themes/?sort=up-and-coming
>+spellchecker.dictionaries.download.url=https://addons.mozilla.org/%LOCALE%/%APP%/language-tools/

The dictionaries URL should not be changed, what you're doing there is wrong. The /dictionaries URL is a generic redirect to wherever we actually host them, which might change. Even Firefox uses this, see http://mxr.mozilla.org/comm-central/source/mozilla/browser/app/profile/firefox.js#68 - so we should keep using the /dictionaries alias here.

Also, I wonder why the /themes link has a forced sort order applied.
Depends on: 916865
You need to log in before you can comment on or make changes to this bug.