Take the dynamics compressor node's input chunk volume into account

RESOLVED FIXED in mozilla23

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

Trunk
mozilla23
x86
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

2.56 KB, patch
padenot
: review+
Details | Diff | Splinter Review
Assignee

Description

6 years ago
Posted patch Patch (v1) (obsolete) — Splinter Review
No description provided.
Attachment #740603 - Flags: review?(paul)
Attachment #740603 - Flags: review?(paul) → review+
Assignee

Comment 1

6 years ago
Hmm, perhaps this patch is not right.  I think instead of applying the volume after the dynamic range compression computations, I should do it before that...
Assignee

Comment 2

6 years ago
Would that make sense to you Paul?
Flags: needinfo?(paul)
Yes. A signal that is higher than the threshold value at intrinsic volume may well not trigger the effect if the input volume is in fact low enough. Sorry for overlooking that.
Flags: needinfo?(paul)
Assignee

Comment 4

6 years ago
Posted patch Patch (v2)Splinter Review
Attachment #740603 - Attachment is obsolete: true
Attachment #740898 - Flags: review?(paul)
Attachment #740898 - Flags: review?(paul) → review+
https://hg.mozilla.org/mozilla-central/rev/f27428a02d7b
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Assignee

Comment 7

6 years ago
Mass moving Web Audio bugs to the Web Audio component.  Filter on duckityduck.
Component: Video/Audio → Web Audio
You need to log in before you can comment on or make changes to this bug.