Closed Bug 864613 Opened 8 years ago Closed 8 years ago

Take the dynamics compressor node's input chunk volume into account

Categories

(Core :: Web Audio, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (v1) (obsolete) — Splinter Review
No description provided.
Attachment #740603 - Flags: review?(paul)
Attachment #740603 - Flags: review?(paul) → review+
Hmm, perhaps this patch is not right.  I think instead of applying the volume after the dynamic range compression computations, I should do it before that...
Would that make sense to you Paul?
Flags: needinfo?(paul)
Yes. A signal that is higher than the threshold value at intrinsic volume may well not trigger the effect if the input volume is in fact low enough. Sorry for overlooking that.
Flags: needinfo?(paul)
Attached patch Patch (v2)Splinter Review
Attachment #740603 - Attachment is obsolete: true
Attachment #740898 - Flags: review?(paul)
Attachment #740898 - Flags: review?(paul) → review+
https://hg.mozilla.org/mozilla-central/rev/f27428a02d7b
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Mass moving Web Audio bugs to the Web Audio component.  Filter on duckityduck.
Component: Video/Audio → Web Audio
You need to log in before you can comment on or make changes to this bug.