Closed Bug 864706 Opened 11 years ago Closed 11 years ago

Missing event param when cancelling cross-slide

Categories

(Firefox for Metro Graveyard :: Firefox Start, defect)

Product:
Firefox for Metro Graveyard
Component:
Firefox Start
Platform:
x86_64
Windows 8
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 23

People

(Reporter: sfoster, Assigned: sfoster)

References

Details

Attachments

(1 file)

Fix calls to CrossSlide.Handle's cancel to provide event param
1.60 KB, patch
jimm
: review+
Details | Diff | Splinter Review 
By moving the cancel function to a method in the patch that landed as https://hg.mozilla.org/mozilla-central/rev/621b1875145e, I lost the closure which provided the aEvent param necessary to dispatch the progress/cancelled event to the node being dragged. 
This shows up as flaky cancelling behaviour and an error in the console about aEvent being undefined.
Patch to https://hg.mozilla.org/integration/mozilla-inbound/rev/fa5e73d8da49 on #829056 to fix a bug I introduced while refactoring the handler's cancel method.
Attachment #740744 - Flags: review?(jmathies)
Attachment #740744 - Flags: review?(jmathies) → review+
https://hg.mozilla.org/mozilla-central/rev/aa0d00ea2c5f
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
You need to log in before you can comment on or make changes to this bug.