864753 - Month name of finished downloads is not localized

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: Download Manager, defect)

Description

[Théo Chevalier]

In about:downloads, next to finished downloads, the month appears in English. 

Verified in Nightly, but I'm pretty sure it is the same in release (can't try it on today because time is displayed for today's downloads).

Comment 1

[Aaron Train [:aaronmt]]

Month? I only see a time-stamp.

Comment 2

[Théo Chevalier]

Attachment: Screenshot

(In reply to Aaron Train [:aaronmt] from comment #1)
> Month? I only see a time-stamp.

That's what I was trying to explain :p For older downloads (maybe several days, weeks? I don't know) the is the day and the month. In this screenshot it should be "avril" in fr.

Comment 3

[Aaron Train [:aaronmt]]

Oh that row uses http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/downloads/DownloadUtils.jsm#320 via http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/aboutDownloads.js#242

Comment 4

[Axel Hecht [:Pike]]

... and that's going into toLocaleFormat() of Date, which goes to libc, which, IIRC, doesn't ship with localizations on android, because they do l10n on the java stack.

Comment 5

[Wesley Johnston (:wesj)]

Yeah. This is actually a bug in the JS engine's Date object. Our implementation passes a Date object [1] to DownloadUtils [2]. DownloadUtils calls aDate.toLocaleString() which winds up doing its own formatting [3]. That's in contrast to nsDateTimeFormatUnix [4], which does some juggling to try and make sure its using the right locale (since the Unix one might not match Java's, let alone the page's).

I tried to put a fix in here once but couldn't get it to work. I'll ping luke to see if this is known?

[1] http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/aboutDownloads.js#365
[2] http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/downloads/DownloadUtils.jsm#349
[3] http://mxr.mozilla.org/mozilla-central/source/js/src/prmjtime.cpp#417
[4] http://mxr.mozilla.org/mozilla-central/source/intl/locale/src/unix/nsDateTimeFormatUnix.cpp#208

Comment 6

[Luke Wagner [:luke]]

I don't know off hand.  Do you Waldo?

Comment 7

[Luke Wagner [:luke]]

Or, I forgot, do you know Norbert?

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Does the ECMAScript Internationalization API work Norbert is doing affect this?

Comment 9

[Norbert Lindenberg]

Yes, my implementation of the ECMAScript Internationalization API changes Date.prototype.toLocaleString to be based on ICU, which has locale data for French. The implementation isn't enabled anywhere yet. For desktop, that might land today - watch bug 853301. For Android, we haven't concluded our offline discussion yet; I just filed bug 864843 for better tracking.

Comment 10

[Makoto Kato [:m_kato]]

WFM at 2017-02-14 nightly build due to ECMA-402 support