864772 - Stop calling nsSVGUtils::InvalidateBounds in nsSVGDisplayContainerFrame::RemoveFrame, and use DLBI instead

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jonathan Watt [:jwatt]]

We should stop calling nsSVGUtils::InvalidateBounds in nsSVGDisplayContainerFrame::RemoveFrame, and use DLBI instead.

Removing the calls causes failures in:

reftests/svg/filters/dynamic-filtered-foreignObject-01.svg
reftests/svg/moz-only/zoom-invalidation-01.svg
reftests/svg/suspend-03.svg
reftests/svg/suspend-07.svg

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Hopefully the comment explains sufficiently why I'm having to call SchedulePaint() here.

Comment 2

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 740855 [details] [diff] [review]
patch

Review of attachment 740855 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/svg/nsSVGContainerFrame.cpp
@@ +157,5 @@
> +
> +  // nsSVGContainerFrame::RemoveFrame doesn't call down into
> +  // nsContainerFrame::RemoveFrame, so it doesn't call FrameNeedsReflow. We
> +  // need to schedule a repaint and schedule an update to our overflow rects.
> +  SchedulePaint();

This isn't required, DoReflow() will call it.

Comment 3

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7ab7562be0e6

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7ab7562be0e6