Get rid of SVG's own invalidation mechanisms and rely on DLBI instead

RESOLVED FIXED in mozilla24

Status

()

Core
SVG
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

(Depends on: 1 bug, Blocks: 2 bugs)

Trunk
mozilla24
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
+++ This bug was initially created as a clone of Bug #802628 +++

[Bug 802628 became about a subpart of the work for this bug, so I've cloned it to this bug which will be about finishing that work.]

SVG still has its own invalidation mechanisms after landing of DLBI (bug 539356). There are a bunch of SVG invalidation bugs that were caused by the landing of DLBI, mostly because DLBI and the existing SVG invalidation mechanisms don't play nicely together. Ultimately we want SVG to solely use DLBI for invalidation, and it's probably easier to implement that than to fix all the DLBI SVG invalidation regressions individually. This bug is for getting rid of the SVG invalidation mechanisms and converting SVG to use DLBI.
(Assignee)

Updated

4 years ago
Blocks: 791699
(Assignee)

Updated

4 years ago
Summary: Convert SVG invalidation to DLBI → Get rid of SVG's own invalidation mechanisms and rely on DLBI instead
Blocks: 798964
Blocks: 837985
(Assignee)

Updated

4 years ago
Depends on: 839865
(Assignee)

Updated

4 years ago
Blocks: 846181

Updated

4 years ago
Blocks: 852588
(Assignee)

Updated

4 years ago
Depends on: 864770
(Assignee)

Updated

4 years ago
Depends on: 864771
(Assignee)

Updated

4 years ago
Depends on: 864772
(Assignee)

Updated

4 years ago
Depends on: 864832
(Assignee)

Updated

4 years ago
Depends on: 867596
(Assignee)

Updated

4 years ago
Depends on: 867599
(Assignee)

Updated

4 years ago
Blocks: 877429
(Assignee)

Updated

4 years ago
Blocks: 877432
(Assignee)

Comment 1

4 years ago
Created attachment 755646 [details] [diff] [review]
patch

Remove the remaining dead code.
Attachment #755646 - Flags: review?(dholbert)
Comment on attachment 755646 [details] [diff] [review]
patch

I found two more references to this function (in comments), with a MXR search:
http://mxr.mozilla.org/mozilla-central/source/layout/svg/nsSVGTextFrame2.cpp?rev=d9b15dac4de4#4750
http://mxr.mozilla.org/mozilla-central/source/layout/svg/nsSVGUtils.cpp?rev=747173e387c9#582

r=me with those comments corrected.
Attachment #755646 - Flags: review?(dholbert) → review+
(Assignee)

Comment 3

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/c8ab8321f674

(In reply to Daniel Holbert [:dholbert] from comment #2)
> I found two more references...

I previously filed bug 877429 and bug 877432 on those. As agreed on IRC, landing without removing those instances.
https://hg.mozilla.org/mozilla-central/rev/c8ab8321f674
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.