865288 - console.log with different object logged from same line number are grouped together

Status: RESOLVED FIXED

Description

[Girish Sharma [:Optimizer]]

STR :
1. Open this link http://jsfiddle.net/MvK8t/1/ and run with web console open.

The logged object is different each time, but I see following things happening :

1) All three logs have different objects, but they are combined.
2) I do not see the object in the variables view,
3) I get this error in error console :
Error: Server did not specify an actor, dropping packet: {"error":"unknownError","message":"error occurred while processing 'prototypeAndProperties': Error: Permission denied to access object\n"}
Source File: resource://gre/modules/devtools/dbg-client.jsm
Line: 592

Comment 1

[Mihai Sucan [:msucan]]

Thanks for the bug report.

Comment 2

[Mihai Sucan [:msucan]]

I have a fix for the issue with console.log messages being repeated when different objects are given. Need to write a test.

Comment 3

[Mihai Sucan [:msucan]]

Created attachment 744648 [details] [diff] [review]
fix for console.log repeats

This is the fix for the bug where the web console groups together multiple console.log calls with the same text, different objects, from the same line. Now we also check if these messages point to the same objects before merging. Test included.

This bug also reports an issue with objects failing to be inspectable when they come from a different iframe. I suggest we open a separate bug. Girish, can you please do that?

Try push: https://tbpl.mozilla.org/?tree=Try&rev=53aeb8e642cf

Comment 4

[Panos Astithas [:past] (please ni?)]

Comment on attachment 744648 [details] [diff] [review]
fix for console.log repeats

Review of attachment 744648 [details] [diff] [review]:
-----------------------------------------------------------------

Works as advertised!

Comment 5

[Girish Sharma [:Optimizer]]

(In reply to Mihai Sucan [:msucan] from comment #3)
> This bug also reports an issue with objects failing to be inspectable when
> they come from a different iframe. I suggest we open a separate bug. Girish,
> can you please do that?

I saw this issue only a couple of times. I don't actually have STRs to open a bug. If you have better STRs, please feel free to open the bug :)

Comment 7

[Mihai Sucan [:msucan]]

Thank you!

Landed:
https://hg.mozilla.org/integration/fx-team/rev/ac3547a7ed84


(In reply to Girish Sharma [:Optimizer] from comment #5)
> (In reply to Mihai Sucan [:msucan] from comment #3)
> > This bug also reports an issue with objects failing to be inspectable when
> > they come from a different iframe. I suggest we open a separate bug. Girish,
> > can you please do that?
> 
> I saw this issue only a couple of times. I don't actually have STRs to open
> a bug. If you have better STRs, please feel free to open the bug :)

I always get failures when I try to inspect those objects from the jsfiddle test case.

Comment 8

[Tim Taubert [:ttaubert]]

https://hg.mozilla.org/mozilla-central/rev/ac3547a7ed84

Comment 9

[Mihai Sucan [:msucan]]

Filed follow-up bug report: bug 869003. Thank you Girish.