865670 - Thunderbird Sidebars are inconsistent and not platform-aware on OS X

Status: RESOLVED FIXED

(Thunderbird :: Theme, enhancement)

Description

[Josiah Bruner [:jsbruner]]

At the moment TB has very inconsistent sidebars. And this is pretty bad, it is inconsistent to:

- Itself (Sidebar colors/textures vary considerably)

- Other products (Firefox styles are completely different colors, textures are not to important here)

- And OS X

See linked mockup for more details on the issue.

Comment 1

[Josiah Bruner [:jsbruner]]

Attachment: Sidebar change.

Fixes all three sidebars to use a consistent style.

At the moment it doesn't really help the look of the composer, but I am going to deal with the entire composer window in another bug, and then the sidebar will look improved.

Richard, ui-review = you.

Not going to worry about reviewing yet, since I am probably just going to make this bug block my "Composer UI Makeover" bug. So I'll do a review later. We'll probably just land a the composer redo in TB 25.

Comment 2

[Richard Marti (:Paenglab)]

Comment on attachment 742528 [details] [diff] [review]
Sidebar change.

Looks good. Also the Compozer doesn't look so bad with the colored AB-sidebar as you wrote ;)

Now a short code review: Please can you use instead of border-right -moz-border-end? Then this rules are also rtl save. And please use for the color codes uppercase. I know before it wasn't also not correct but if you are on it you can easily correct it.

Comment 3

[Josiah Bruner [:jsbruner]]

Attachment: Patch.

We can land this now, so asking Richard for review. (I made that one change you mentioned above).

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 772303 [details] [diff] [review]
Patch.

Looks good, thank you.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/fd7834622e22