Closed Bug 865670 Opened 8 years ago Closed 7 years ago

Thunderbird Sidebars are inconsistent and not platform-aware on OS X

Categories

(Thunderbird :: Theme, enhancement)

All
macOS
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 23.0

People

(Reporter: jsbruner, Assigned: jsbruner)

References

()

Details

(Keywords: ux-consistency)

Attachments

(1 file, 1 obsolete file)

At the moment TB has very inconsistent sidebars. And this is pretty bad, it is inconsistent to:

- Itself (Sidebar colors/textures vary considerably)

- Other products (Firefox styles are completely different colors, textures are not to important here)

- And OS X

See linked mockup for more details on the issue.
Attached patch Sidebar change. (obsolete) β€” β€” Splinter Review
Fixes all three sidebars to use a consistent style.

At the moment it doesn't really help the look of the composer, but I am going to deal with the entire composer window in another bug, and then the sidebar will look improved.

Richard, ui-review = you.

Not going to worry about reviewing yet, since I am probably just going to make this bug block my "Composer UI Makeover" bug. So I'll do a review later. We'll probably just land a the composer redo in TB 25.
Attachment #742528 - Flags: ui-review?(richard.marti)
Comment on attachment 742528 [details] [diff] [review]
Sidebar change.

Looks good. Also the Compozer doesn't look so bad with the colored AB-sidebar as you wrote ;)

Now a short code review: Please can you use instead of border-right -moz-border-end? Then this rules are also rtl save. And please use for the color codes uppercase. I know before it wasn't also not correct but if you are on it you can easily correct it.
Attachment #742528 - Flags: ui-review?(richard.marti) → ui-review+
Status: NEW → ASSIGNED
Attached patch Patch. β€” β€” Splinter Review
We can land this now, so asking Richard for review. (I made that one change you mentioned above).
Attachment #742528 - Attachment is obsolete: true
Attachment #772303 - Flags: ui-review+
Attachment #772303 - Flags: review?(richard.marti)
Comment on attachment 772303 [details] [diff] [review]
Patch.

Looks good, thank you.
Attachment #772303 - Flags: review?(richard.marti) → review+
https://hg.mozilla.org/comm-central/rev/fd7834622e22
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.