If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Thunderbird Sidebars are inconsistent and not platform-aware on OS X

RESOLVED FIXED in Thunderbird 23.0

Status

Thunderbird
Theme
--
enhancement
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: JosiahOne, Assigned: JosiahOne)

Tracking

({ux-consistency})

unspecified
Thunderbird 23.0
All
Mac OS X
ux-consistency

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

At the moment TB has very inconsistent sidebars. And this is pretty bad, it is inconsistent to:

- Itself (Sidebar colors/textures vary considerably)

- Other products (Firefox styles are completely different colors, textures are not to important here)

- And OS X

See linked mockup for more details on the issue.
Created attachment 742528 [details] [diff] [review]
Sidebar change.

Fixes all three sidebars to use a consistent style.

At the moment it doesn't really help the look of the composer, but I am going to deal with the entire composer window in another bug, and then the sidebar will look improved.

Richard, ui-review = you.

Not going to worry about reviewing yet, since I am probably just going to make this bug block my "Composer UI Makeover" bug. So I'll do a review later. We'll probably just land a the composer redo in TB 25.
Attachment #742528 - Flags: ui-review?(richard.marti)
Comment on attachment 742528 [details] [diff] [review]
Sidebar change.

Looks good. Also the Compozer doesn't look so bad with the colored AB-sidebar as you wrote ;)

Now a short code review: Please can you use instead of border-right -moz-border-end? Then this rules are also rtl save. And please use for the color codes uppercase. I know before it wasn't also not correct but if you are on it you can easily correct it.
Attachment #742528 - Flags: ui-review?(richard.marti) → ui-review+
Blocks: 867161
Status: NEW → ASSIGNED
Created attachment 772303 [details] [diff] [review]
Patch.

We can land this now, so asking Richard for review. (I made that one change you mentioned above).
Attachment #742528 - Attachment is obsolete: true
Attachment #772303 - Flags: ui-review+
Attachment #772303 - Flags: review?(richard.marti)
Comment on attachment 772303 [details] [diff] [review]
Patch.

Looks good, thank you.
Attachment #772303 - Flags: review?(richard.marti) → review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/fd7834622e22
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.