Closed Bug 865997 Opened 8 years ago Closed 8 years ago

Don't prune complex subtrees for roles usually having no children

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: surkov, Assigned: surkov)

References

(Blocks 1 open bug)

Details

(Keywords: access)

Attachments

(1 file)

Attached patch patchSplinter Review
Make nsAccUtils::MustPrune smarter (it makes a part of bug Bug 249292 not necessary: http://hg.mozilla.org/mozilla-central/diff/217edac6b29f/accessible/src/base/nsAccUtils.cpp): make it to look into subtree to decide.

The reason is we were reported that we don't expose children in the following case:

<ul aria-label="Account Menu" role="menu navigation" id="userNavigation" class="navigation">
  <li role="menuitem" aria-selected="true">
    <form id="logout_form">
      <label><input type="submit" value="Log Out"></label>
    </form>
  </li>
</ul>
Attachment #742220 - Flags: review?(trev.saunders)
Assignee: nobody → surkov.alexander
Comment on attachment 742220 [details] [diff] [review]
patch

seems ok, though adding the virtual call sucks, use ContentChildAt() maybe, or maybe I should just get around to devirtualizing GetChildAt()

btw have we  considered what it would take to just not create text leaves in these cases?
Attachment #742220 - Flags: review?(trev.saunders) → review+
(In reply to Trevor Saunders (:tbsaunde) from comment #1)
> Comment on attachment 742220 [details] [diff] [review]
> patch
> 
> seems ok, though adding the virtual call sucks, use ContentChildAt() maybe,

that should be working.

> or maybe I should just get around to devirtualizing GetChildAt()

ideas/plans? Should I care about ContentChildAt() stuff here?

> btw have we  considered what it would take to just not create text leaves in
> these cases?

I guess name computation and text ifrace are broken
(In reply to alexander :surkov from comment #2)
> (In reply to Trevor Saunders (:tbsaunde) from comment #1)
> > Comment on attachment 742220 [details] [diff] [review]
> > patch
> > 
> > seems ok, though adding the virtual call sucks, use ContentChildAt() maybe,
> 
> that should be working.

not sure what you mean

> > or maybe I should just get around to devirtualizing GetChildAt()
> 
> ideas/plans? Should I care about ContentChildAt() stuff here?

I think we can just special case tree stuff, but probably won't get to it particularly soon.

> > btw have we  considered what it would take to just not create text leaves in
> > these cases?
> 
> I guess name computation and text ifrace are broken

sounds right
https://hg.mozilla.org/mozilla-central/rev/898b2c5eaa5d
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Depends on: 877982
You need to log in before you can comment on or make changes to this bug.