866248 - backport new date custom field type from bug 801664 to bmo/4.2

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[David Lawrence [:dkl]]

backport new date custom field type from bug 801664 to bmo/4.2 to give a choice to create fields without a time portion.

Comment 1

[Tara (musingt)]

Thanks.  It would be great if we could change the field type.  I was very excited to have a "due date" field but the current field type adds a lot of extra noise to my dashboard and it's information I do not need, personally. I'm not aware of anyone who relies on the time-stamp either.  Most projects seem to be guided by a Date vs. specific Time and if the time is relevant then I think it's worth adding that in a different field vs. appending it to the Date field. Technically Date and Time (hour, minute, second) are different data.  Right now everything shows up with a 00:00:00 appended to it and it's not helpful :(

Comment 2

[David Lawrence [:dkl]]

Attachment: Patch to add date only custom field type (v1)

Please verify proper creation/removal of the custom field in you tests. I had timeout issues a few times when doing so on my local system.

Thanks

Comment 3

[:glob ✱]

Comment on attachment 744715 [details] [diff] [review]
Patch to add date only custom field type (v1)

Review of attachment 744715 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob

i had no issues during my testing.

please update contrib/addcustomfield.pl before committing.

Comment 4

[David Lawrence [:dkl]]

Thanks

Committing to: bzr+ssh://[e-mail]/bmo/4.2           
modified importxml.pl
modified Bugzilla/Bug.pm                                                                
modified Bugzilla/Constants.pm
modified Bugzilla/Field.pm
modified Bugzilla/Migrate.pm
modified Bugzilla/Search.pm
modified Bugzilla/DB/Schema/Mysql.pm
modified Bugzilla/DB/Schema/Oracle.pm                                              
modified Bugzilla/DB/Schema/Pg.pm
modified Bugzilla/DB/Schema/Sqlite.pm
modified Bugzilla/WebService/Bug.pm
modified contrib/addcustomfield.pl
modified template/en/default/bug/field.html.tmpl
modified template/en/default/global/field-descs.none.tmpl
modified template/en/default/search/field.html.tmpl
Committed revision 8770. 

dkl

Comment 5

[Tara (musingt)]

this is awesome. thanks all. quick question... when will I see the change when viewing bug lists? I'm still seeing the 0's (screenshot attached)

Comment 6

[Tara (musingt)]

Attachment: 0's attached to date

Comment 7

[David Lawrence [:dkl]]

this should be fixed soon. Checkin of the script was the first part. I am working with IT now to get it executed on the production db to convert the dates. Then you will not see the 0's.

dkl