Closed Bug 866273 Opened 12 years ago Closed 12 years ago

pushState is wrong when loading a reviews listing page

Categories

(Marketplace Graveyard :: Consumer Pages, defect)

Product:
Marketplace Graveyard
Component:
Consumer Pages
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2013-05-02

People

(Reporter: cvan, Assigned: basta)

References

(
URL
)

Details

(Whiteboard: [fireplace])

1. Go to http://localhost:8675/app/mixcloud/ratings 2. Click back. 3. You're still there. 4. Why'd it push the page again onto the history stack?
Summary: pushState when loading a reviews listing page → pushState is wrong when loading a reviews listing page
https://github.com/mozilla/fireplace/commit/26dc7230f14ca8f00a6844f292ec54528d18b9a4 We were using pushState on first load instead of replaceState. Previously with fragment loading, navigation didn't get invoked until the user clicked something. Now, we're calling navigation immediately when the JS is loaded.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee: nobody → mattbasta
Target Milestone: --- → 2013-05-02
You need to log in before you can comment on or make changes to this bug.