866323 - Increase max test suite run time

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

We're starting to get a number of "Test run exceeded timeout (1800s)" test failures on Windows 7 debug builds, I suspect this is because our tests are taking longer than 30mins to run which is the maximum time we allow for the test suite to perform it's task.

I think we should increase this now to 45mins.

https://github.com/mozilla/addon-sdk/blob/master/python-lib/cuddlefish/runner.py#L33

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/979

Pointer to Github pull-request

Comment 11

[Dave Townsend [:mossop]]

Comment on attachment 742608 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/979

r+ but as we discussed let's look into just removing this timeout at some point.

Comment 12

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/8bc1d0ea5e510e406ab663a96977181a1bdd219c
Bug 866323: increase maximum test suite run time

https://github.com/mozilla/addon-sdk/commit/cefa69135e13498fc3d78d37bb495a70e0b266eb
Merge pull request #979 from erikvold/866323

Bug 866323: increase maximum test suite run time to 45mins r=@Mossop

Comment 13

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to Dave Townsend (:Mossop) from comment #11)
> Comment on attachment 742608 [details]
> Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/979
> 
> r+ but as we discussed let's look into just removing this timeout at some
> point.

I was thinking that it may still be useful to have this when the suite is run on local machines or other scenarios that are not tinderbox.