Closed Bug 866424 Opened 12 years ago Closed 12 years ago

Cleanup and fix importTestsuite.py

Categories

(Testing :: Mochitest, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla23

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

Details

Attachments

(11 files)

2.46 KB, patch
k0scist
: review+
Details | Diff | Splinter Review
28.91 KB, patch
k0scist
: review+
Details | Diff | Splinter Review
4.44 KB, patch
k0scist
: review+
Details | Diff | Splinter Review
36.91 KB, patch
k0scist
: review+
Details | Diff | Splinter Review
9.07 KB, patch
k0scist
: review+
Details | Diff | Splinter Review
4.40 KB, patch
k0scist
: review+
Details | Diff | Splinter Review
3.20 KB, patch
k0scist
: review+
Details | Diff | Splinter Review
7.62 KB, patch
k0scist
: review+
Details | Diff | Splinter Review
3.89 KB, patch
k0scist
: review+
Details | Diff | Splinter Review
7.21 KB, patch
k0scist
: review+
Details | Diff | Splinter Review
19.41 KB, patch
k0scist
: review+
Details | Diff | Splinter Review
It needed quite a bit of work...
Blocks: 859252
Comment on attachment 742810 [details] [diff] [review] Part i (1): Move expected failures to the shortened names This is missing the obsolete/requirements-for-implementations/other-elements-attributes-and-apis -> obsolete/implreq/oeaaa changes; fixed locally.
Attachment #742801 - Flags: review?(jhammel) → review+
Comment on attachment 742802 [details] [diff] [review] Part b: Revert changes to shorten directory lengths because they broke importing Review of attachment 742802 [details] [diff] [review]: ----------------------------------------------------------------- Nice; kill all the hacks
Attachment #742802 - Flags: review?(jhammel) → review+
Comment on attachment 742803 [details] [diff] [review] Part c: Use git instead of hg-git to clone upstream test suites Review of attachment 742803 [details] [diff] [review]: ----------------------------------------------------------------- I'd love to consolidate our hg code into one place, but that's another story ::: dom/imptests/importTestsuite.py @@ +40,5 @@ > with open(confFile, 'r') as fp: > first = True > for line in fp: > if first: > + vcs, url, iden = line.strip().split("|") Better, for sure.
Attachment #742803 - Flags: review?(jhammel) → review+
Attachment #742804 - Flags: review?(jhammel) → review+
Attachment #742805 - Flags: review?(jhammel) → review+
Attachment #742806 - Flags: review?(jhammel) → review+
Attachment #742807 - Flags: review?(jhammel) → review+
Comment on attachment 742808 [details] [diff] [review] Part g: Derecursify the importing of test suites Review of attachment 742808 [details] [diff] [review]: ----------------------------------------------------------------- i like where this is going....
Attachment #742808 - Flags: review?(jhammel) → review+
Attachment #742809 - Flags: review?(jhammel) → review+
Attachment #742810 - Flags: review?(jhammel) → review+
Attachment #742811 - Flags: review?(jhammel) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: