Closed
Bug 866424
Opened 12 years ago
Closed 12 years ago
Cleanup and fix importTestsuite.py
Categories
(Testing :: Mochitest, defect)
Testing
Mochitest
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla23
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
Details
Attachments
(11 files)
2.46 KB,
patch
|
k0scist
:
review+
|
Details | Diff | Splinter Review |
28.91 KB,
patch
|
k0scist
:
review+
|
Details | Diff | Splinter Review |
4.44 KB,
patch
|
k0scist
:
review+
|
Details | Diff | Splinter Review |
36.91 KB,
patch
|
k0scist
:
review+
|
Details | Diff | Splinter Review |
9.07 KB,
patch
|
k0scist
:
review+
|
Details | Diff | Splinter Review |
4.40 KB,
patch
|
k0scist
:
review+
|
Details | Diff | Splinter Review |
3.20 KB,
patch
|
k0scist
:
review+
|
Details | Diff | Splinter Review |
7.62 KB,
patch
|
k0scist
:
review+
|
Details | Diff | Splinter Review |
3.89 KB,
patch
|
k0scist
:
review+
|
Details | Diff | Splinter Review |
7.21 KB,
patch
|
k0scist
:
review+
|
Details | Diff | Splinter Review |
19.41 KB,
patch
|
k0scist
:
review+
|
Details | Diff | Splinter Review |
It needed quite a bit of work...
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #742801 -
Flags: review?(jhammel)
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #742802 -
Flags: review?(jhammel)
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #742803 -
Flags: review?(jhammel)
Assignee | ||
Comment 4•12 years ago
|
||
Attachment #742804 -
Flags: review?(jhammel)
Assignee | ||
Comment 5•12 years ago
|
||
Attachment #742805 -
Flags: review?(jhammel)
Assignee | ||
Comment 6•12 years ago
|
||
Attachment #742806 -
Flags: review?(jhammel)
Assignee | ||
Comment 7•12 years ago
|
||
Attachment #742807 -
Flags: review?(jhammel)
Assignee | ||
Comment 8•12 years ago
|
||
Attachment #742808 -
Flags: review?(jhammel)
Assignee | ||
Comment 9•12 years ago
|
||
Attachment #742809 -
Flags: review?(jhammel)
Assignee | ||
Comment 10•12 years ago
|
||
Attachment #742810 -
Flags: review?(jhammel)
Assignee | ||
Comment 11•12 years ago
|
||
Attachment #742811 -
Flags: review?(jhammel)
Assignee | ||
Comment 12•12 years ago
|
||
Comment on attachment 742810 [details] [diff] [review]
Part i (1): Move expected failures to the shortened names
This is missing the obsolete/requirements-for-implementations/other-elements-attributes-and-apis -> obsolete/implreq/oeaaa changes; fixed locally.
Updated•12 years ago
|
Attachment #742801 -
Flags: review?(jhammel) → review+
Comment 13•12 years ago
|
||
Comment on attachment 742802 [details] [diff] [review]
Part b: Revert changes to shorten directory lengths because they broke importing
Review of attachment 742802 [details] [diff] [review]:
-----------------------------------------------------------------
Nice; kill all the hacks
Attachment #742802 -
Flags: review?(jhammel) → review+
Comment 14•12 years ago
|
||
Comment on attachment 742803 [details] [diff] [review]
Part c: Use git instead of hg-git to clone upstream test suites
Review of attachment 742803 [details] [diff] [review]:
-----------------------------------------------------------------
I'd love to consolidate our hg code into one place, but that's another story
::: dom/imptests/importTestsuite.py
@@ +40,5 @@
> with open(confFile, 'r') as fp:
> first = True
> for line in fp:
> if first:
> + vcs, url, iden = line.strip().split("|")
Better, for sure.
Attachment #742803 -
Flags: review?(jhammel) → review+
Updated•12 years ago
|
Attachment #742804 -
Flags: review?(jhammel) → review+
Updated•12 years ago
|
Attachment #742805 -
Flags: review?(jhammel) → review+
Updated•12 years ago
|
Attachment #742806 -
Flags: review?(jhammel) → review+
Updated•12 years ago
|
Attachment #742807 -
Flags: review?(jhammel) → review+
Comment 15•12 years ago
|
||
Comment on attachment 742808 [details] [diff] [review]
Part g: Derecursify the importing of test suites
Review of attachment 742808 [details] [diff] [review]:
-----------------------------------------------------------------
i like where this is going....
Attachment #742808 -
Flags: review?(jhammel) → review+
Updated•12 years ago
|
Attachment #742809 -
Flags: review?(jhammel) → review+
Updated•12 years ago
|
Attachment #742810 -
Flags: review?(jhammel) → review+
Updated•12 years ago
|
Attachment #742811 -
Flags: review?(jhammel) → review+
Assignee | ||
Comment 16•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/bb26a100852a
https://hg.mozilla.org/mozilla-central/rev/4f1bc514ea8b
https://hg.mozilla.org/mozilla-central/rev/63a7302983a1
https://hg.mozilla.org/mozilla-central/rev/8e0e481f6746
https://hg.mozilla.org/mozilla-central/rev/6409db53f33b
https://hg.mozilla.org/mozilla-central/rev/616de9bdf29c
https://hg.mozilla.org/mozilla-central/rev/870596f541f2
https://hg.mozilla.org/mozilla-central/rev/eb2c1eb6ef59
https://hg.mozilla.org/mozilla-central/rev/f9d768cca37e
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in
before you can comment on or make changes to this bug.
Description
•