Closed Bug 866425 Opened 7 years ago Closed 7 years ago

Drop support for building Mozilla under MSVS 2008/MSVC9 and previous

Categories

(Firefox Build System :: General, defect)

x86_64
Windows 7
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla24

People

(Reporter: wgianopoulos, Assigned: ehsan)

References

Details

Attachments

(1 file)

It is becoming increasingly often that we are running into issues trying to build under Microsoft Visual Studios 2008/ Microsfot Visual C version 9.

Since VC10 is now available for no charge, we should convert anything we still build under VC9 (might be Seamonkey and Thunderbird) to VC10 and just drop support for building using the older compiler.
I suggested this in #build the other day, and RyanVM suggested that I should run it by you, humorously enough. We seem to be breaking it pretty often, so we might as well just stop pretending to support it. This would free us up to use more C++11, as well as use stdint.h directly everywhere.

(Also I'm not sure we ever officially dropped support for VC2005, but I'm sure we've broken that quite a bit.)
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #1)

> (Also I'm not sure we ever officially dropped support for VC2005, but I'm
> sure we've broken that quite a bit.)

I thought support had been dropped for VC2005 but it seems it is only the express version that is no longer supported because it is incompatible with the Windows 7 SDK.  The build instructions say the professional version is still supposed to work.
Summary: Drop support for building Mozilla under MSVS 2008/MSVC9 → Drop support for building Mozilla under MSVS 2008/MSVC9 and before
Summary: Drop support for building Mozilla under MSVS 2008/MSVC9 and before → Drop support for building Mozilla under MSVS 2008/MSVC9 and previous
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #1)
> I suggested this in #build the other day, and RyanVM suggested that I should
> run it by you, humorously enough.

I think he did not realize the only reason I have not gone to VC10 is to catch things that fail under VC9, since we supposedly support and I do nightly like builds every day.  Probably because my builds are linked form https://developer.mozilla.org/docs/Mozilla/MathML_Project
(In reply to Bill Gianopoulos [:WG9s] from comment #0)
> Since VC10 is now available for no charge, we should convert anything we
> still build under VC9 (might be Seamonkey and Thunderbird) to VC10 and just
> drop support for building using the older compiler.

Thunderbird is running on the same build systems as Firefox, and should be using the same compiler as Firefox (especially when looking at the diffs of the mozconfigs). If you have evidence to the contrary, please file a Thunderbird/Build Config bug asap and cc me, thanks.
I understand SeaMonkey builds fine with VC10. I think our builders are already on VC10. Like Bill I continue to build with VC9 since that is still officially supported. But I won't have any problems switching to VS2010 as I already have that installed.
Okay, sounds like there's no real opposition then. Anyone care to write the patch, or do I have to do it? :)
I think we should post this on dev-platform and mention in the platform meeting before doing it, though, as it might affect developers out there. We had been building with VC2008 and recommended for people to use that for a long time, so there might be a substantial amount of people left that use it daily.
I switched my builds a few days ago to using VC10 on the basis that this was going forward.  The only reason I had not done that before was that I was doing automated daily builds and could determine if there were VC9 issues before it impacted developers.
Oh and the issue that really prompted me to suggest this was bug 858566 where turning off optimization caused a VC9 issue but with optimization on it works.  That was kind the last straw.
Attached patch Patch (v1)Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #749278 - Flags: review?(mh+mozilla)
Comment on attachment 749278 [details] [diff] [review]
Patch (v1)

Review of attachment 749278 [details] [diff] [review]:
-----------------------------------------------------------------

Please do the same in js/src/configure.in.

The error message that ensues points to https://developer.mozilla.org/en/Windows_Build_Prerequisites. That page will obviously have to be updated accordingly.
Attachment #749278 - Flags: review?(mh+mozilla) → review+
(In reply to comment #11)
> Comment on attachment 749278 [details] [diff] [review]
>   --> https://bugzilla.mozilla.org/attachment.cgi?id=749278
> Patch (v1)
> 
> Review of attachment 749278 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Please do the same in js/src/configure.in.

Will do, sorry about that!

> The error message that ensues points to
> https://developer.mozilla.org/en/Windows_Build_Prerequisites. That page will
> obviously have to be updated accordingly.

Will do.
Comment on attachment 749278 [details] [diff] [review]
Patch (v1)

Now we can move _CRT_SECURE_NO_WARNINGS and _CRT_NONSTDC_NO_WARNINGS outside the if-statements because MSVC8 is not supported anymore.
(In reply to comment #13)
> Comment on attachment 749278 [details] [diff] [review]
>   --> https://bugzilla.mozilla.org/attachment.cgi?id=749278
> Patch (v1)
> 
> Now we can move _CRT_SECURE_NO_WARNINGS and _CRT_NONSTDC_NO_WARNINGS outside
> the if-statements because MSVC8 is not supported anymore.

Please file a follow-up bug for that.
Blocks: 872018
Blocks: 872028
Blocks: 872127
https://hg.mozilla.org/mozilla-central/rev/172c746ee073
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Blocks: 937906
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.