866464 - Write window observer tests for Fennec

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

We can't open new windows on Fennec so testing the window/observer module and various other modules that observe window events on Fennec is difficult.

We could merely test that using the APIs doesn't cause an error.  We could also create a custom Loader instance with fake window util modules.

The latter seems reasonable to me, in addition to running the current tests we have when they make sense (on anything not Fennec).

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Is this necessary? What benefits would there be for using this module on Fennec? Right now it's just being skipped entirely. The window load event is probably fired before SDK is even loaded (which is the case for the initial tab on Fennec)

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #1)
> Is this necessary? What benefits would there be for using this module on
> Fennec? Right now it's just being skipped entirely. The window load event is
> probably fired before SDK is even loaded (which is the case for the initial
> tab on Fennec)

So testing that the module doesn't throw errors seems good enough to me, since it might be used in a add-on that is supposed to work on Fennec and Firefox.

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: GH PR 1165

Comment 4

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 789766 [details]
GH PR 1165

I'd like to see that adding observers does not cause a crash as well.

Comment 5

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to Erik Vold [:erikvold] [:ztatic] from comment #4)
> Comment on attachment 789766 [details]
> GH PR 1165
> 
> I'd like to see that adding observers does not cause a crash as well.

*cause an error

I have crashes on the mind, sorry.

Comment 6

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 789766 [details]
GH PR 1165

Ah, here we go -- adding observers. Also unbinding, looks like we were not doing that previously.

Comment 7

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/7762f9610bf7f997c123894de12fb346d33a457c
Bug 866464 test window-observer doesn't throw on Fennec

https://github.com/mozilla/addon-sdk/commit/a031a55986ce827854d0718b0ebfc4d39eb591f7
Merge pull request #1165 from jsantell/866464-test-fennec-window-observer

Fix Bug 866464 test window-observer doesn't throw on Fennec, r+=@erikvold