Closed
Bug 866837
Opened 13 years ago
Closed 12 years ago
Create "Save Page" widget
Categories
(Firefox :: Toolbars and Customization, defect)
Firefox
Toolbars and Customization
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: mconley, Assigned: mikedeboer)
References
()
Details
Attachments
(1 file, 2 obsolete files)
|
2.07 KB,
patch
|
mikedeboer
:
review+
|
Details | Diff | Splinter Review |
According to http://people.mozilla.com/~zfang/Customization/MenuPanel.jpg, we're going to want a widget to save the current page.
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → mdeboer
|
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #745159 -
Flags: review?(mconley)
|
Reporter | |
Comment 2•13 years ago
|
||
Comment on attachment 745159 [details] [diff] [review]
Add 'Save Page' button widget to toolbar/ customize panel
Review of attachment 745159 [details] [diff] [review]:
-----------------------------------------------------------------
Canceling review because we're switching these to use the new widget API thing.
Attachment #745159 -
Flags: review?(mconley)
|
|
Assignee | |
Comment 3•13 years ago
|
||
Attachment #745159 -
Attachment is obsolete: true
Attachment #745171 -
Flags: review?(mconley)
|
|
Reporter | |
Comment 4•13 years ago
|
||
Comment on attachment 745171 [details] [diff] [review]
Add 'Save Page' button widget to toolbar/ customize panel
Review of attachment 745171 [details] [diff] [review]:
-----------------------------------------------------------------
r=me with the comment below fixed.
::: browser/components/customizableui/src/CustomizableUI.jsm
@@ +191,5 @@
> + "32": "chrome://branding/content/icon48.png",
> + "48": "chrome://branding/content/icon48.png"
> + },
> + onCommand: function(aEvent) {
> + let win = aEvent.target && aEvent.target.ownerDocument && aEvent.target.ownerDocument.defaultView;
Let's break up this boolean, like this:
let win = aEvent.target &&
aEvent.target.ownerDocument &&
aEvent.target.ownerDocument.defaultView;
Attachment #745171 -
Flags: review?(mconley) → review+
|
|
Assignee | |
Updated•13 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 5•13 years ago
|
||
addressed comments, carrying over r+=mconley
Attachment #745171 -
Attachment is obsolete: true
Attachment #745382 -
Flags: review+
|
|
Reporter | |
Comment 6•13 years ago
|
||
Whiteboard: [fixed-in-jamun]
|
||
Updated•13 years ago
|
Whiteboard: [fixed-in-jamun] → [fixed-in-jamun][fixed-in-ux]
|
||
Comment 7•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-jamun][fixed-in-ux]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•