866837 - Create "Save Page" widget

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

According to http://people.mozilla.com/~zfang/Customization/MenuPanel.jpg, we're going to want a widget to save the current page.

Comment 1

[Mike de Boer [:mikedeboer]]

Attachment: Add 'Save Page' button widget to toolbar/ customize panel

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 745159 [details] [diff] [review]
Add 'Save Page' button widget to toolbar/ customize panel

Review of attachment 745159 [details] [diff] [review]:
-----------------------------------------------------------------

Canceling review because we're switching these to use the new widget API thing.

Comment 3

[Mike de Boer [:mikedeboer]]

Attachment: Add 'Save Page' button widget to toolbar/ customize panel

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 745171 [details] [diff] [review]
Add 'Save Page' button widget to toolbar/ customize panel

Review of attachment 745171 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the comment below fixed.

::: browser/components/customizableui/src/CustomizableUI.jsm
@@ +191,5 @@
> +      "32": "chrome://branding/content/icon48.png",
> +      "48": "chrome://branding/content/icon48.png"
> +    },
> +    onCommand: function(aEvent) {
> +      let win = aEvent.target && aEvent.target.ownerDocument && aEvent.target.ownerDocument.defaultView;

Let's break up this boolean, like this:

let win = aEvent.target &&
          aEvent.target.ownerDocument &&
          aEvent.target.ownerDocument.defaultView;

Comment 5

[Mike de Boer [:mikedeboer]]

Attachment: Add 'Save Page' button widget to toolbar/ customize panel

addressed comments, carrying over r+=mconley

Comment 6

[Mike Conley (:mconley) (:⚙️)]

https://hg.mozilla.org/projects/jamun/rev/145f7fe00c0f

Comment 7

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/145f7fe00c0f