Closed
Bug 866838
Opened 12 years ago
Closed 12 years ago
Create "Find" widget
Categories
(Firefox :: Toolbars and Customization, defect)
Firefox
Toolbars and Customization
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: mconley, Assigned: mikedeboer)
References
()
Details
Attachments
(1 file, 2 obsolete files)
|
2.20 KB,
patch
|
mikedeboer
:
review+
|
Details | Diff | Splinter Review |
According to http://people.mozilla.com/~zfang/Customization/MenuPanel.jpg, we're going to want a widget to open up the Find toolbar.
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → mdeboer
|
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #745165 -
Flags: review?(mconley)
|
|
Assignee | |
Updated•12 years ago
|
Status: NEW → ASSIGNED
|
Reporter | |
Comment 2•12 years ago
|
||
Comment on attachment 745165 [details] [diff] [review]
Add Find button widget to toolbar/ customize panel
Review of attachment 745165 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks for working on this, Mike!
::: browser/base/content/browser.xul
@@ +1056,5 @@
> type="checkbox"
> label="&fullScreenCmd.label;"
> tooltiptext="&fullScreenButton.tooltip;"/>
>
> + <toolbarbutton id="find-button" class="toolbarbutton-1 chromeclass-toolbar-additional"
Ah, like in bug 866836, I believe we want you to add the widget via the new widget API instead of the old XUL approach.
Attachment #745165 -
Flags: review?(mconley)
|
|
Assignee | |
Comment 3•12 years ago
|
||
Attachment #745165 -
Attachment is obsolete: true
Attachment #745177 -
Flags: review?(mconley)
|
|
Reporter | |
Comment 4•12 years ago
|
||
Comment on attachment 745177 [details] [diff] [review]
Add Find button widget to toolbar/ customize panel
Review of attachment 745177 [details] [diff] [review]:
-----------------------------------------------------------------
Besides the one comment, looks great - r=me. Thanks!
::: browser/components/customizableui/src/CustomizableUI.jsm
@@ +209,5 @@
> + "32": "chrome://branding/content/icon48.png",
> + "48": "chrome://branding/content/icon48.png"
> + },
> + onCommand: function(aEvent) {
> + let win = aEvent.target && aEvent.target.ownerDocument && aEvent.target.ownerDocument.defaultView;
Like in bug 866837, I'd like the boolean broken up over 3 lines.
Attachment #745177 -
Flags: review?(mconley) → review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
addressed comments, carrying over r+=mconley
Attachment #745177 -
Attachment is obsolete: true
Attachment #745383 -
Flags: review+
|
|
Reporter | |
Comment 6•12 years ago
|
||
Whiteboard: [fixed-in-jamun]
|
||
Updated•12 years ago
|
Whiteboard: [fixed-in-jamun] → [fixed-in-jamun][fixed-in-ux]
|
||
Comment 7•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-jamun][fixed-in-ux]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•