Closed
Bug 866841
Opened 12 years ago
Closed 12 years ago
Create "Add-ons" widget
Categories
(Firefox :: Toolbars and Customization, defect)
Firefox
Toolbars and Customization
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: mconley, Assigned: mikedeboer)
References
()
Details
Attachments
(1 file, 1 obsolete file)
|
2.23 KB,
patch
|
mikedeboer
:
review+
|
Details | Diff | Splinter Review |
According to http://people.mozilla.com/~zfang/Customization/MenuPanel.jpg, we're going to want a widget to open up the Add-ons tab.
|
||
Updated•12 years ago
|
Assignee: nobody → gijskruitbosch+bugs
|
Assignee | |
Updated•12 years ago
|
Assignee: gijskruitbosch+bugs → mdeboer
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #745203 -
Flags: review?(mconley)
|
Reporter | |
Comment 2•12 years ago
|
||
Comment on attachment 745203 [details] [diff] [review]
Add 'Add-ons' button widget to toolbar/ customize panel
Review of attachment 745203 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/components/customizableui/src/CustomizableUI.jsm
@@ +263,5 @@
> + "32": "chrome://branding/content/icon48.png",
> + "48": "chrome://branding/content/icon48.png"
> + },
> + onCommand: function(aEvent) {
> + let win = aEvent.target && aEvent.target.ownerDocument && aEvent.target.ownerDocument.defaultView;
Break over 3 lines.
Attachment #745203 -
Flags: review?(mconley) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
addressed comments, carrying over r+=mconley
Attachment #745203 -
Attachment is obsolete: true
Attachment #745389 -
Flags: review+
|
|
Assignee | |
Updated•12 years ago
|
Attachment #745389 -
Attachment is patch: true
Attachment #745389 -
Attachment mime type: text/x-patch → text/plain
|
|
Reporter | |
Comment 4•12 years ago
|
||
Whiteboard: [fixed-in-jamun]
|
||
Updated•12 years ago
|
Whiteboard: [fixed-in-jamun] → [fixed-in-jamun][fixed-in-ux]
|
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-jamun][fixed-in-ux]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•