All users were logged out of Bugzilla on October 13th, 2018

Create "Add-ons" widget

RESOLVED FIXED in Firefox 28

Status

()

RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: mconley, Assigned: mikedeboer)

Tracking

Trunk
Firefox 28
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
According to http://people.mozilla.com/~zfang/Customization/MenuPanel.jpg, we're going to want a widget to open up the Add-ons tab.

Updated

6 years ago
Assignee: nobody → gijskruitbosch+bugs
(Assignee)

Updated

6 years ago
Assignee: gijskruitbosch+bugs → mdeboer
Status: NEW → ASSIGNED
(Assignee)

Comment 1

6 years ago
Created attachment 745203 [details] [diff] [review]
Add 'Add-ons' button widget to toolbar/ customize panel
Attachment #745203 - Flags: review?(mconley)
(Assignee)

Updated

6 years ago
Depends on: 866845
(Assignee)

Updated

6 years ago
Blocks: 866840
(Reporter)

Comment 2

6 years ago
Comment on attachment 745203 [details] [diff] [review]
Add 'Add-ons' button widget to toolbar/ customize panel

Review of attachment 745203 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/customizableui/src/CustomizableUI.jsm
@@ +263,5 @@
> +      "32": "chrome://branding/content/icon48.png",
> +      "48": "chrome://branding/content/icon48.png"
> +    },
> +    onCommand: function(aEvent) {
> +      let win = aEvent.target && aEvent.target.ownerDocument && aEvent.target.ownerDocument.defaultView;

Break over 3 lines.
Attachment #745203 - Flags: review?(mconley) → review+
(Assignee)

Comment 3

6 years ago
Created attachment 745389 [details] [diff] [review]
Add 'Add-ons' button widget to toolbar/ customize panel

addressed comments, carrying over r+=mconley
Attachment #745203 - Attachment is obsolete: true
Attachment #745389 - Flags: review+
(Assignee)

Updated

6 years ago
Attachment #745389 - Attachment is patch: true
Attachment #745389 - Attachment mime type: text/x-patch → text/plain
No longer depends on: 855290
Whiteboard: [fixed-in-jamun] → [fixed-in-jamun][fixed-in-ux]

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/16b138a0006b
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-jamun][fixed-in-ux]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.