Closed Bug 866878 Opened 7 years ago Closed 6 years ago

BaselineCompiler: Compile try-finally

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(1 file, 1 obsolete file)

None of our JITs compile |finally|, but Baseline should handle it. JSIL (C# to JS compiler) needs this.
Blocks: 872184
Assignee: general → jdemooij
Status: NEW → ASSIGNED
Attached patch WIP (obsolete) — Splinter Review
Passes jit-tests/jstests on x86 with/without --baseline-eager.

TODO: more comments, more tests, x64/ARM support, fuzzing.
Attached patch PatchSplinter Review
Kannan, sorry for dropping another largish patch in your queue, but you're the best reviewer for it. A good chunk of it is tests though and the Baseline changes turned out to be pretty straight-forward.

We use an IC for JSOP_RETSUB's pc offset -> native address mapping. We can optimize this later but for now following the interpreter is the easiest approach I think and it's still a lot faster than the interpreter.
Attachment #756736 - Attachment is obsolete: true
Attachment #763552 - Flags: review?(kvijayan)
Comment on attachment 763552 [details] [diff] [review]
Patch

Review of attachment 763552 [details] [diff] [review]:
-----------------------------------------------------------------

Nice work.  I tried to find something to correct about this patch, but failed.  Good to have try/finally being compiled.
Attachment #763552 - Flags: review?(kvijayan) → review+
I'd love to test this out against a win32 try build and see what kind of performance gains it delivers for my test cases.
Blocks: 885526
(In reply to Kevin Gadd (:kael) from comment #4)
> I'd love to test this out against a win32 try build and see what kind of
> performance gains it delivers for my test cases.

It's building now: https://tbpl.mozilla.org/?tree=Try&rev=89bc9b7b853c Click on the B and "go to build directory" to download it when it's done. Will take a few hours, assuming it even compiles.

Note that it's a non-PGO build, in case you want to compare it with other builds.

Please let me know if/how it works :)
https://hg.mozilla.org/mozilla-central/rev/d6cedeb7ec3a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.