866878 - BaselineCompiler: Compile try-finally

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

None of our JITs compile |finally|, but Baseline should handle it. JSIL (C# to JS compiler) needs this.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: WIP

Passes jit-tests/jstests on x86 with/without --baseline-eager.

TODO: more comments, more tests, x64/ARM support, fuzzing.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Patch

Kannan, sorry for dropping another largish patch in your queue, but you're the best reviewer for it. A good chunk of it is tests though and the Baseline changes turned out to be pretty straight-forward.

We use an IC for JSOP_RETSUB's pc offset -> native address mapping. We can optimize this later but for now following the interpreter is the easiest approach I think and it's still a lot faster than the interpreter.

Comment 3

[Kannan Vijayan [:djvj]]

Comment on attachment 763552 [details] [diff] [review]
Patch

Review of attachment 763552 [details] [diff] [review]:
-----------------------------------------------------------------

Nice work.  I tried to find something to correct about this patch, but failed.  Good to have try/finally being compiled.

Comment 4

[Katelyn Gadd (:kael)]

I'd love to test this out against a win32 try build and see what kind of performance gains it delivers for my test cases.

Comment 5

[Jan de Mooij [:jandem]]

(In reply to Kevin Gadd (:kael) from comment #4)
> I'd love to test this out against a win32 try build and see what kind of
> performance gains it delivers for my test cases.

It's building now: https://tbpl.mozilla.org/?tree=Try&rev=89bc9b7b853c Click on the B and "go to build directory" to download it when it's done. Will take a few hours, assuming it even compiles.

Note that it's a non-PGO build, in case you want to compare it with other builds.

Please let me know if/how it works :)

Comment 6

[Jan de Mooij [:jandem]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d6cedeb7ec3a

Try: https://tbpl.mozilla.org/?tree=Try&rev=fc47dc2d25aa

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/d6cedeb7ec3a