867008 - Remove previous calls to PlacesUtils.backups and move them to PlacesBackups (SeaMonkey)

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Frank Wein [:mcsmurf]]

See Bug 855638, PlacesUtils.backups has been deprecated and replaced by PlacesBackups.

Comment 1

[Frank Wein [:mcsmurf]]

Attachment: Patch

This is what has been done so far, this does not replace every occurrence of PlacesUtils.backups though. Part of that will be done in Bug 867068 as some of this involves switching to the new async API.

Comment 2

[Frank Wein [:mcsmurf]]

Attachment: Patch 2

Comment 3

[Frank Wein [:mcsmurf]]

Attachment: Patch 3

Simple find&replace patch (plus adding the new PlacesBackups module to the relevent files). See http://hg.mozilla.org/mozilla-central/annotate/60e522be9d08/toolkit/components/places/PlacesUtils.jsm#l1575 for what PlacesUtils.backups does these days, it just returns the PlacesBackups object (ignore Comment 1 from this bug, it was wrong).

Comment 4

[[e-mail]]

Comment on attachment 743595 [details] [diff] [review]
Patch 3

>     Components.utils.import("resource://gre/modules/PlacesUtils.jsm");
>     Components.utils.import("resource:///modules/PlacesUIUtils.jsm");
>+    Components.utils.import("resource://gre/modules/PlacesBackups.jsm");
Nit: PlacesUIUtils last. (If you decide that PlacesBackups goes first, change it in the other files too.)

Comment 5

[Frank Wein [:mcsmurf]]

Pushed with PlacesBackup being in the middle between PlacesUtils and PlacesUIUtils: https://hg.mozilla.org/comm-central/rev/4628ff514b94