Closed Bug 867008 Opened 8 years ago Closed 8 years ago

Remove previous calls to PlacesUtils.backups and move them to PlacesBackups (SeaMonkey)

Categories

(SeaMonkey :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.20

People

(Reporter: mcsmurf, Assigned: mcsmurf)

References

Details

Attachments

(1 file, 2 obsolete files)

See Bug 855638, PlacesUtils.backups has been deprecated and replaced by PlacesBackups.
OS: Windows 7 → All
Hardware: x86_64 → All
Attached patch Patch (obsolete) — Splinter Review
This is what has been done so far, this does not replace every occurrence of PlacesUtils.backups though. Part of that will be done in Bug 867068 as some of this involves switching to the new async API.
Attached patch Patch 2 (obsolete) — Splinter Review
Attachment #743498 - Attachment is obsolete: true
Attached patch Patch 3Splinter Review
Simple find&replace patch (plus adding the new PlacesBackups module to the relevent files). See http://hg.mozilla.org/mozilla-central/annotate/60e522be9d08/toolkit/components/places/PlacesUtils.jsm#l1575 for what PlacesUtils.backups does these days, it just returns the PlacesBackups object (ignore Comment 1 from this bug, it was wrong).
Assignee: nobody → bugzilla
Attachment #743500 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #743595 - Flags: review?(neil)
Comment on attachment 743595 [details] [diff] [review]
Patch 3

>     Components.utils.import("resource://gre/modules/PlacesUtils.jsm");
>     Components.utils.import("resource:///modules/PlacesUIUtils.jsm");
>+    Components.utils.import("resource://gre/modules/PlacesBackups.jsm");
Nit: PlacesUIUtils last. (If you decide that PlacesBackups goes first, change it in the other files too.)
Attachment #743595 - Flags: review?(neil) → review+
Pushed with PlacesBackup being in the middle between PlacesUtils and PlacesUIUtils: https://hg.mozilla.org/comm-central/rev/4628ff514b94
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.20
You need to log in before you can comment on or make changes to this bug.