Closed Bug 867040 Opened 7 years ago Closed 7 years ago

[Calendar][User Story] Direct event creation at specific date/time


(Firefox OS Graveyard :: Gaia::Calendar, defect)

Gonk (Firefox OS)
Not set


(blocking-b2g:leo+, b2g18+ verified)

1.1 QE2 (6jun)
blocking-b2g leo+
Tracking Status
b2g18 + verified


(Reporter: pdol, Assigned: gaye)




(Keywords: feature, relnote, Whiteboard: c=, relnote-b2g:1.1+)


(5 files)

UCID: Calendar-052

User Story:
As a user, I would like to be able to add an event to the calendar to a specific date/time, with a one hour duration, without having to first create an event and manually selecting the start time, in order to make event creation much quicker.
Depends on: 861226
Assignee: nobody → gaye
The "existing_events" PDF shows how quick-add should work if the user already has a booking in a specific time slot. 

The "no events" PDF shows that if the user taps on the margin with the time, it should do the same thing as it would if the user had hit the "correct" time spot.
Depends on: 869216
No longer depends on: 869216
Attached file Pull request
Attachment #747073 - Flags: review?(kgrandon)
Attachment #747073 - Attachment mime type: text/plain → text/html
tracking-b2g18: --- → +
Whiteboard: c=
Keywords: feature
Comment on attachment 747073 [details]
Pull request

Review is done. Just two small issues I found in the pull request (bubbling and back flow). After those are resolved I think we can land.
Attachment #747073 - Flags: review?(kgrandon)
Attachment #749130 - Attachment mime type: text/plain → text/html
Hey All,

Went ahead and made a video of me playing around with the tap to create feature. Let me know if this looks good for the first pass :).
Flags: needinfo?(pdolanjski)
(In reply to gaye from comment #6)
> Went ahead and made a video of me playing around with the tap to create
> feature. Let me know if this looks good for the first pass :).

Looks solid!  Nice work.
Flagging UX for review.
Flags: needinfo?(pdolanjski) → needinfo?(firefoxos-ux-bugzilla)
Attachment #747073 - Flags: review+
Landed in master:
Closed: 7 years ago
Resolution: --- → FIXED
Attached file Uplift Request
NOTE: Please see to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Tap to create feature request
User impact if declined: They won't have this beautiful feature! (Which LG requested)
Testing completed: All of the javascript is unit-tested and both kgrandon and I have tried this out on devices.
Risk to taking this patch (and alternatives if risky): The feature was well tested and contained to the day view so I think the risk is pretty low.
String or UUID changes made by this patch: None
Attachment #751110 - Flags: approval-gaia-v1?
This is going to require QA signoff to get uplift on a non-blocking feature. I'll try to look into this when some of 1.01 fires calm down a bit.
Flags: needinfo?(firefoxos-ux-bugzilla)
Keywords: qawanted
QA Contact: jsmith
Cyee just gave a thumbs up for ux with the caveat that a hit-state when we tap on the time slot would be a nice to have.
Looks great! :)
Comment on attachment 751110 [details]
Uplift Request

Let's let this ship in v1.2 - fairly major enhancement for where we are in the release.
Attachment #751110 - Flags: approval-gaia-v1? → approval-gaia-v1-
Pulling qawanted since uplift isn't going to happen here.
Keywords: qawanted
blocking-b2g: --- → leo+
Attachment #751110 - Flags: approval-gaia-v1- → approval-gaia-v1?
leo+ < = > approval-gaia-v1+ ?
Comment on attachment 751110 [details]
Uplift Request

If you've got a leo+, then you don't need approval. You get approval by default if it's a leo+.
Attachment #751110 - Flags: approval-gaia-v1?
Flags: in-moztrap?(jsmith)
Keywords: verifyme
Uplifted 9547f81c98f77c58e4d2d52c91906d1845f7cf81 to:
v1-train: e5712b2a55cd4785142c01529048a5a5c84f22da
Duplicate of this bug: 813149
Flags: in-moztrap?(jsmith) → in-moztrap+
Target Milestone: --- → 1.1 QE2 (6jun)
lgtm on 6/6 unagi b2g18 build. Very robust, no issues found running through the day view on a few days and tapping to add events on hour & all-day event blocks.
Keywords: relnote
Whiteboard: c= → c=, relnote-b2g:1.1+
You need to log in before you can comment on or make changes to this bug.