867040 - [Calendar][User Story] Direct event creation at specific date/time

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Peter Dolanjski [:pdol]]

UCID: Calendar-052

User Story:
As a user, I would like to be able to add an event to the calendar to a specific date/time, with a one hour duration, without having to first create an event and manually selecting the start time, in order to make event creation much quicker.

Comment 1

[Stephany Wilkes]

Attachment: UX for adding events from a day and time when there are no existing events.

Comment 2

[Stephany Wilkes]

Attachment: UX for adding events from a day and time when there *are* existing events

The "existing_events" PDF shows how quick-add should work if the user already has a booking in a specific time slot. 

The "no events" PDF shows that if the user taps on the margin with the time, it should do the same thing as it would if the user had hit the "correct" time spot.

Comment 3

[Gareth Aye [:gaye] (back from PTO)]

Attachment: Pull request

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 747073 [details]
Pull request

Review is done. Just two small issues I found in the pull request (bubbling and back flow). After those are resolved I think we can land.

Comment 5

[Gareth Aye [:gaye] (back from PTO)]

Attachment: Pointer to Feature Video

Comment 6

[Gareth Aye [:gaye] (back from PTO)]

Hey All,

Went ahead and made a video of me playing around with the tap to create feature. Let me know if this looks good for the first pass :).

Comment 7

[Peter Dolanjski [:pdol]]

(In reply to gaye from comment #6)
> Went ahead and made a video of me playing around with the tap to create
> feature. Let me know if this looks good for the first pass :).

Looks solid!  Nice work.
Flagging UX for review.

Comment 8

[Kevin Grandon :kgrandon]

Landed in master: https://github.com/mozilla-b2g/gaia/commit/9547f81c98f77c58e4d2d52c91906d1845f7cf81

Comment 9

[Gareth Aye [:gaye] (back from PTO)]

Attachment: Uplift Request

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Tap to create feature request
User impact if declined: They won't have this beautiful feature! (Which LG requested)
Testing completed: All of the javascript is unit-tested and both kgrandon and I have tried this out on devices.
Risk to taking this patch (and alternatives if risky): The feature was well tested and contained to the day view so I think the risk is pretty low.
String or UUID changes made by this patch: None

Comment 10

[Jason Smith [:jsmith]]

This is going to require QA signoff to get uplift on a non-blocking feature. I'll try to look into this when some of 1.01 fires calm down a bit.

Comment 11

[Gareth Aye [:gaye] (back from PTO)]

Cyee just gave a thumbs up for ux with the caveat that a hit-state when we tap on the time slot would be a nice to have.

Comment 12

[Casey Yee]

Looks great! :)

Comment 13

[Alex Keybl [:akeybl]]

Comment on attachment 751110 [details]
Uplift Request

Let's let this ship in v1.2 - fairly major enhancement for where we are in the release.

Comment 14

[Jason Smith [:jsmith]]

Pulling qawanted since uplift isn't going to happen here.

Comment 15

[Gareth Aye [:gaye] (back from PTO)]

leo+ < = > approval-gaia-v1+ ?

Comment 16

[Jason Smith [:jsmith]]

Comment on attachment 751110 [details]
Uplift Request

If you've got a leo+, then you don't need approval. You get approval by default if it's a leo+.

Comment 17

[Gareth Aye [:gaye] (back from PTO)]

Uplifted 9547f81c98f77c58e4d2d52c91906d1845f7cf81 to:
v1-train: e5712b2a55cd4785142c01529048a5a5c84f22da

Comment 19

[Jason Smith [:jsmith]]

lgtm on 6/6 unagi b2g18 build. Very robust, no issues found running through the day view on a few days and tapping to add events on hour & all-day event blocks.