867045 - [Buri][Home screen]User can delete apps in Idle screen,after download version and reboot handset is not the same

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect, P2)

Description

[sync-1]

+++ This bug was initially created as a clone of Bug #447692 +++
 
 AU_LINUX_GECKO_ICS_STRAWBERRY_V1.01.00.01.019.085
 Firefox os  v1.0.1
 Mozilla build ID:20130422230201
 
 Created an attachment (id=400526)
 Before reboot
 
 DEFECT DESCRIPTION:
 User can delete apps in Idle screen,after download version and reboot handset is not the same 
 
  REPRODUCING PROCEDURES:
 1.Download the new version,eg:SW126
 2.Power on,long press any app in Idle screen,user only can delete "Youtobe" app--->KO
 3.Reboot handset,long press any app in Idle screen,user can select 13 apps to delete(like attachment)
 
  EXPECTED BEHAVIOUR:
 User can delete apps in Idle screen,after download version and reboot handset should be same 
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:
 5/5
 
  For FT PR, Please list reference mobile's behavior:
 
 ++++++++++ end of initial bug #447692 description ++++++++++
 
 
 
 CONTACT INFO (Name,Phone number):
 
  DEFECT DESCRIPTION:
 
  REPRODUCING PROCEDURES:
 
  EXPECTED BEHAVIOUR:
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:
 
  For FT PR, Please list reference mobile's behavior:

Comment 1

[sync-1]

Clone from brother

Comment 2

[sync-1]

Attachment: Before reboot

Clone from brother

Comment 3

[sync-1]

Clone from brother

Comment 4

[sync-1]

Attachment: After reboot

Clone from brother

Comment 5

[buri.blff]

In gaia/apps/homescreen/js/grid.js
    var descriptor = {
      bookmarkURL: app.bookmarkURL,
      manifestURL: app.manifestURL,
      entry_point: entryPoint,
      updateTime: app.updateTime,
      removable: app.removable,
      name: iconsAndNameHolder.name,
      icon: bestMatchingIcon(app, iconsAndNameHolder),
      useAsyncPanZoom: app.useAsyncPanZoom
    }
removable got from app info.

In gaia/apps/homescreen/js/page.js
    if (descriptor.removable) {
      // Menu button to delete the app
      var options = document.createElement('span');
      options.className = 'options';
      options.dataset.isIcon = true;
      container.appendChild(options);
    }
If removable is true, the app will be added an options.

But first time boot up, the removable infomation from app is not correct. It's just "undefined"

Comment 6

[Cristian Rodriguez (:crdlc)]

Attachment: Patch to make a robust condition in home

Basically the homescreen would add the 'X' icon when <app.removable> is equal to true. This path makes more robust the condition, doesn't fix anything.  From my point of view, the problem is in backend instead of Gaia. The <app.removable> info is not correct when the API returns that info sometimes. Maybe, you could view if the homescreen shows removable apps wrong while Settings app is showing this info correctly. IMHO if the info is wrong in home and settings apps the error is on the backend part.

Comment 7

[Jason Smith [:jsmith]]

Do we need this for tef? leo?

Wondering if this blocks either of those releases.

Comment 8

[Antonio Manuel Amaya Calvo (:amac)]

Stealing this, Cristian. From the description I think the problem might be on the platform.

I don't think this qualifies as tef+ at this time, requesting leo+ so it can be triaged.

Comment 9

[Daniel Coloma:dcoloma]

This seems to happen when you apply customisation, which is the case for all commercial devices: tef+. Antonio, what is the ETA for this?

Comment 10

[Cristian Rodriguez (:crdlc)]

Finally I guess that the problem is in Homescreen, sorry

Comment 11

[Cristian Rodriguez (:crdlc)]

Attachment: This patch fixes the bug

The first time when the homescreen is launched, it loads apps from the info pre-generated in build time instead of waiting for the info from the API. When the grid is painted, we receive the info from the API, then we updated sadly the icon and label but nothing related to removable flagz. The patch has not risk. Now the 'x' icon is rendered with the info from the API as well or when an app is already installed

Comment 12

[Cristian Rodriguez (:crdlc)]

https://github.com/mozilla-b2g/gaia/commit/dfd7a7c2f9f70fcda98073d0db33973f602d0199

Comment 13

[Daniel Coloma:dcoloma]

This is blocking the beginning of the certification. Cristian can you please uplift on your own?

Comment 14

[Cristian Rodriguez (:crdlc)]

v1-train:

https://github.com/mozilla-b2g/gaia/commit/cc2fd02fd461aa12c96e02229a78293365d65264

v1.0.1:

https://github.com/mozilla-b2g/gaia/commit/26d9430df4cd670e46a208a6e4b6d77e4b27ed75

Comment 15

[Jason Smith [:jsmith]]

I need a better understanding of this bug.

Is this basically that on first run, certain apps can't be uninstalled? Post first run after a reboot, they can be?

Comment 16

[Daniel Coloma:dcoloma]

(In reply to Jason Smith [:jsmith] from comment #15)
> I need a better understanding of this bug.
> 
> Is this basically that on first run, certain apps can't be uninstalled? Post
> first run after a reboot, they can be?

Yes, that is the issue, after rebooting, apps can be deleted as they should be.

Comment 18

[Jason Smith [:jsmith]]

(In reply to Daniel Coloma:dcoloma from comment #16)
> (In reply to Jason Smith [:jsmith] from comment #15)
> > I need a better understanding of this bug.
> > 
> > Is this basically that on first run, certain apps can't be uninstalled? Post
> > first run after a reboot, they can be?
> 
> Yes, that is the issue, after rebooting, apps can be deleted as they should
> be.

Ah. That probably explains what happened over in bug 875066.

Comment 19

[Cristian Rodriguez (:crdlc)]

I gonna add some tests in bug 876623

Comment 20

[Jason Smith [:jsmith]]

Verified on a 5/30 Partner Build by checking that apps were uninstallable on initial flash + one reboot.

Comment 21

[mdaniloff]

This issue no longer reproduces on Leo V1.1 User is able to delete apps on first run, and also post first run after a reboot.

Leo build Mozz 1.1: 20130529070208
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/6ca32ed2bbc6
Gaia: 8f5ab7bfd4a2921aab4e2de11e0d79a29c1bb062