867368 - Remove the Bookmarks sidebar control as a toolbar customization item

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

We now have quite a few bookmark-related items in our customization palette. Bug 855805 is implementing the new bookmarks widget, and thus we shouldn't have multiple bookmark widgets within our customization palette. Having multiple will just lead to user confusion and make guiding users through our support harder.

The Bookmarks item that will be removed is the one that toggles the visibility of the Bookmarks sidebar. We will keep the Bookmarks item that allows the user to view their bookmarks in a panel/popup as well as convenient access to bookmarking the current page.

This bug is not concerned with removing the bookmarks sidebar.

Comment 1

[Marco Bonardo [:mak]]

is there an equivalent for the history button that opens the sidebar?
i suppose the same reasoning applies

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Marco Bonardo [:mak] from comment #1)
> is there an equivalent for the history button that opens the sidebar?
> i suppose the same reasoning applies

Thanks, I just filed that as bug 868135.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

Here's a first pass at this. Am I forgetting anything?

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 753900 [details] [diff] [review]
Patch v1

You forgot to remove the bookmarksButton.tooltip string and bookmarksButtonObserver.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 753900 [details] [diff] [review]
Patch v1

(In reply to Dão Gottwald [:dao] from comment #4)
> Comment on attachment 753900 [details] [diff] [review]
> Patch v1
> 
> You forgot to remove the bookmarksButton.tooltip string and
> bookmarksButtonObserver.

Ah yes, thank you.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1.1

Now with less bookmarksButton.tooltip and bookmarksButtonObserver.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 753938 [details] [diff] [review]
Patch v1.1

Review of attachment 753938 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Landed on UX as https://hg.mozilla.org/projects/ux/rev/737b158fd80f

Comment 9

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/737b158fd80f

Comment 10

[Jim Michaels]

mistake. please bring it back. it's a productivity thing and speeds up my work. sometimes I need to quickly click the sidebar on or off for a given wide page.

Comment 11

[Marco Bonardo [:mak]]

CTR add-on can add back the sidebar buttons, if you want to try it
https://addons.mozilla.org/firefox/addon/classicthemerestorer/
A much simpler add-on could easily be created, just for the purpose of adding back the sidebar add-ons, I don't know if anyone made one yet.