Closed Bug 867368 Opened 7 years ago Closed 6 years ago

Remove the Bookmarks sidebar control as a toolbar customization item

Categories

(Firefox :: Toolbars and Customization, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 28

People

(Reporter: jaws, Assigned: mconley)

References

(Blocks 1 open bug)

Details

(Whiteboard: [Australis:M6])

Attachments

(1 file, 1 obsolete file)

We now have quite a few bookmark-related items in our customization palette. Bug 855805 is implementing the new bookmarks widget, and thus we shouldn't have multiple bookmark widgets within our customization palette. Having multiple will just lead to user confusion and make guiding users through our support harder.

The Bookmarks item that will be removed is the one that toggles the visibility of the Bookmarks sidebar. We will keep the Bookmarks item that allows the user to view their bookmarks in a panel/popup as well as convenient access to bookmarking the current page.

This bug is not concerned with removing the bookmarks sidebar.
Component: Migration → Toolbars
is there an equivalent for the history button that opens the sidebar?
i suppose the same reasoning applies
Summary: Remove the "Bookmarks" control as a possible customization item → Remove the Bookmarks sidebar control as a toolbar customization item
(In reply to Marco Bonardo [:mak] from comment #1)
> is there an equivalent for the history button that opens the sidebar?
> i suppose the same reasoning applies

Thanks, I just filed that as bug 868135.
No longer blocks: 860814
Whiteboard: [Australis:M6]
Assignee: nobody → mconley
Status: NEW → ASSIGNED
Attached patch Patch v1 (obsolete) — Splinter Review
Here's a first pass at this. Am I forgetting anything?
Attachment #753900 - Flags: review?(jaws)
Comment on attachment 753900 [details] [diff] [review]
Patch v1

You forgot to remove the bookmarksButton.tooltip string and bookmarksButtonObserver.
Comment on attachment 753900 [details] [diff] [review]
Patch v1

(In reply to Dão Gottwald [:dao] from comment #4)
> Comment on attachment 753900 [details] [diff] [review]
> Patch v1
> 
> You forgot to remove the bookmarksButton.tooltip string and
> bookmarksButtonObserver.

Ah yes, thank you.
Attachment #753900 - Flags: review?(jaws)
Attached patch Patch v1.1Splinter Review
Now with less bookmarksButton.tooltip and bookmarksButtonObserver.
Attachment #753900 - Attachment is obsolete: true
Attachment #753938 - Flags: review?(jaws)
Comment on attachment 753938 [details] [diff] [review]
Patch v1.1

Review of attachment 753938 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!
Attachment #753938 - Flags: review?(jaws) → review+
Landed on UX as https://hg.mozilla.org/projects/ux/rev/737b158fd80f
Whiteboard: [Australis:M6] → [Australis:M6][fixed-in-ux]
https://hg.mozilla.org/mozilla-central/rev/737b158fd80f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M6][fixed-in-ux] → [Australis:M6]
Target Milestone: --- → Firefox 28
mistake. please bring it back. it's a productivity thing and speeds up my work. sometimes I need to quickly click the sidebar on or off for a given wide page.
CTR add-on can add back the sidebar buttons, if you want to try it
https://addons.mozilla.org/firefox/addon/classicthemerestorer/
A much simpler add-on could easily be created, just for the purpose of adding back the sidebar add-ons, I don't know if anyone made one yet.
You need to log in before you can comment on or make changes to this bug.