Selecting "copy" from context menu for selected text dismisses selection

VERIFIED FIXED in Firefox 30

Status

defect
P2
normal
VERIFIED FIXED
6 years ago
5 years ago

People

(Reporter: jbecerra, Assigned: azasypkin)

Tracking

Trunk
Firefox 30
x86_64
Windows 8.1
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [selection] p=1 s=it-30c-29a-28b.1 r=ff30 )

Attachments

(1 attachment, 1 obsolete attachment)

Reporter

Description

6 years ago
Tested on 2013-04-30 using latest nightly built from http://hg.mozilla.org/mozilla-central/rev/dd0c611a0a27

While testing story in bug 831952 I noticed that tapping on "Copy" in the context menu for selected text dismissed the text selection. In IE the text selection remains after tapping on "Copy."

Steps:
1. Go to https://www.mozilla.org/about/manifesto.en.htm
2. Select a fragment of one of the paragraphs.
3. Tap to summon the context menu
4. Tap on "Copy"

Expected: Text selection remains, such that you can bring up the context menu again and select the other option or expand the selection.

Actual: Text selection is dismissed.
Reporter

Updated

6 years ago
Blocks: 831952
Whiteboard: feature=defect c=Context_menus u=metro_firefox_user p=0

Updated

6 years ago
OS: Windows 8 → Windows 8 Metro
Whiteboard: feature=defect c=Context_menus u=metro_firefox_user p=0 → [selection] feature=defect c=Context_menus u=metro_firefox_user p=0

Updated

6 years ago
Component: General → Input
Flags: needinfo?(ywang)

Updated

6 years ago
Priority: -- → P3
Flags: needinfo?(ywang)
:juanb, I understand this now works for you? Is that the case?
Flags: needinfo?(jbecerra)
Reporter

Comment 3

6 years ago
This does still doesn't work for me using the steps in comment #0. You have to select using touch in order to see the problem. If you select using the mouse then it works, meaning the selection is kept.
Flags: needinfo?(jbecerra)
The behavior is currently by design so we need to change what we do after selection. This is a p3, so it can wait.
Summary: defect - selecting "copy" from context menu for selected text dismisses selection → Defect - selecting "copy" from context menu for selected text dismisses selection
No longer blocks: metrov2defect&change
Summary: Defect - selecting "copy" from context menu for selected text dismisses selection → Selecting "copy" from context menu for selected text dismisses selection
Whiteboard: [selection] feature=defect c=Context_menus u=metro_firefox_user p=0 → [selection] [defect] p=0
Blocks: 957244
No longer blocks: 831952

Updated

6 years ago
Whiteboard: [selection] [defect] p=0 → [selection] [defect] p=1
Priority: P3 → --
Priority: -- → P3
Target Milestone: --- → Firefox 30
Assignee: nobody → azasypkin
Status: NEW → ASSIGNED
Priority: P3 → P2
QA Contact: jbecerra
Whiteboard: [selection] [defect] p=1 → [selection] [defect] p=1 s=it-30c-29a-28b.1
Posted patch copy.diff (obsolete) — Splinter Review
Attachment #8372351 - Flags: review?(jmathies)
Comment on attachment 8372351 [details] [diff] [review]
copy.diff

Review of attachment 8372351 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/base/tests/mochitest/browser_context_menu_tests.js
@@ +917,5 @@
> +  run: function test() {
> +    info(chromeRoot + "browser_context_menu_tests_02.html");
> +    yield addTab(chromeRoot + "browser_context_menu_tests_02.html");
> +
> +    purgeEventQueue();

I don't think we need these purge calls anymore. I think you can take this out without affecting the test.
Attachment #8372351 - Flags: review?(jmathies) → review+
Posted patch copy.diffSplinter Review
Thanks for review! Yeah, seems that purgeEventQueue call is redundant.
Attachment #8372351 - Attachment is obsolete: true
Attachment #8372387 - Flags: review+
https://hg.mozilla.org/integration/fx-team/rev/3d58bca0922a
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [selection] [defect] p=1 s=it-30c-29a-28b.1 → [selection] [defect] p=1 s=it-30c-29a-28b.1[fixed-in-fx-team]
Whiteboard: [selection] [defect] p=1 s=it-30c-29a-28b.1[fixed-in-fx-team] → [selection] p=1 s=it-30c-29a-28b.1 r=ff30 [fixed-in-fx-team]
Target Milestone: Firefox 30 → ---
https://hg.mozilla.org/mozilla-central/rev/3d58bca0922a
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [selection] p=1 s=it-30c-29a-28b.1 r=ff30 [fixed-in-fx-team] → [selection] p=1 s=it-30c-29a-28b.1 r=ff30
Target Milestone: --- → Firefox 30
Verified the following issue using the latest Nightly, used build:
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-02-11-03-02-01-mozilla-central/

Reproduced the original issue from comment #0 using the following build:
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-02-05-03-02-03-mozilla-central/

- Ensured that after taping on "Copy" via the context menu, the text that was selected via the grippers remains selected
- Ensured that after taping on "Copy Link" via the context menu, the text that was selected via the grippers remains selected
- Ensured that everything that was selected, pasted correctly (ensured that text was not missing once paste was used)
- Ensured that you can scroll through the website with the text selected without any issues
- Ensured that when you scroll through the website, the grippers disappeared and reappeared once scrolling has stopped (ensured they're selectable)
- Ensured that you can resize the previous selection via the grippers without any issues
- Ensured that you can zoom using the pinch gesture with the text still highlighted and made sure you can resize the selection while zoomed in
- Ensured that switching between different metro applications still has the text selected and the grippers visible
- Ensured that you can use the grippers after switching between different metro applications
- Went through all of the above test cases using different variations of snapped view
Status: RESOLVED → VERIFIED
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.