867540 - Search by attribute treats missing attribute as the string "null"

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[[e-mail]]

Steps to reproduce problem:

1. Inspect an HTML document
2. Find Nodes
3. Search by attr
4. Enter a bogus attribute name
5. Enter null as the value

Expected result: End of document reached.

Actual result: Matches every element in the document.

Comment 1

[[e-mail]]

Attachment: Quick hack

This doesn't work for empty attributes.

Comment 2

[[e-mail]]

Attachment: Possible patch

(untested)

Comment 3

[[e-mail]]

Attachment: Proposed patch

Since an empty regexp matches any string, the test is unnecessary.

Comment 4

[Colby Russell :crussell (no longer Mozilla-ing)]

Comment on attachment 744079 [details] [diff] [review]
Proposed patch

Review of attachment 744079 [details] [diff] [review]:
-----------------------------------------------------------------

::: resources/content/viewers/dom/dom.js
@@ +953,5 @@
>  
>      return aWalker.currentNode &&
>             aWalker.currentNode.nodeType == nsIDOMNode.ELEMENT_NODE &&
> +           aWalker.currentNode.hasAttribute(this.mFindParams[0]) &&
> +           re.test(aWalker.currentNode.getAttribute(this.mFindParams[0]));

Weird that we allow regular expressions everywhere else except this field's value for this type of search...

Comment 5

[[e-mail]]

(In reply to Colby Russell from comment #4)
> Weird that we allow regular expressions everywhere else except this field's
> value for this type of search...

You mean for the attribute name? Could be done, I suppose...

Comment 6

[Colby Russell :crussell (no longer Mozilla-ing)]

([e-mail] wrote in comment #5)
> (In reply to Colby Russell from comment #4)
> > Weird that we allow regular expressions everywhere else except this field's
> > value for this type of search...
> 
> You mean for the attribute name? Could be done, I suppose...

Dear meandering bugzilla reader, that's bug 867699.

Comment 7

[Colby Russell :crussell (no longer Mozilla-ing)]

Pushed: http://hg.mozilla.org/dom-inspector/rev/35137780b095