867563 - Fix select-all checkbox

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Ed Morley [:emorley]]

[14:36:33.683] SyntaxError: missing ( after for @ https://treestatus.allizom.org/?nc:11

Line 11 is:
{
for each(var checkbox in checkboxes)
}

Comment 1

[Ed Morley [:emorley]]

Attachment: Patch v1

Comment 2

[Chris AtLee [:catlee]]

Comment on attachment 744101 [details] [diff] [review]
Patch v1

Review of attachment 744101 [details] [diff] [review]:
-----------------------------------------------------------------

::: treestatus/templates/index.html
@@ +10,4 @@
>  function toggle(source) {
>    checkboxes = document.getElementsByName('tree');
> +  for(var i=0; i < checkboxes.length; i++)
> +    checkboxes[i].checked = source.checked;

can you add {} for this for loop?

Comment 3

[Ed Morley [:emorley]]

Done - thank you.

https://github.com/mozilla/treestatus/commit/52b24aac6f771337e46674db12f9582f7a2090e6

Comment 4

[Ed Morley [:emorley]]

Bah, in figuring out how to rebase in git, I'd missed off the main fix here of bug 823631 (s/language/type/) that I had tested locally.

Landed as:
https://github.com/mozilla/treestatus/commit/85138c89b59e6cb3c0328301e9b26e5d17430038

Comment 5

[Ed Morley [:emorley]]

In production :-)