Closed Bug 867573 Opened 7 years ago Closed 7 years ago

[B2G] Touch layer failing on 0.5.26

Categories

(Testing :: Marionette, defect, major)

Other
Gonk (Firefox OS)
defect
Not set
major

Tracking

(firefox23 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 fixed)

VERIFIED FIXED
mozilla23
Tracking Status
firefox23 --- fixed
b2g18 --- fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- fixed

People

(Reporter: zcampbell, Assigned: mdas)

References

Details

Attachments

(1 file)

Is failing since 0.5.26 release.

Typical stacktrace:


Stacktrace

Traceback (most recent call last):
  File "/var/jenkins/workspace/b2g.unagi.gaia.nightly.ui/gaiatest/tests/gallery/test_gallery_flick.py", line 40, in test_gallery_full_screen_image_flicks
    image.flick_to_next_image()
  File "/var/jenkins/workspace/b2g.unagi.gaia.nightly.ui/gaiatest/apps/gallery/regions/fullscreen_image.py", line 33, in flick_to_next_image
    self._flick_to_image('next')
  File "/var/jenkins/workspace/b2g.unagi.gaia.nightly.ui/gaiatest/apps/gallery/regions/fullscreen_image.py", line 43, in _flick_to_image
    800)  # gesture duration
  File "/var/jenkins/workspace/b2g.unagi.gaia.nightly.ui/.env/local/lib/python2.7/site-packages/marionette_client-0.5.26-py2.7.egg/marionette/marionette_touch.py", line 39, in flick
    action = Actions(self.marionette)
AttributeError: 'Marionette' object has no attribute 'marionette'
There wasn't a test against the MarionetteTouchMixin being used in gaiatest, so I've added the test and fixed the original problem.

pinch isn't being tested yet since we haven't gotten multifinger gestures working against our emulator yet.

I've tested this patch against my unagi and an emulator and it works well.

I created Bug 867600 to remove our use of sleeps in our tests when we have webdriver wait commands implemented.
Attachment #744135 - Flags: review?(dburns)
Attachment #744135 - Flags: review?(dburns) → review+
landed on mozilla-inbound without DONTBUILD, since we've added a new test:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9c106165889d

And updated pypi with the latest changes.
https://hg.mozilla.org/mozilla-central/rev/9c106165889d
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Status: RESOLVED → VERIFIED
We want this in mozilla-b2g18, right?
Keywords: checkin-needed
I think this depends on other patches landing first. This wants to bump the version to 0.5.27, but b2g18 is still on 0.5.25.
Keywords: checkin-needed
ah yes, I'll needinfo myself to take care of this
Flags: needinfo?(jgriffin)
ok, good to land on mozilla-b2g18
Flags: needinfo?(jgriffin)
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.