867573 - [B2G] Touch layer failing on 0.5.26

Status: VERIFIED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Zac C (:zac)]

Is failing since 0.5.26 release.

Typical stacktrace:


Stacktrace

Traceback (most recent call last):
  File "/var/jenkins/workspace/b2g.unagi.gaia.nightly.ui/gaiatest/tests/gallery/test_gallery_flick.py", line 40, in test_gallery_full_screen_image_flicks
    image.flick_to_next_image()
  File "/var/jenkins/workspace/b2g.unagi.gaia.nightly.ui/gaiatest/apps/gallery/regions/fullscreen_image.py", line 33, in flick_to_next_image
    self._flick_to_image('next')
  File "/var/jenkins/workspace/b2g.unagi.gaia.nightly.ui/gaiatest/apps/gallery/regions/fullscreen_image.py", line 43, in _flick_to_image
    800)  # gesture duration
  File "/var/jenkins/workspace/b2g.unagi.gaia.nightly.ui/.env/local/lib/python2.7/site-packages/marionette_client-0.5.26-py2.7.egg/marionette/marionette_touch.py", line 39, in flick
    action = Actions(self.marionette)
AttributeError: 'Marionette' object has no attribute 'marionette'

Comment 1

[Malini Das [:mdas] - Away, not checking bugmail]

Attachment: fix marionette_touch.py and add a test against this mixin

There wasn't a test against the MarionetteTouchMixin being used in gaiatest, so I've added the test and fixed the original problem.

pinch isn't being tested yet since we haven't gotten multifinger gestures working against our emulator yet.

I've tested this patch against my unagi and an emulator and it works well.

I created Bug 867600 to remove our use of sleeps in our tests when we have webdriver wait commands implemented.

Comment 2

[Malini Das [:mdas] - Away, not checking bugmail]

landed on mozilla-inbound without DONTBUILD, since we've added a new test:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9c106165889d

And updated pypi with the latest changes.

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/9c106165889d

Comment 4

[Jonathan Griffin (:jgriffin)]

We want this in mozilla-b2g18, right?

Comment 5

[Ryan VanderMeulen [:RyanVM]]

I think this depends on other patches landing first. This wants to bump the version to 0.5.27, but b2g18 is still on 0.5.25.

Comment 6

[Jonathan Griffin (:jgriffin)]

ah yes, I'll needinfo myself to take care of this

Comment 7

[Jonathan Griffin (:jgriffin)]

ok, good to land on mozilla-b2g18

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/95df5fa8fd47

Comment 9

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/b6848f2cbd2b