867603 - crash-stats using old bzapi version

Status: RESOLVED FIXED

(Socorro :: Webapp, task)

Description

[Kendall Libby [:fubar] (he/him)]

:gerv is attempting to retire BzAPI 1.1 but it appears that crash-stats is still using it rather than a newer version, e.g.:

www/crash-stats.mozilla.org/app/settings_test.py:BZAPI_BASE_URL = 'https://api-dev.bugzilla.muzilla.org/1.1'
www/crash-stats.mozilla.org/app/crashstats/settings/local.py-dist:BZAPI_BASE_URL = 'https://api-dev.bugzilla.mozilla.org/1.1'
www/crash-stats.mozilla.org/app/crashstats/settings/local.py:BZAPI_BASE_URL = 'https://api-dev.bugzilla.mozilla.org/1.1'
www/crash-stats.mozilla.org/local.py:BZAPI_BASE_URL = 'https://api-dev.bugzilla.mozilla.org/1.1'

I believe /1.3 is latest, though perhaps using /latest is the safest bet and what most of the other .m.o sites appear to be using.  I'll defer any questions on the api to :gerv, though.

Comment 1

[Gervase Markham [:gerv]]

Yes, I suggest that /latest is now pretty stable, and has been for a year or so. Version 1.3 (which is currently the same as latest) also has some fixes to work better with the new BMO which is based on Bugzilla 4.2. So you should switch to /latest.

Real Soon Now, The API will be implemented as a Bugzilla extension, and you'll have to change endpoint again.

Gerv

Comment 2

[Gervase Markham [:gerv]]

fubar/jakem: who is responsible for fixing this bug? I very much want to deactivate the BzAPI 1.1 endpoint. People might be a little upset if crash-stats died at that point. But I won't wait for ever...

Gerv

Comment 3

[Gervase Markham [:gerv]]

fubar/jakem: ping?

Gerv

Comment 4

[Kendall Libby [:fubar] (he/him)]

I'll discuss w/ jakem today and see what we can do

Comment 5

[Peter Bengtsson [:peterbe]]

We're moving from PHP to Django [0] and we're copying functionality from the soon-to-be-retired PHP site. We were hoping to make the switch sooner but had initially hoped to match the old PHP app in functionality but with new tech. This explains perhaps why we've never made the upgrade to 1.3.

I'll test it with 1.3 and hopefully we can switch to that when we switch from PHP to Django.

[0] https://github.com/mozilla/socorro-crashstats

Comment 6

[Gervase Markham [:gerv]]

peterbe: when is the planned switchover date from PHP to Django? We are already past my target deadline for deactivating BzAPI 1.1, and changing this in the existing codebase should be a one-liner. If it helps, I can provide a list of changes from 1.1 to 1.3 (it's very minor).

Gerv

Comment 7

[Peter Bengtsson [:peterbe]]

PR: https://github.com/mozilla/socorro-crashstats/pull/347

:gerv the timeline is approximately 3-5 weeks to be honest. We're 99% done but you know what it's like. 

:rhelmer, what you do think? ^ Shall we change the PHP code or just hope to replace it soon.

Comment 8

[Robert Helmer [:rhelmer]]

(In reply to Peter Bengtsson [:peterbe] from comment #7)
> PR: https://github.com/mozilla/socorro-crashstats/pull/347
> 
> :gerv the timeline is approximately 3-5 weeks to be honest. We're 99% done
> but you know what it's like. 
> 
> :rhelmer, what you do think? ^ Shall we change the PHP code or just hope to
> replace it soon.

I think we should change it too, since we'll have PHP instances hanging around for comparison/rollback for a little while at least.

I see 1.1 is being used in the default config, which is not being overridden in production AFAICT (there's no bzapi.php in /etc/socorro/web/), so all we need to do is modify it and it'll be rolled out automatically:

webapp-php/application/config/bzapi.php-dist:$config['url'] = 'https://api-dev.bugzilla.mozilla.org/1.1/';

Comment 9

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/adf5abdf03b99f07c50ad269a0d26743b0367806
bug 867603 - upgrade to bugzilla api version 1.3

https://github.com/mozilla/socorro-crashstats/commit/5ce7dd6e37de5d35792067ce6e8ebb1432395147
Merge pull request #347 from peterbe/bug867603-upgrade-to-bugzilla-api-version-13

bug 867603 - upgrade to bugzilla api version 1.3

Comment 10

[Gervase Markham [:gerv]]

How do I find out when this change will be deployed to all relevant Socorro instances?

Thanks,

Gerv

Comment 11

[Peter Bengtsson [:peterbe]]

(In reply to Gervase Markham [:gerv] from comment #10)
> How do I find out when this change will be deployed to all relevant Socorro
> instances?
> 
> Thanks,
> 
> Gerv

https://bugzilla.mozilla.org/show_bug.cgi?id=874910 :)

Actually this is just the Django part. I haven't dealt with the old PHP part yet. Followup bug to come.

Comment 12

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/a9dcd1ba6c394e1ffa4896dee9a5b963f326d26e
bug 867603 - move BZAPI_BASE_URL into settings/base.py

https://github.com/mozilla/socorro-crashstats/commit/4afdc152bbf92cf751a46a577752005fa1ee0b48
Merge pull request #348 from peterbe/bug867603-move-bzapi_base_url-into-settingsbasepy

bug 867603 - move BZAPI_BASE_URL into settings/base.py

Comment 13

[Peter Bengtsson [:peterbe]]

Fixed on the PHP side here:
https://github.com/mozilla/socorro/commit/537241e0b5f60e4488c1c1d1547b96156342c111

Lonnen will update this bug once he's done a release (estimated time: tomorrow)

Comment 14

[Robert Kaiser]

(In reply to Peter Bengtsson [:peterbe] from comment #13)
> Lonnen will update this bug once he's done a release (estimated time:
> tomorrow)

That "tomorrow" was 2 weeks ago, forgot to update this bug?

Comment 15

[Gervase Markham [:gerv]]

peterbe: ping?

It looks from checking the logs like this hasn't been fixed :-(( (See bug 858478 for stats.)

Gerv

Comment 16

[Robert Helmer [:rhelmer]]

(In reply to Gervase Markham [:gerv] from comment #15)
> peterbe: ping?
> 
> It looks from checking the logs like this hasn't been fixed :-(( (See bug
> 858478 for stats.)
> 
> Gerv

Hmm I don't see crash-stats in bug 858478 comment 12, am I missing it?

It looks like all the crash-stat apps running right now (old PHP and new Django) are configured to use the 1.3 bzapi URL.

Comment 17

[Gervase Markham [:gerv]]

rhelmer: bug 858478 comment 12 lists the same top sites as bug 858478 comment 0, which :fubar seems to identify with crash-stats in bug 858478 comment 11.

However, that may not be right - I will comment and check.

Gerv

Comment 18

[Robert Helmer [:rhelmer]]

(In reply to Gervase Markham [:gerv] from comment #17)
> rhelmer: bug 858478 comment 12 lists the same top sites as bug 858478
> comment 0, which :fubar seems to identify with crash-stats in bug 858478
> comment 11.
> 
> However, that may not be right - I will comment and check.
> 
> Gerv

OK I will see what reverse lookup returns for our web heads also

Comment 19

[Kendall Libby [:fubar] (he/him)]

crash-stats is one of the websites on webheads81.phx.mozilla.com (it's a webapp cluster). I don't recall finding any other sites there using bzapi when I looked.

Comment 20

[Peter Bengtsson [:peterbe]]

This just has to be fixed now. There's no more PHP spinning and the Django code is using 1.3. 
#springcleaning