Closed Bug 867737 Opened 11 years ago Closed 11 years ago

Update FHR reporting URL

Categories

(Firefox Health Report Graveyard :: Client: Desktop, defect)

x86_64
Windows 8
defect
Not set
normal

Tracking

(firefox21+ verified, firefox22+ verified)

RESOLVED FIXED
Tracking Status
firefox21 + verified
firefox22 + verified

People

(Reporter: mconnor, Assigned: mconnor)

References

Details

Attachments

(1 file)

datareporting.healthreport.documentServerURI

Patch coming shortly, pending server ops changes in bug 867718

Effectively, this allows us to distinguish or redirect traffic based on DNS/host headers.  It may not be necessary, but it's something we should consider for uplift to give us another knob, if needed.
Attached patch v1Splinter Review
Attachment #744256 - Flags: review?(gps)
Comment on attachment 744256 [details] [diff] [review]
v1

Review of attachment 744256 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me.

Has there been any thought to deploying separate URIs for client type, possibly even distinguishing by channel and/or version? Ops/server people typically like these things because it more easily allows filtering of a misbehaving client class.
Attachment #744256 - Flags: review?(gps) → review+
I think that's likely covered by bug 850491, I suspect CNAMEs would be overkill for all of those combinations.
https://hg.mozilla.org/mozilla-central/rev/b47de8314e7f
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment on attachment 744256 [details] [diff] [review]
v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): very low risk, just a CNAME
String or IDL/UUID changes made by this patch: none.

Discussed with bajaj at FHR meeting.  This is a safety valve to ensure we can filter FHR traffic away from the current infrastructure if there are problems.
Attachment #744256 - Flags: approval-mozilla-beta?
Attachment #744256 - Flags: approval-mozilla-aurora?
Comment on attachment 744256 [details] [diff] [review]
v1

Looks good to land.Please let ashughes know if there is any specific testing needed here.
Attachment #744256 - Flags: approval-mozilla-beta?
Attachment #744256 - Flags: approval-mozilla-beta+
Attachment #744256 - Flags: approval-mozilla-aurora?
Attachment #744256 - Flags: approval-mozilla-aurora+
Keywords: verifyme
QA Contact: anthony.s.hughes
Mozilla/5.0 (Windows NT 6.2; WOW64; rv:21.0) Gecko/20100101 Firefox/21.0
Build ID: 20130506154904

Verified as fixed on Firefox 21 beta 7 - data submission still works (there are still a couple of exception like Bug 865672 and Bug 869456 but those did not regress after this patch landed).

Marking the tracking flag for Firefox 21 to verified.
Verified as fixed on Firefox 22 beta 6:

Mozilla/5.0 (Windows NT 6.2; WOW64; rv:22.0) Gecko/20100101 Firefox/22.0
Build ID: 20130617145905
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: