Closed
Bug 867737
Opened 11 years ago
Closed 11 years ago
Update FHR reporting URL
Categories
(Firefox Health Report Graveyard :: Client: Desktop, defect)
Tracking
(firefox21+ verified, firefox22+ verified)
People
(Reporter: mconnor, Assigned: mconnor)
References
Details
Attachments
(1 file)
1.41 KB,
patch
|
gps
:
review+
bajaj
:
approval-mozilla-aurora+
bajaj
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
datareporting.healthreport.documentServerURI Patch coming shortly, pending server ops changes in bug 867718 Effectively, this allows us to distinguish or redirect traffic based on DNS/host headers. It may not be necessary, but it's something we should consider for uplift to give us another knob, if needed.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #744256 -
Flags: review?(gps)
Comment 2•11 years ago
|
||
Comment on attachment 744256 [details] [diff] [review] v1 Review of attachment 744256 [details] [diff] [review]: ----------------------------------------------------------------- rs=me. Has there been any thought to deploying separate URIs for client type, possibly even distinguishing by channel and/or version? Ops/server people typically like these things because it more easily allows filtering of a misbehaving client class.
Attachment #744256 -
Flags: review?(gps) → review+
Assignee | ||
Comment 3•11 years ago
|
||
I think that's likely covered by bug 850491, I suspect CNAMEs would be overkill for all of those combinations.
Updated•11 years ago
|
status-firefox21:
--- → affected
status-firefox22:
--- → affected
Assignee | ||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b47de8314e7f
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•11 years ago
|
||
Comment on attachment 744256 [details] [diff] [review] v1 [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: Testing completed (on m-c, etc.): Risk to taking this patch (and alternatives if risky): very low risk, just a CNAME String or IDL/UUID changes made by this patch: none. Discussed with bajaj at FHR meeting. This is a safety valve to ensure we can filter FHR traffic away from the current infrastructure if there are problems.
Attachment #744256 -
Flags: approval-mozilla-beta?
Attachment #744256 -
Flags: approval-mozilla-aurora?
Comment 6•11 years ago
|
||
Comment on attachment 744256 [details] [diff] [review] v1 Looks good to land.Please let ashughes know if there is any specific testing needed here.
Attachment #744256 -
Flags: approval-mozilla-beta?
Attachment #744256 -
Flags: approval-mozilla-beta+
Attachment #744256 -
Flags: approval-mozilla-aurora?
Attachment #744256 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 7•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/d98584bb5fe9 https://hg.mozilla.org/releases/mozilla-beta/rev/af0d3c0a39ef Nothing special, just please verify that submission still works. https://wiki.mozilla.org/QA/Desktop_Firefox/Firefox_Health_Report#Interfacing_with_FHR has details. I have manually verified that the new host works correct.
Comment 8•11 years ago
|
||
Mozilla/5.0 (Windows NT 6.2; WOW64; rv:21.0) Gecko/20100101 Firefox/21.0 Build ID: 20130506154904 Verified as fixed on Firefox 21 beta 7 - data submission still works (there are still a couple of exception like Bug 865672 and Bug 869456 but those did not regress after this patch landed). Marking the tracking flag for Firefox 21 to verified.
Comment 9•11 years ago
|
||
Verified as fixed on Firefox 22 beta 6: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:22.0) Gecko/20100101 Firefox/22.0 Build ID: 20130617145905
Keywords: verifyme
Updated•6 years ago
|
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•