865672 - Number of bookmarks doesn't update in about:healthreport

Status: RESOLVED WORKSFORME

(Firefox Health Report Graveyard :: Client: Desktop, defect)

Description

[Manuela Muntean [Away]]

Steps to Reproduce:

1. Launch Firefox, open about:healthreport, and set "Data Sharing" to be OFF
2. Observe the number of bookmarks, under the "Vital Stats" section
3. Open a link in a new tab and bookmark it
4. Reload the about:healthreport tab

Expected results:

The number of bookmarks, under the "Vital Stats" section, should be increased by one, after step 4

Actual results:

The number of bookmarks, under the "Vital Stats" section, isn't increased by one, after step 4 (not even after a browser restart, and not even if "Data Sharing" is set back ON)

Reproducible with the latest Beta - build ID: 20130423212553
Reproducible with the latest Aurora - build ID: 20130424004015
Reproducible with the latest Nightly - build ID: 20130425030845

Comment 1

[Manuela Muntean [Away]]

Note:

Typing "about:healthreport" in Firefox 4 gives an alert: "The URL is not valid and cannot be loaded". Details regarding the fact that this issue is or isn't a regression will be given as soon as possible.

Comment 2

[Mike Connor [:mconnor]]

on comment 1, that is not a regression, and requires no followup work.  Any new about: page will yield that error in older versions.

Comment 3

[u279076]

My assessment of this issue is that this is not a Firefox 21 V1 blocker. Though if reasonable I'd like to see it fixed for Firefox 22. Mike, do you agree?

Comment 4

[Mike Connor [:mconnor]]

I don't think it's something we should prioritize that high, it's pretty late in the game to uplift to 22, and it's a pretty minor issue from my perspective.  I think this might even be a dupe, on the subject of some data not updating on every refresh, which is by design.

Comment 5

[u279076]

Fair enough, thank you Mike.

Comment 6

[Gregory Szorc [:gps]]

I reckon this was fixed in bug 861455 and is thus fixed with the most recent beta.

Comment 7

[Gregory Szorc [:gps]]

Comment #6 is not accurate.

Comment 8

[Gregory Szorc [:gps]]

The behavior is expected as things are currently implemented.

There are pieces of data that we collect at most once per day (for performance reasons). The counts from Places are one such piece of data.

Once you've collected this "daily" data, it won't collect again until the next application session or until 24 hours has passed.

I see our options as WONTFIX or adding a mode to force recollection and having about:healthreport invoke that mode.

Comment 9

[Stebs]

(In reply to Gregory Szorc [:gps] (on holiday until June 10) from comment #8)
> The behavior is expected as things are currently implemented.

> Once you've collected this "daily" data, it won't collect again until the
> next application session or until 24 hours has passed.

It seems the number of Bookmarks is never ever updated, for me it shows the number of Bookmarks (3149) I had on 2013-02-10 (as raw data showed), instead of (2884) currently 2013-06-07.
So this Number can be quite misleading...

Comment 10

[Gregory Szorc [:gps]]

To confirm, the counts in the raw data are good but the value in the sidebar is not from the most recent day? If so, this should be reassigned to the "Web: Health Report" component.

Comment 11

[Stebs]

Attachment: My raw data as text file

Comment 12

[Stebs]

(In reply to Gregory Szorc [:gps] from comment #10)
> To confirm, the counts in the raw data are good but the value in the sidebar
> is not from the most recent day?
Exactly, the sidebar says "bookmarks 3149" since ages, when searching in the raw data for 3149, that value seems to be from "2013-02-10", but the actual correct number of bookmarks are also found in raw data. (raw data as file in previous comment)

Comment 14

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I'm still seeing this in latest Nightly

-from Nightly Health Report:
bookmarks 53156

-from Nightly Health Report:
        "org.mozilla.places.places": {
          "_v": 1,
          "bookmarks": 53634,
          "pages": 85653
        },

-from Places Maintenance 1.3

> Integrity check
+ The database is sane
> Reindex
+ The database has been reindexed
> Orphans expiration
+ Database cleaned up
> Coherence check
+ The database is coherent
> Vacuum
Initial database size is 61440 KiB
+ The database has been vacuumed
Final database size is 61440 KiB
> Statistics
Database size is 61440 KiB
user_version is 24
page_size is 32768
cache_size is -2048
journal_mode is wal
synchronous is 1
History can store a maximum of 104858 unique pages
Table moz_places has 85666 records
Table moz_historyvisits has 61358 records
Table moz_inputhistory has 0 records
Table moz_hosts has 4099 records
Table moz_bookmarks has 53760 records
Table moz_bookmarks_roots has 5 records
Table moz_keywords has 0 records
Table sqlite_sequence has 0 records
Table moz_favicons has 3266 records
Table moz_anno_attributes has 9 records
Table moz_annos has 42880 records
Table moz_items_annos has 31040 records
Table sqlite_stat1 has 14 records
Index sqlite_autoindex_moz_inputhistory_1
Index sqlite_autoindex_moz_hosts_1
Index sqlite_autoindex_moz_bookmarks_roots_1
Index sqlite_autoindex_moz_keywords_1
Index sqlite_autoindex_moz_favicons_1
Index sqlite_autoindex_moz_anno_attributes_1
Index moz_places_faviconindex
Index moz_places_hostindex
Index moz_places_visitcount
Index moz_places_frecencyindex
Index moz_places_lastvisitdateindex
Index moz_historyvisits_placedateindex
Index moz_historyvisits_fromindex
Index moz_historyvisits_dateindex
Index moz_bookmarks_itemindex
Index moz_bookmarks_parentindex
Index moz_bookmarks_itemlastmodifiedindex
Index moz_places_url_uniqueindex
Index moz_places_guid_uniqueindex
Index moz_bookmarks_guid_uniqueindex
Index moz_annos_placeattributeindex
Index moz_items_annos_itemattributeindex

Comment 15

[Georg Fritzsche [:gfritzsche]]

Per bug 1180673 et al, bookmark counts are not shown in about:healthreport anymore.