867747 - Implement OAuth 2 success paths for Google Calendar

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[James Lal [:lightsofapollo]]

- show user google oauth2 flow
- expose API to CalDav lib to authenticate over oauth2
- get users email address so we can show some meaningful context to accounts
- handle basic CalDAV flows over oauth

Comment 1

[James Lal [:lightsofapollo]]

Should be tef? breaking up big metabug

Comment 2

[James Lal [:lightsofapollo]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9500#attch-to-bugzilla

Pointer to Github pull-request

Comment 3

[James Lal [:lightsofapollo]]

Comment on attachment 744442 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9500#attch-to-bugzilla

Hey Kevin, official review request... Please don't land this until we finish the CalDAV review. I think everything is working but there are some documentation changes/any review comments you might have that we need to address there prior to landing this.

Comment 4

[James Lal [:lightsofapollo]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/caldav/pull/14

Pointer to Github pull-request

Comment 5

[James Lal [:lightsofapollo]]

Comment on attachment 744451 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/caldav/pull/14

Official pointer to CalDAV R? request

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 744451 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/caldav/pull/14

Gaia side still needs some work, but I think CalDav is pretty solid.

Comment 7

[Kevin Grandon :kgrandon]

Comment on attachment 744442 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9500#attch-to-bugzilla

The code looks good, and the actual oauth process works. I'd say that we can call part 1 done.

Comment 8

[James Lal [:lightsofapollo]]

in master: https://github.com/mozilla-b2g/gaia/commit/edb800dc06c91312c0370eeb82a993a7bd28df2f

NO_UPLIFT for now - we want to stabilize this in master only first.

Comment 9

[[e-mail]]

Just merged the latest gaia-master today and found the google calendar can't be deleted.

1. Click Calendar Settings
2. tap google account in Accounts column

The page will always redirect to google oauth page, thus the account can't be deleted

Comment 10

[Kevin Grandon :kgrandon]

Hi Fred - We're currently tracking that issue in bug 868197. It is unfortunate that it would affect other bug verification. Hopefully we can have this fixed in a few days.

Comment 11

[[e-mail]]

Kevin, thanks for clarify.
Nice to know that issue is already monitored.

Comment 12

[Jason Smith [:jsmith]]

Rough experience overall on master. Notes on testing below.

Good

* I saw oauth UI come up upon selecting google in add account UI
* I was able to login with two of my valid accounts

Needs Work

* The transition to loading remote content from google feels a tad awkward
* Pressing the back and forward button from oauth google UI flashes an unrelated username and password UI before showing the oauth UI
* The oauth integration in general with remote google content needs to know when to go out the browser better - right now, you can surf the web pretty easily within the calendar web content window
* Upon logging in with an existing google account with a google calendar, I got a message saying "testing oauth" is requesting permission. Shouldn't "testing oauth" have a different name?
* Hitting "No Thanks" during the permission request on google takes you to an unrelated username and password UI
* Failed to authenticate with personal gmail account - got "Something is wrong. Try again."
* Upon completing a login with a valid gmail, I got stuck in the permission request UI and could not login with a different gmail

Other Notes

* Network activity icon might be broken on master
* The permission site is a desktop site

Comment 13

[Jason Smith [:jsmith]]

A couple of additional testing notes after talking in IRC:

* I successfully logged into a google account and synced when I did not hit No Thanks during part of the UX flow
* No delete account UI for google calendar yet (I think there's a separate bug already tracking this)
* Trying to add a second google account after a first one was successfully added puts you back at the allow permission UI, not the google login UI. Work around requires a logout from that account in UI.
* [Master only] Can't scroll month agenda view, week view, or day view events at all

Comment 14

[James Lal [:lightsofapollo]]

in v1.0.1: https://github.com/mozilla-b2g/gaia/commit/83d8cb77c37393d0f350c9c81f21cc9d5ac51fc2

Comment 15

[James Lal [:lightsofapollo]]

in v1-train: 5bdaac5ac90bfea258df7679ae40ebe0d984724b

Comment 16

[Jason Smith [:jsmith]]

Marking verified to indicate that there has been an informal test pass done on this feature. Note that there's more testing to be done here in a more formal analysis, but I'm marking verified to indicate that this has been looked at.