Implement OAuth 2 success paths for Google Calendar

RESOLVED FIXED in 1.0.1 IOT1 (10may)

Status

Firefox OS
Gaia::Calendar
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: lightsofapollo, Unassigned)

Tracking

unspecified
1.0.1 IOT1 (10may)

Firefox Tracking Flags

(blocking-b2g:tef+, b2g18 verified, b2g18-v1.0.1 verified)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
- show user google oauth2 flow
- expose API to CalDav lib to authenticate over oauth2
- get users email address so we can show some meaningful context to accounts
- handle basic CalDAV flows over oauth
(Reporter)

Comment 1

5 years ago
Should be tef? breaking up big metabug
blocking-b2g: --- → tef?
(Reporter)

Updated

5 years ago
Blocks: 855334
(Reporter)

Comment 2

5 years ago
Created attachment 744442 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9500#attch-to-bugzilla

Pointer to Github pull-request
(Reporter)

Comment 3

5 years ago
Comment on attachment 744442 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9500#attch-to-bugzilla

Hey Kevin, official review request... Please don't land this until we finish the CalDAV review. I think everything is working but there are some documentation changes/any review comments you might have that we need to address there prior to landing this.
Attachment #744442 - Flags: review?(kgrandon)
(Reporter)

Comment 4

5 years ago
Created attachment 744451 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/caldav/pull/14

Pointer to Github pull-request
(Reporter)

Comment 5

5 years ago
Comment on attachment 744451 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/caldav/pull/14

Official pointer to CalDAV R? request
Attachment #744451 - Flags: review?(kgrandon)
Comment on attachment 744451 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/caldav/pull/14

Gaia side still needs some work, but I think CalDav is pretty solid.
Attachment #744451 - Flags: review?(kgrandon) → review+
Comment on attachment 744442 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9500#attch-to-bugzilla

The code looks good, and the actual oauth process works. I'd say that we can call part 1 done.
Attachment #744442 - Flags: review?(kgrandon) → review+
(Reporter)

Updated

5 years ago
Whiteboard: [NO_UPLIFT]
(Reporter)

Comment 8

5 years ago
in master: https://github.com/mozilla-b2g/gaia/commit/edb800dc06c91312c0370eeb82a993a7bd28df2f

NO_UPLIFT for now - we want to stabilize this in master only first.
(Reporter)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 9

5 years ago
Just merged the latest gaia-master today and found the google calendar can't be deleted.

1. Click Calendar Settings
2. tap google account in Accounts column

The page will always redirect to google oauth page, thus the account can't be deleted
Flags: needinfo?(jlal)
Hi Fred - We're currently tracking that issue in bug 868197. It is unfortunate that it would affect other bug verification. Hopefully we can have this fixed in a few days.

Comment 11

5 years ago
Kevin, thanks for clarify.
Nice to know that issue is already monitored.
Flags: needinfo?(jlal)

Updated

5 years ago
Keywords: verifyme
QA Contact: jsmith

Updated

5 years ago
Flags: in-moztrap?(jsmith)
Rough experience overall on master. Notes on testing below.

Good

* I saw oauth UI come up upon selecting google in add account UI
* I was able to login with two of my valid accounts

Needs Work

* The transition to loading remote content from google feels a tad awkward
* Pressing the back and forward button from oauth google UI flashes an unrelated username and password UI before showing the oauth UI
* The oauth integration in general with remote google content needs to know when to go out the browser better - right now, you can surf the web pretty easily within the calendar web content window
* Upon logging in with an existing google account with a google calendar, I got a message saying "testing oauth" is requesting permission. Shouldn't "testing oauth" have a different name?
* Hitting "No Thanks" during the permission request on google takes you to an unrelated username and password UI
* Failed to authenticate with personal gmail account - got "Something is wrong. Try again."
* Upon completing a login with a valid gmail, I got stuck in the permission request UI and could not login with a different gmail

Other Notes

* Network activity icon might be broken on master
* The permission site is a desktop site
Keywords: verifyme
A couple of additional testing notes after talking in IRC:

* I successfully logged into a google account and synced when I did not hit No Thanks during part of the UX flow
* No delete account UI for google calendar yet (I think there's a separate bug already tracking this)
* Trying to add a second google account after a first one was successfully added puts you back at the allow permission UI, not the google login UI. Work around requires a logout from that account in UI.
* [Master only] Can't scroll month agenda view, week view, or day view events at all

Updated

5 years ago
Flags: in-moztrap?(jsmith)

Updated

5 years ago
blocking-b2g: tef? → tef+
Target Milestone: --- → 1.0.1 IOT1 (10may)
(Reporter)

Comment 14

5 years ago
in v1.0.1: https://github.com/mozilla-b2g/gaia/commit/83d8cb77c37393d0f350c9c81f21cc9d5ac51fc2
status-b2g18-v1.0.1: --- → fixed

Updated

5 years ago
Keywords: verifyme
Whiteboard: [NO_UPLIFT]
(Reporter)

Comment 15

5 years ago
in v1-train: 5bdaac5ac90bfea258df7679ae40ebe0d984724b
status-b2g18: --- → fixed
Marking verified to indicate that there has been an informal test pass done on this feature. Note that there's more testing to be done here in a more formal analysis, but I'm marking verified to indicate that this has been looked at.
status-b2g18: fixed → verified
status-b2g18-v1.0.1: fixed → verified
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.