868197 - [Calendar] Implement oauth account delete flow

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Kevin Grandon :kgrandon]

Bug 867747 implements an oauth account creation flow. As a side effect, any time I try to visit the account in settings, I'm brought to the oauth login page. We should probably have some page that allows you to delete or edit the credentials of the account.

Email has a similar landing page, so I'd imagine we should follow what they do. Behold my absolutely stunning wireframes:


<| Account
-----------------------
Credentials > 
Delete Account


<| Credentials   | Save
-----------------------
E-mail Address
Password

Comment 1

[James Lal [:lightsofapollo]]

UX specs seen here: https://bug855334.bugzilla.mozilla.org/attachment.cgi?id=746641

The UI here is basically page 9 #5 if view from FireFox nightly.
--

Right now we implement OAuth2 flow with a series of hacks to the existing ModifyAccount view... Its making more an more sense to break the page out into two modules that each handle flows and update the given model (rather then my suspect if ouath do stuff logic).

Comment 2

[Kevin Grandon :kgrandon]

Attachment: Github pull request pointer

Opted for the fewest changes possible to support this due to our constrained timeline. Should the UI need additional updates later, we might opt to refactor this a bit. Ready for an initial review.

Comment 3

[James Lal [:lightsofapollo]]

Comment on attachment 747600 [details]
Github pull request pointer

r+ with my patch applied and review of my small changes to your patch :)

Comment 4

[James Lal [:lightsofapollo]]

in master: https://github.com/mozilla-b2g/gaia/commit/f2b4bdaf6c2ad62e3aa67027c33ce8543ed0d343

Comment 5

[James Lal [:lightsofapollo]]

in v1.0.1: https://github.com/mozilla-b2g/gaia/commit/927730de245f3c95318c9b7f5e5eab67e781ff6d

Comment 6

[James Lal [:lightsofapollo]]

v1-train: fc3bfb1acf8728bdb7619d9219dff89d08323303

Comment 7

[Jason Smith [:jsmith]]

Marking verified to indicate that there has been an informal test pass done on this feature. Note that there's more testing to be done here in a more formal analysis, but I'm marking verified to indicate that this has been looked at.