867770 - Always layerize animated images

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Joe Drew (not getting mail)]

Robert O'Callahan (:roc) (Mozilla Corporation) from bug 717872 comment #7:
> We'll want to layerize all animated images. That means modifying
> nsDisplayImage::GetLayerState and nsDisplayBackgroundImage::GetLayerState to
> choose the ACTIVE state for animated images. (Maybe give up if we have to
> tile a CSS background image.) Then it's just a matter of making imglib call
> SetCurrentImage on the mozilla::layers::ImageContainer at the right times
> --- ImageContainer is a thread-safe object and SetCurrentImage can be called
> from any thread.

Comment 1

[Joe Drew (not getting mail)]

Attachment: wip

This works for layerizing just a single animated image, displayed not on a page. Doesn't currently layerize about:home with whimsy installed for reasons that I haven't explored yet.

Comment 2

[Joe Drew (not getting mail)]

Attachment: layerize animated images when possible

This works for at least some subset of background images and regular <img> elements; we fall back to the regular Thebes layer rendering both when animated images are loading and in cases where we explicitly don't allow it, which is currently the case for about:home (sadly).

https://tbpl.mozilla.org/?tree=Try&rev=5229887b24c4

Comment 3

[Joe Drew (not getting mail)]

A try, rebased on bug 869133: https://tbpl.mozilla.org/?tree=Try&rev=b3b2316f410b

Comment 4

[Joe Drew (not getting mail)]

Attachment: add pref

As requested by Jeff during the rendering work week, this adds a pref for this behaviour.

Comment 5

[Joe Drew (not getting mail)]

Attachment: test

This tests to make sure we layerize these animated images.

Comment 6

[Joe Drew (not getting mail)]

https://tbpl.mozilla.org/?tree=Try&rev=a023fee34ca9

Comment 7

[Joe Drew (not getting mail)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/7de5f90c9371
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/b169949f2e80
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/46ffad1e32fc

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7de5f90c9371
https://hg.mozilla.org/mozilla-central/rev/b169949f2e80
https://hg.mozilla.org/mozilla-central/rev/46ffad1e32fc