bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Make Account Manager Offline Preference Lockable

VERIFIED FIXED in mozilla1.2alpha

Status

SeaMonkey
MailNews: Account Configuration
P2
normal
VERIFIED FIXED
17 years ago
14 years ago

People

(Reporter: Diane Sun, Assigned: racham)

Tracking

(Blocks: 1 bug)

Trunk
mozilla1.2alpha
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: Request R&SR)

Attachments

(1 attachment)

(Reporter)

Description

17 years ago
This is based on bug 82805 which autually locks the offline preference through 
xpcom  js approach for  User Prefs 
"mail.server.server1.offline_download"
"mail.server.server1.download_bodies_on_get_new_mail"


Bug 79305 will provide generic approach to make all preferenc lockable through 
adding  prefstring,  severkey, identitykey.
After  79305 ( eddyk) being checked in,  we need to add the prefstrings for the 
above preference  to am-offline.xul,   see attachement  38993 in bug 82805
(Reporter)

Updated

17 years ago
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → mozilla0.9.3
(Reporter)

Comment 1

17 years ago
Created attachment 39623 [details] [diff] [review]
Fix in xul file
(Reporter)

Updated

17 years ago
Whiteboard: Request R&SR

Comment 2

17 years ago
I'd like to request a change; at line 109, you have three pref attributes, but
no prefstring. It should be an all or nothing use.

Can that be fixed in this bug as well?

Comment 3

17 years ago
my area...QA over to me.
QA Contact: nbaca → rvelasco
Summary: Make Account Manager Offline Preference Locable → Make Account Manager Offline Preference Lockable
(Reporter)

Comment 4

17 years ago
Eddy, your question will be fixed in another bug Disk Space bug 85335.
(Reporter)

Comment 5

17 years ago
Request  R & SR,  Eddy,  Bhuvan,  Seth?
(Assignee)

Comment 6

17 years ago
looks right. r=bhuvan.

Please run test scenarios with prefs locked. It possible you may come across
bugs like 86911 (bug 86911), which will be important to know to ensure the
correctness of locking feature.

Comment 7

17 years ago
Reassigning.
Assignee: dianesun → eddyk
Status: ASSIGNED → NEW

Updated

17 years ago
Target Milestone: mozilla0.9.3 → mozilla0.9.4

Comment 8

17 years ago
set milestone to 0.9.4

Updated

17 years ago
Blocks: 70538
eddyk, do you still need a review on that last patch?

Comment 10

17 years ago
I'm moving TFV to future and putting a dependancy on bug 79305.

I'm doing this because the offline/disk panel elements are populated and saved
via am-offline.js  and not AccountManager.js.  Adding the xul attributes in the
patch would involve the code in AccountManager and seems a bit dangerous at this
point at worst and redundant at best.

Once 79305 is implemented, I'll have to come back and resolve any conflicts
between the differing methods.  From my point of view, it seems possible that
most or all of the code in am-offline.js would need to be dropped once 79305 is
done.

Depends on: 79305
Target Milestone: mozilla0.9.4 → Future

Comment 11

17 years ago
Hi, Putterman:

Any chance we get this one in by 0.9.9?

Steven, Jeff - would you provide some inputs on this? Private email will do, too.

thx
Assignee: eddyk → putterman
Keywords: nsbeta1

Updated

17 years ago
Target Milestone: Future → ---

Comment 12

17 years ago
reassigning to racham.  I've marked the bug it's dependent on as 1.2. How
immportant are these sets of bugs and is there anyone on your team that can help
out, Tao?
Assignee: putterman → racham
Keywords: nsbeta1 → nsbeta1+

Comment 13

17 years ago
Moving to 1.0, but it's likely these will be moved out further.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.0

Updated

17 years ago
Keywords: nsbeta1+ → nsbeta1-
Target Milestone: mozilla1.0 → mozilla1.2

Comment 14

16 years ago
this bug is fixed due to bug 144563.  fixed on the trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 15

16 years ago
verified on trunk...see bug 144563 for more details
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.