867818 - [HiDPI] Download confirmation icon is disproportionately large

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Greg Edwards]

Attachment: Download confirmation at 96dpi

Just like Bug 818935 and Bug 865746, only with the download confirmation dialog. Should be familiar by now.

Comment 1

[Greg Edwards]

Attachment: Download confirmation at 192dpi

It took me longer to notice this one since 32 CSS pixels is wrong here but correct for the other mis-sized icons.

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: ensure Download confirmation icon is the correct size on win/hidpi systems.

Ah, another one of these. This time we want to keep the icon at 16px. (Thanks for patiently tracking these down, Greg.)

Comment 3

[Greg Edwards]

Thanks so much, Jonathan, for working on all these hiDPI issues. I sincerely appreciate all the hard work.

Comment 4

[Justin Dolske [:Dolske]]

Comment on attachment 744517 [details] [diff] [review]
ensure Download confirmation icon is the correct size on win/hidpi systems.

Review of attachment 744517 [details] [diff] [review]:
-----------------------------------------------------------------

What is this I'm feeling? If you want to land I'm wit' it (aaa-aah)... :D

Comment 5

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6926446e12f5

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6926446e12f5

Comment 7

[Jonathan Kew [:jfkthame]]

Comment on attachment 744517 [details] [diff] [review]
ensure Download confirmation icon is the correct size on win/hidpi systems.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): windows hi-dpi support

User impact if declined: minor cosmetic glitch (icon too large)

Testing completed (on m-c, etc.): currently in Nightly and Aurora

Risk to taking this patch (and alternatives if risky): minimal, just a styling fix

String or IDL/UUID changes made by this patch: none

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f7091da82541

Comment 9

[Tracy Walker [:tracy]]

mass remove verifyme requests greater than 4 months old