Closed Bug 867843 Opened 12 years ago Closed 12 years ago

Screenshot navigation is truly, truly messed up

Categories

(Marketplace Graveyard :: Consumer Pages, defect, P3)

Product:
Marketplace Graveyard
Component:
Consumer Pages
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
2013-05-02

People

(Reporter: cvan, Assigned: basta)

References

(
URL
)

Details

(Whiteboard: [fireplace])

https://marketplace-altdev.allizom.org/app/lordofultima Click a screenshot. Go to the first screenshot: (1) Why's there a left arrow? Why are there *two* left arrows? http://f.cl.ly/items/060T33421E0v45250d35/Screen%20Shot%202013-05-01%20at%206.05.03%20PM.png Click the right arrow. Click the left arrow. It keeps jumping you around. I don't understand this at all.
Looks like a potential rendering glitch? It appears fine for me. The handle is transitioned. What browser are you using? Try in Aurora or Beta and see if it's a problem there. It could also be that somewhere down the line, the shot handles are getting initialized twice.
Happens in Chrome and Firefox for me. 1. Go to http://localhost:8675/search with the graphical view enabled. 2. Click on an app's screenshot. Navigate back and forth that app's screenshots. 3. Click on another app's screenshot. Navigate back and forth. You should now notice a double arrow (literally an arrow on top of another) on the right side. 4. Keep clicking right. It apparently goes on for a while, showing empty panes. Then click the left arrow a few times. 5. Wonkiness ensues.
I can't repro this on chrome 26.0.1410.65 or FF 21.0
(In reply to Stuart Colville [:scolville] from comment #3) > I can't repro this on chrome 26.0.1410.65 or FF 21.0 You must open at least two carousels that contain more than one screenshots. Can you reproduce then? Reproduced in Chrome Version 26.0.1410.65 and Firefox Nightly 23.0a1 (2013-05-01).
Krupa said she could reproduce it. So it's a bug :)
Looks like it's happening because we have no safeguards on shothandles.js. Adding some now.
https://github.com/mozilla/fireplace/commit/4903f387ee8a3 Speculative fix. I'm 90% sure that the handles are just being double-initialized, which is causing all sorts of "wonk". This removes old handles before creating new ones. Not the best fix, but it's idempotent and who doesn't like computer science jargon.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee: nobody → mattbasta
Target Milestone: --- → 2013-05-02
Verified as fixed in https://marketplace-dev.allizom.org/ on FF24 (Win 7). Postfix screencast http://screencast.com/t/ULqTwKQt3 Closing bug.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.