867914 - Minor nit in extern declaration of asm function

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P5)

Description

[Martin Husemann]

Attachment: Change extern declaration of shared stub function

The attached patch fixes a compiler issue for me on NetBSD/sparc64 when using the same code as OpenBSD.
The function is implemented in assembler and at the ABI level there is no change.

Comment 1

[Landry Breuil (:gaston)]

I'll be travelling in the coming days, but i'll make sure to look into this (and bug 867911 too) when possible - at least before end of month.

Comment 2

[Landry Breuil (:gaston)]

Comment on attachment 744495 [details] [diff] [review]
Change extern declaration of shared stub function

Review of attachment 744495 [details] [diff] [review]:
-----------------------------------------------------------------

This doesnt seem to break things when backported to firefox 3.6 on sparc64 - just for the sake of completeness, what was the build error on NetBSD ?

Will push it soon.

Comment 3

[Landry Breuil (:gaston)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d296fcc8f3dd

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/d296fcc8f3dd

Comment 5

[Martin Husemann]

For completeness: the error messages were (dozens of all alike):

../../../../../../dist/include/xptcstubsdef.inc: In member function 'virtual nsresult nsXPTCStubBase::Stub3()':
../../../../../../dist/include/xptcstubsdef.inc:1:1: error: cannot convert 'int' to 'nsresult' in return

(this is with gcc 4.5.4)