Minor nit in extern declaration of asm function

RESOLVED FIXED in mozilla24

Status

()

Core
XPCOM
P5
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Martin Husemann, Assigned: Martin Husemann)

Tracking

Trunk
mozilla24
Sun
NetBSD
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Created attachment 744495 [details] [diff] [review]
Change extern declaration of shared stub function

The attached patch fixes a compiler issue for me on NetBSD/sparc64 when using the same code as OpenBSD.
The function is implemented in assembler and at the ABI level there is no change.
(Assignee)

Updated

4 years ago
Attachment #744495 - Attachment is patch: true
Attachment #744495 - Attachment mime type: text/x-patch → text/plain
Attachment #744495 - Flags: review?(landry)
Priority: -- → P5
I'll be travelling in the coming days, but i'll make sure to look into this (and bug 867911 too) when possible - at least before end of month.
Comment on attachment 744495 [details] [diff] [review]
Change extern declaration of shared stub function

Review of attachment 744495 [details] [diff] [review]:
-----------------------------------------------------------------

This doesnt seem to break things when backported to firefox 3.6 on sparc64 - just for the sake of completeness, what was the build error on NetBSD ?

Will push it soon.
Attachment #744495 - Flags: review?(landry) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/d296fcc8f3dd
https://hg.mozilla.org/mozilla-central/rev/d296fcc8f3dd
Assignee: nobody → martin
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
(Assignee)

Comment 5

4 years ago
For completeness: the error messages were (dozens of all alike):

../../../../../../dist/include/xptcstubsdef.inc: In member function 'virtual nsresult nsXPTCStubBase::Stub3()':
../../../../../../dist/include/xptcstubsdef.inc:1:1: error: cannot convert 'int' to 'nsresult' in return

(this is with gcc 4.5.4)
You need to log in before you can comment on or make changes to this bug.