Enable Mochitests for gUM on B2G

RESOLVED FIXED in mozilla26

Status

()

Core
WebRTC
P2
normal
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: ekr, Assigned: Martijn Wargers (dead))

Tracking

Trunk
mozilla26
x86
Mac OS X
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [WebRTC][blocking-webrtc-][b2g-gum+])

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

5 years ago
Currently, the gUM mochitests (dom/media/tests/mochitest/test_getUserMedia_basicAudio.html etc) do not run on b2g. Once b2g gUM starts working, we should change that.

The task here is to enable them, test that they work in try, and then commit the enablement,
fixing as necessary.

The relevant line of code, for example is the true at:
https://hg.mozilla.org/mozilla-central/file/e474b6cfebce/dom/media/tests/mochitest/test_getUserMedia_basicAudio.html#l39

Which sets desktop only.

Updated

5 years ago
Blocks: 749522

Updated

5 years ago
Priority: -- → P2

Updated

5 years ago
Whiteboard: [WebRTC][blocking-webrtc-][b2g-webrtc+]

Updated

5 years ago
Whiteboard: [WebRTC][blocking-webrtc-][b2g-webrtc+] → [WebRTC][blocking-webrtc-][b2g-gum+]
I'm changing something fundamental on how we control what tests run on what platform over in bug 862883. Let's wait for that to land first before implementing this.
Depends on: 862883
(Assignee)

Updated

5 years ago
Blocks: 781696

Updated

4 years ago
Assignee: nobody → schien
S.C, please help on this issue
(Assignee)

Comment 3

4 years ago
See also bug 903765.
(Assignee)

Comment 4

4 years ago
Created attachment 793552 [details]
log.txt

Currently, the whole dom/media/tests/mochitest subdirectory is excluded in the b2g.json file.
I did a run of that directory, see log, there are a lot of failures, but at least some of the test files seem to be passing.
I could remove the dom/media/tests/mochitest subdirectory from the exclude list and add the test files from that subdirectory that are currently failing.
(In reply to Martijn Wargers [:mwargers] (QA) from comment #4)
> Created attachment 793552 [details]
> log.txt
> 
> Currently, the whole dom/media/tests/mochitest subdirectory is excluded in
> the b2g.json file.
> I did a run of that directory, see log, there are a lot of failures, but at
> least some of the test files seem to be passing.
> I could remove the dom/media/tests/mochitest subdirectory from the exclude
> list and add the test files from that subdirectory that are currently
> failing.

The test run there indicates the gUM tests are passing right now actually. The PC/DC tests failing is expected and not surprising.

What we need to do here to fix this is just alter the b2g.json file to have the PC/DC tests turned off only.
(Assignee)

Comment 6

4 years ago
These tests are passing:
"dom/media/tests/mochitest/test_getUserMedia_exceptions.html":"",
"dom/media/tests/mochitest/test_getUserMedia_gumWithinGum.html":"",
"dom/media/tests/mochitest/test_getUserMedia_playAudioTwice.html":"",
"dom/media/tests/mochitest/test_getUserMedia_playVideoAudioTwice.html":"",
"dom/media/tests/mochitest/test_getUserMedia_playVideoTwice.html":"",
"dom/media/tests/mochitest/test_getUserMedia_stopAudioStream.html":"",
"dom/media/tests/mochitest/test_getUserMedia_stopAudioStreamWithFollowupAudio.html":"",
"dom/media/tests/mochitest/test_getUserMedia_stopVideoAudioStream.html":"",
"dom/media/tests/mochitest/test_getUserMedia_stopVideoAudioStreamWithFollowupVideoAudio.html":"",
"dom/media/tests/mochitest/test_getUserMedia_stopVideoStream.html":"",
"dom/media/tests/mochitest/test_getUserMedia_stopVideoStreamWithFollowupVideo.html":"",
"dom/media/tests/mochitest/test_peerConnection_toJSON.html":""
(Assignee)

Comment 7

4 years ago
(In reply to Jason Smith [:jsmith] from comment #5)
> What we need to do here to fix this is just alter the b2g.json file to have
> the PC/DC tests turned off only.

Ok, I can do that.
(Assignee)

Comment 8

4 years ago
Created attachment 793679 [details] [diff] [review]
868035.diff

I'll test this on tryserver.
Assignee: schien → martijn.martijn
(Assignee)

Comment 9

4 years ago
Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=516ec7ea0b8f
(Assignee)

Comment 10

4 years ago
Comment on attachment 793679 [details] [diff] [review]
868035.diff

Review of attachment 793679 [details] [diff] [review]:
-----------------------------------------------------------------

Tryserver passes
I did a rebuild of 15 times for chunk 4 (where these tests were exercised).
Attachment #793679 - Flags: review?(jgriffin)
Comment on attachment 793679 [details] [diff] [review]
868035.diff

Review of attachment 793679 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good if the retriggers don't show any intermittents.
Attachment #793679 - Flags: review?(jgriffin) → review+
(Assignee)

Comment 12

4 years ago
Created attachment 793771 [details] [diff] [review]
868035.diff (for check-in)

All the 15 chunks where green, so seems intermittent fail-safe.
Attachment #793552 - Attachment is obsolete: true
Attachment #793679 - Attachment is obsolete: true
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/b2g-inbound/rev/be955e7ae7d5
Flags: in-testsuite+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/be955e7ae7d5
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
(Assignee)

Comment 15

4 years ago
(In reply to Jason Smith [:jsmith] from comment #5)
> The test run there indicates the gUM tests are passing right now actually.
> The PC/DC tests failing is expected and not surprising.

I filed bug 908473 for this, not sure if it is feasible to get these tests working on b2g.
You need to log in before you can comment on or make changes to this bug.