Closed
Bug 868035
Opened 12 years ago
Closed 11 years ago
Enable Mochitests for gUM on B2G
Categories
(Core :: WebRTC, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: ekr, Assigned: martijn.martijn)
References
Details
(Whiteboard: [WebRTC][blocking-webrtc-][b2g-gum+])
Attachments
(1 file, 2 obsolete files)
3.33 KB,
patch
|
Details | Diff | Splinter Review |
Currently, the gUM mochitests (dom/media/tests/mochitest/test_getUserMedia_basicAudio.html etc) do not run on b2g. Once b2g gUM starts working, we should change that.
The task here is to enable them, test that they work in try, and then commit the enablement,
fixing as necessary.
The relevant line of code, for example is the true at:
https://hg.mozilla.org/mozilla-central/file/e474b6cfebce/dom/media/tests/mochitest/test_getUserMedia_basicAudio.html#l39
Which sets desktop only.
Updated•12 years ago
|
Blocks: webrtc-tests
Updated•12 years ago
|
Priority: -- → P2
Updated•12 years ago
|
Whiteboard: [WebRTC][blocking-webrtc-][b2g-webrtc+]
Updated•12 years ago
|
Whiteboard: [WebRTC][blocking-webrtc-][b2g-webrtc+] → [WebRTC][blocking-webrtc-][b2g-gum+]
Comment 1•12 years ago
|
||
I'm changing something fundamental on how we control what tests run on what platform over in bug 862883. Let's wait for that to land first before implementing this.
Depends on: 862883
Assignee | ||
Updated•12 years ago
|
Blocks: b2g-mochitests
Assignee | ||
Comment 3•11 years ago
|
||
See also bug 903765.
Assignee | ||
Comment 4•11 years ago
|
||
Currently, the whole dom/media/tests/mochitest subdirectory is excluded in the b2g.json file.
I did a run of that directory, see log, there are a lot of failures, but at least some of the test files seem to be passing.
I could remove the dom/media/tests/mochitest subdirectory from the exclude list and add the test files from that subdirectory that are currently failing.
Comment 5•11 years ago
|
||
(In reply to Martijn Wargers [:mwargers] (QA) from comment #4)
> Created attachment 793552 [details]
> log.txt
>
> Currently, the whole dom/media/tests/mochitest subdirectory is excluded in
> the b2g.json file.
> I did a run of that directory, see log, there are a lot of failures, but at
> least some of the test files seem to be passing.
> I could remove the dom/media/tests/mochitest subdirectory from the exclude
> list and add the test files from that subdirectory that are currently
> failing.
The test run there indicates the gUM tests are passing right now actually. The PC/DC tests failing is expected and not surprising.
What we need to do here to fix this is just alter the b2g.json file to have the PC/DC tests turned off only.
Assignee | ||
Comment 6•11 years ago
|
||
These tests are passing:
"dom/media/tests/mochitest/test_getUserMedia_exceptions.html":"",
"dom/media/tests/mochitest/test_getUserMedia_gumWithinGum.html":"",
"dom/media/tests/mochitest/test_getUserMedia_playAudioTwice.html":"",
"dom/media/tests/mochitest/test_getUserMedia_playVideoAudioTwice.html":"",
"dom/media/tests/mochitest/test_getUserMedia_playVideoTwice.html":"",
"dom/media/tests/mochitest/test_getUserMedia_stopAudioStream.html":"",
"dom/media/tests/mochitest/test_getUserMedia_stopAudioStreamWithFollowupAudio.html":"",
"dom/media/tests/mochitest/test_getUserMedia_stopVideoAudioStream.html":"",
"dom/media/tests/mochitest/test_getUserMedia_stopVideoAudioStreamWithFollowupVideoAudio.html":"",
"dom/media/tests/mochitest/test_getUserMedia_stopVideoStream.html":"",
"dom/media/tests/mochitest/test_getUserMedia_stopVideoStreamWithFollowupVideo.html":"",
"dom/media/tests/mochitest/test_peerConnection_toJSON.html":""
Assignee | ||
Comment 7•11 years ago
|
||
(In reply to Jason Smith [:jsmith] from comment #5)
> What we need to do here to fix this is just alter the b2g.json file to have
> the PC/DC tests turned off only.
Ok, I can do that.
Assignee | ||
Comment 9•11 years ago
|
||
Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=516ec7ea0b8f
Assignee | ||
Comment 10•11 years ago
|
||
Comment on attachment 793679 [details] [diff] [review]
868035.diff
Review of attachment 793679 [details] [diff] [review]:
-----------------------------------------------------------------
Tryserver passes
I did a rebuild of 15 times for chunk 4 (where these tests were exercised).
Attachment #793679 -
Flags: review?(jgriffin)
Comment 11•11 years ago
|
||
Comment on attachment 793679 [details] [diff] [review]
868035.diff
Review of attachment 793679 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good if the retriggers don't show any intermittents.
Attachment #793679 -
Flags: review?(jgriffin) → review+
Assignee | ||
Comment 12•11 years ago
|
||
All the 15 chunks where green, so seems intermittent fail-safe.
Attachment #793552 -
Attachment is obsolete: true
Attachment #793679 -
Attachment is obsolete: true
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 13•11 years ago
|
||
Flags: in-testsuite+
Keywords: checkin-needed
Comment 14•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Assignee | ||
Comment 15•11 years ago
|
||
(In reply to Jason Smith [:jsmith] from comment #5)
> The test run there indicates the gUM tests are passing right now actually.
> The PC/DC tests failing is expected and not surprising.
I filed bug 908473 for this, not sure if it is feasible to get these tests working on b2g.
You need to log in
before you can comment on or make changes to this bug.
Description
•