Created attachment 745055 [details] SSL-URL-SPOOF-AND-GEOLOCATION-CLICKJACKING.zip User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20100101 Firefox/20.0 Build ID: 20130409194949 Steps to reproduce: SELECT / OPTION elements may contain html contents and surpass the location bar and the box geolocation (for exemple), it is possible with these elements to make multiple attacks like SSL URL Spoofing and Clickjacking Actual results: The Location Bar and the SSL indicia are spoofed and the geolocation authorization can be bypassed. Expected results: Select/Option element surpass all other element ( location bar / geolocation box ...)
Video (not listed) of the proof of concept => https://www.youtube.com/watch?v=tF5LTfQhSzw
Component: General → Security
Confirmed. What I see: - On screen resolution 1440x900, double-clicking the link causes the geolocation access dialog to appear only briefly; user has opted into sharing geolocation without knowingly clicking the confirmation, as indicated by the geolocation icon in the URL bar. - On screen resolution 1055x722 (virtualized system), double-clicking the link causes the PNG to overlay the browser chrome above the location bar.
Status: UNCONFIRMED → NEW
Ever confirmed: true
what is the severity of this vulnerability?
Attachment #745055 - Attachment mime type: application/octet-stream → application/java-archive
Any updates here, Dan?
The geolocation clickjacking is a duplicate. Floating the image over the URL bar is a good trick but a visual spoof like that is sec-moderate at best. (Getting real but incorrect text into the actual location bar is what's required for sec-high.)
Component: Security → Layout
Keywords: csec-spoof, sec-moderate
Created attachment 780663 [details] [diff] [review] fix This should fix the problem with the drop-down menu overlapping the URL bar. A double-click can likely still be used to overlap any UI that hangs down over the content area like the geolocation prompt. With this patch the drop-down in the test is opened below the combobox (out-of-view) but this shouldn't be a problem for normal pages since this an edge case where the drop-down has already been resized to show only one option and that option is to big to fit on either side -- before this patch we chose the side with the most room and if that was above then it could overlap UI; with this patch we always choose to open it below for this edge case. BTW, the combobox double-click trick only works on Windows afaict; on Linux and OSX the drop-down menu is closed after the double-click. Not sure why there's a difference.
Assignee: nobody → matspal
Attachment #780663 - Flags: review?(roc)
Attachment #780663 - Flags: review?(roc) → review+
Status: NEW → RESOLVED
Last Resolved: 6 years ago
status-firefox25: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Filed bug 898035 on the combobox drop-down menu covering a door-hanger.
where download firefox with the fix of this vulnerability? I would test it !
Here are the Nightly builds: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-central/ load about:buildconfig and click on the "Built from" link to see changeset it was built from. If the number is greater than the mozilla-central changeset number above (139940) then it contains the fix.
Yes ! Good jobs !!! RESOLVED FIXED ;)
Verified fixed FF25 2013-08-29.
Given the tiny patch and low risk we should just take this on ESR24
status-b2g18: --- → unaffected
status-firefox-esr17: --- → wontfix
status-firefox-esr24: --- → affected
tracking-firefox-esr24: --- → 25+
Mats, can I get an ESR24 patch please?
Comment on attachment 780663 [details] [diff] [review] fix This patch applies cleanly to ESR24.
Attachment #780663 - Flags: approval-mozilla-esr24?
Attachment #780663 - Flags: approval-mozilla-esr24? → approval-mozilla-esr24+
status-firefox-esr24: affected → fixed
Verified fixed 24esr, 2013-10-16.
Status: RESOLVED → VERIFIED
status-firefox-esr24: fixed → verified
Whiteboard: [adv-main25+] → [adv-main25+][adv-esr24-1+]
You need to log in before you can comment on or make changes to this bug.