868327 - (CVE-2013-5593) Mozilla Firefox Navigation away from a page with an active <select> dropdown menu can be used for URL/SSL spoofing and ClickJacking Attacks

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Jordi Chancel]

Attachment: SSL-URL-SPOOF-AND-GEOLOCATION-CLICKJACKING.zip

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20100101 Firefox/20.0
Build ID: 20130409194949

Steps to reproduce:

SELECT / OPTION elements  may contain html contents and surpass the location bar and the box geolocation (for exemple), it is possible with these elements to make multiple attacks like SSL URL Spoofing and Clickjacking


Actual results:

The Location Bar and the SSL indicia are spoofed and the geolocation authorization can be bypassed.


Expected results:

Select/Option element surpass all other element ( location bar / geolocation box ...)

Comment 1

[Jordi Chancel]

Video (not listed) of the proof of concept => https://www.youtube.com/watch?v=tF5LTfQhSzw

Comment 2

[Matt Wobensmith [:mwobensmith][:matt:]]

Confirmed. What I see:

- On screen resolution 1440x900, double-clicking the link causes the geolocation access dialog to appear only briefly; user has opted into sharing geolocation without knowingly clicking the confirmation, as indicated by the geolocation icon in the URL bar.

- On screen resolution 1055x722 (virtualized system), double-clicking the link causes the PNG to overlay the browser chrome above the location bar.

Comment 3

[Jordi Chancel]

what is the severity of this vulnerability?

Comment 4

[Andrew McCreight [:mccr8]]

Any updates here, Dan?

Comment 5

[Daniel Veditz [:dveditz]]

The geolocation clickjacking is a duplicate. Floating the image over the URL bar is a good trick but a visual spoof like that is sec-moderate at best. (Getting real but incorrect text into the actual location bar is what's required for sec-high.)

Comment 6

[Mats Palmgren (inactive)]

Attachment: fix

This should fix the problem with the drop-down menu overlapping the
URL bar.  A double-click can likely still be used to overlap any UI
that hangs down over the content area like the geolocation prompt.

With this patch the drop-down in the test is opened below the combobox
(out-of-view) but this shouldn't be a problem for normal pages since
this an edge case where the drop-down has already been resized to show
only one option and that option is to big to fit on either side --
before this patch we chose the side with the most room and if that was
above then it could overlap UI; with this patch we always choose to
open it below for this edge case.

BTW, the combobox double-click trick only works on Windows afaict;
on Linux and OSX the drop-down menu is closed after the double-click.
Not sure why there's a difference.

Comment 7

[Mats Palmgren (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2e27eaf8ebc2

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2e27eaf8ebc2

Comment 9

[Mats Palmgren (inactive)]

Filed bug 898035 on the combobox drop-down menu covering a door-hanger.

Comment 10

[Jordi Chancel]

where download firefox with the fix of this vulnerability?
I would test it !

Comment 11

[Mats Palmgren (inactive)]

Here are the Nightly builds:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-central/

load about:buildconfig and click on the "Built from" link to see changeset
it was built from.  If the number is greater than the mozilla-central
changeset number above (139940) then it contains the fix.

Comment 12

[Jordi Chancel]

Yes ! Good jobs !!! RESOLVED FIXED ;)

Comment 14

[Matt Wobensmith [:mwobensmith][:matt:]]

Verified fixed FF25 2013-08-29.

Comment 15

[Daniel Veditz [:dveditz]]

Given the tiny patch and low risk we should just take this on ESR24

Comment 16

[Al Billings [:abillings - ex-MoCo]]

Mats, can I get an ESR24 patch please?

Comment 17

[Mats Palmgren (inactive)]

Comment on attachment 780663 [details] [diff] [review]
fix

This patch applies cleanly to ESR24.

Comment 18

[Mats Palmgren (inactive)]

https://hg.mozilla.org/releases/mozilla-esr24/rev/00bb6aeae85f

Comment 19

[Matt Wobensmith [:mwobensmith][:matt:]]

Verified fixed 24esr, 2013-10-16.