868545 - Don't sync early in startup

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Sync, defect)

Description

[Jim Mathies [:jimm]]

We should avoid triggering sync early in startup. RemoteTabs is currently doing this.

Comment 1

[Jim Mathies [:jimm]]

Attachment: fix

Comment 2

[Matt Brubeck (:mbrubeck)]

Comment on attachment 745297 [details] [diff] [review]
fix

Review of attachment 745297 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/profile/metro.js
@@ -422,5 @@
>  
>  #ifdef MOZ_SERVICES_SYNC
>  // sync service
>  pref("services.sync.registerEngines", "Tab,Bookmarks,Form,History,Password,Prefs");
> -pref("services.sync.autoconnectDelay", 5);

Was this not working?  I notice that Metro is the only user of this pref; if it's broken or unused perhaps we should file a separate bug to remove the /services code for it.

Comment 3

[Richard Newman [:rnewman]]

It doesn't look broken to me, but note that this is equivalent to just calling scheduleNextSync() with appropriate values after a delay. It means "please automatically connect after this delay", not "please make sure we don't sync until this timeout has passed".

It doesn't stop other code from syncing before then, which is what was happening.

Comment 4

[Jim Mathies [:jimm]]

It didn't seem to be working, which is why I did the manual call and removed the pref. I'll file a follow up on it.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8939cbc62b39