Don't sync early in startup

RESOLVED FIXED in Firefox 23

Status

Firefox for Metro
Sync
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jimm, Assigned: jimm)

Tracking

Trunk
Firefox 23
x86_64
Windows 7
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
We should avoid triggering sync early in startup. RemoteTabs is currently doing this.
(Assignee)

Comment 1

5 years ago
Created attachment 745297 [details] [diff] [review]
fix
Assignee: nobody → jmathies
Attachment #745297 - Flags: review?(mbrubeck)
Comment on attachment 745297 [details] [diff] [review]
fix

Review of attachment 745297 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/profile/metro.js
@@ -422,5 @@
>  
>  #ifdef MOZ_SERVICES_SYNC
>  // sync service
>  pref("services.sync.registerEngines", "Tab,Bookmarks,Form,History,Password,Prefs");
> -pref("services.sync.autoconnectDelay", 5);

Was this not working?  I notice that Metro is the only user of this pref; if it's broken or unused perhaps we should file a separate bug to remove the /services code for it.
Attachment #745297 - Flags: review?(mbrubeck) → review+
Blocks: 868523
It doesn't look broken to me, but note that this is equivalent to just calling scheduleNextSync() with appropriate values after a delay. It means "please automatically connect after this delay", not "please make sure we don't sync until this timeout has passed".

It doesn't stop other code from syncing before then, which is what was happening.
(Assignee)

Comment 4

5 years ago
It didn't seem to be working, which is why I did the manual call and removed the pref. I'll file a follow up on it.
(Assignee)

Updated

5 years ago
Blocks: 869531
https://hg.mozilla.org/mozilla-central/rev/8939cbc62b39
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
You need to log in before you can comment on or make changes to this bug.