868604 - JavaScript Warning "test for equality (==) mistyped as assignment (=)?" in "chrome://browser/content/downloads.js"

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Download Manager, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: fix-downloads-warning.patch

I see this annoying warning in logcat every time I start Firefox:

  E/GeckoConsole(30193): [JavaScript Warning: "SyntaxError: test for equality (==) mistyped as assignment (=)?" {file: "chrome://browser/content/downloads.js" line: 103 column: 50 source: "    while (download = this._privateDownloads.pop()) {

Comment 1

[Brian Nicholson (:bnicholson)]

Comment on attachment 745361 [details] [diff] [review]
fix-downloads-warning.patch

If you don't want the extra code, I think adding an extra set of parentheses inside of the while loop will make the assignment explicit and avoids this warning.

Comment 2

[Chris Peterson [:cpeterson]]

Attachment: fix-downloads-warning-v2.patch

(In reply to Brian Nicholson (:bnicholson) from comment #1)
> Comment on attachment 745361 [details] [diff] [review]
> fix-downloads-warning.patch
> 
> If you don't want the extra code, I think adding an extra set of parentheses
> inside of the while loop will make the assignment explicit and avoids this
> warning.

I'll use your suggestion. :)

(carrying forward r=bnicholson)

Comment 3

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/75c66fa0109e

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/75c66fa0109e