Failures in chrome://mochitests/content/browser/browser/base/content/test/* on UX branch

RESOLVED FIXED

Status

()

Firefox
Toolbars and Customization
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: mconley, Assigned: mconley)

Tracking

(Blocks: 1 bug)

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Australis:M5])

Attachments

(1 attachment, 5 obsolete attachments)

15:45:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "http://user:pass@example.com/" line: 0}]
15:45:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Tab loaded
15:45:43     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | URL bar had user/pass stripped initially
15:45:43     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | URL bar had user/pass stripped after reverting
15:45:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Console message: [JavaScript Warning: "XUL box for _moz_generated_content_before element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/tabbrowser.xml" line: 1058}]
15:45:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Console message: [JavaScript Warning: "XUL box for _moz_generated_content_after element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/tabbrowser.xml" line: 1058}]
15:45:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Console message: [JavaScript Warning: "XUL box for _moz_generated_content_before element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/tabbrowser.xml" line: 1058}]
15:45:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Console message: [JavaScript Warning: "XUL box for _moz_generated_content_after element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/tabbrowser.xml" line: 1058}]
15:45:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Console message: [JavaScript Warning: "XUL box for _moz_generated_content_before element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/tabbrowser.xml" line: 1058}]
15:45:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Console message: [JavaScript Warning: "XUL box for _moz_generated_content_after element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/tabbrowser.xml" line: 1058}]
15:45:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Console message: [JavaScript Warning: "XUL box for _moz_generated_content_before element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://global/content/bindings/scrollbox.xml" line: 169}]
15:45:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Console message: [JavaScript Warning: "XUL box for _moz_generated_content_before element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/browser.xul" line: 0}]
15:45:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Console message: [JavaScript Warning: "XUL box for _moz_generated_content_after element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/browser.xul" line: 0}]
15:45:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Console message: [JavaScript Warning: "XUL box for _moz_generated_content_before element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/browser.xul" line: 0}]
15:45:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Console message: [JavaScript Warning: "XUL box for _moz_generated_content_after element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/browser.xul" line: 0}]
15:45:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Console message: [JavaScript Warning: "XUL box for _moz_generated_content_before element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "resource://app/modules/CustomizableUI.jsm" line: 423}]
15:45:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Console message: [JavaScript Warning: "XUL box for _moz_generated_content_after element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "resource://app/modules/CustomizableUI.jsm" line: 423}]
15:45:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Console message: [JavaScript Warning: "XUL box for _moz_generated_content_before element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "resource://app/modules/CustomizableUI.jsm" line: 423}]
15:45:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Console message: [JavaScript Warning: "XUL box for _moz_generated_content_after element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "resource://app/modules/CustomizableUI.jsm" line: 423}]
15:45:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Console message: [JavaScript Warning: "XUL box for _moz_generated_content_before element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/browser.xul" line: 0}]
15:45:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Console message: [JavaScript Warning: "XUL box for _moz_generated_content_after element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/browser.xul" line: 0}]
15:45:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Console message: [JavaScript Warning: "XUL box for _moz_generated_content_before element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/browser.xul" line: 0}]
15:45:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Console message: [JavaScript Warning: "XUL box for _moz_generated_content_after element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/browser.xul" line: 0}]
15:45:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Loading tab
15:45:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Console message: [JavaScript Warning: "XUL box for _moz_generated_content_before element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/tabbrowser.xml" line: 1311}]
15:45:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Console message: [JavaScript Warning: "XUL box for _moz_generated_content_after element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://global/content/bindings/browser.xml" line: 223}]
15:45:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Console message: [JavaScript Warning: "XUL box for _moz_generated_content_before element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/tabbrowser.xml" line: 1058}]
15:45:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Console message: [JavaScript Warning: "XUL box for _moz_generated_content_after element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/tabbrowser.xml" line: 1058}]
15:45:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Console message: [JavaScript Warning: "XUL box for _moz_generated_content_before element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/tabbrowser.xml" line: 1058}]
15:45:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Console message: [JavaScript Warning: "XUL box for _moz_generated_content_after element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/tabbrowser.xml" line: 1058}]
15:45:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "http://user:pass@example.com/" line: 0}]
15:45:43     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Tab loaded
15:45:43     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | URL bar had user/pass stripped initially
15:45:44     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Console message: [JavaScript Warning: "XUL box for _moz_generated_content_before element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/tabbrowser.xml" line: 1311}]
15:45:44     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Console message: [JavaScript Warning: "XUL box for _moz_generated_content_after element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://global/content/bindings/browser.xml" line: 223}]
15:45:44     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Console message: [JavaScript Warning: "XUL box for _moz_generated_content_before element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/tabbrowser.xml" line: 1058}]
15:45:44     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Console message: [JavaScript Warning: "XUL box for _moz_generated_content_after element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/tabbrowser.xml" line: 1058}]
15:45:44     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Console message: [JavaScript Warning: "XUL box for _moz_generated_content_before element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/tabbrowser.xml" line: 1058}]
15:45:44     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Console message: [JavaScript Warning: "XUL box for _moz_generated_content_after element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/tabbrowser.xml" line: 1058}]
15:45:44     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Console message: [JavaScript Warning: "XUL box for _moz_generated_content_before element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/tabbrowser.xml" line: 1058}]
15:46:13  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Test timed out
15:46:13     INFO -  args: ['/home/cltbld/talos-slave/test/build/tests/bin/screentopng']
15:46:14     INFO -  INFO TEST-END | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | finished in 30036ms
15:46:14     INFO -  TEST-INFO | checking window state
15:46:14  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | Found a browser window after previous test timed out
15:46:14     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js | must wait for focus
Refocusing this bug a little bit to encompass all test failures under browser/base/content/test.
Summary: UX / Jamun failures in chrome://mochitests/content/browser/browser/base/content/test/browser_URLBarSetURI.js → UX / Jamun failures in chrome://mochitests/content/browser/browser/base/content/test/*
Created attachment 745428 [details] [diff] [review]
WIP Patch 1

This is me, trying to drive a flaming stake through the heart of our failures under browser/base/content/test.
Comment on attachment 745428 [details] [diff] [review]
WIP Patch 1

Review of attachment 745428 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/customizableui/src/CustomizeMode.jsm
@@ +102,5 @@
>      window.PanelUI.menuButton.addEventListener("click", this, false);
>      window.PanelUI.menuButton.disabled = true;
>  
>      // Let everybody in this window know that we're about to customize.
> +    this.dispatchToolboxEvent("customizationstarting");

What's with changing the event names?
(In reply to Blair McBride [:Unfocused] (Limited availability.) from comment #3)
> Comment on attachment 745428 [details] [diff] [review]
> WIP Patch 1
> 
> Review of attachment 745428 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: browser/components/customizableui/src/CustomizeMode.jsm
> @@ +102,5 @@
> >      window.PanelUI.menuButton.addEventListener("click", this, false);
> >      window.PanelUI.menuButton.disabled = true;
> >  
> >      // Let everybody in this window know that we're about to customize.
> > +    this.dispatchToolboxEvent("customizationstarting");
> 
> What's with changing the event names?

I guess I thought if we were going to introduce new events, we might as well make them more consistent with the naming convention of the older ones. Not married to the idea at all, just thought I'd propose it.
Created attachment 748172 [details] [diff] [review]
WIP Patch 2

All tests under browser/base/content/test just passed for me on Ubuntu with this patch.
Attachment #745428 - Attachment is obsolete: true
No longer blocks: 770135
Status: NEW → ASSIGNED
Whiteboard: [Australis:M4] → [Australis:M5]
Created attachment 750036 [details] [diff] [review]
WIP Patch 3

All tests just passed for me on Windows with this patch...
Attachment #748172 - Attachment is obsolete: true
Summary: UX / Jamun failures in chrome://mochitests/content/browser/browser/base/content/test/* → Failures in chrome://mochitests/content/browser/browser/base/content/test/* on UX branch
Created attachment 751028 [details] [diff] [review]
Patch v1

This fixes the leaktest failures I was seeing on debug builds.
Attachment #750036 - Attachment is obsolete: true
Comment on attachment 751028 [details] [diff] [review]
Patch v1

So this seems to take care of all of the failures under browser/base/content/test. The primary problem seemed to be that the customization mode functions in browser/base/content/test/head.js needed updating. I also needed to do a little bit of reorganizing in CustomizeMode.exit in order to make sure events were fired in the right sequence.

Note that this doesn't give us a green bc test. I'm still seeing failures under browser/components/tabview/test, and browser/devtools/debugger/test. I'll investigate those separately.
Attachment #751028 - Flags: review?(jaws)
Comment on attachment 751028 [details] [diff] [review]
Patch v1

Review of attachment 751028 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/browser.js
@@ +1250,5 @@
>  
> +    gNavToolbox.addEventListener("CustomizationStarting", CustomizationHandler,
> +                                 false);
> +    gNavToolbox.addEventListener("CustomizationEnding", CustomizationHandler,
> +                                 false);

The third argument here, false, can be removed since false is the default for that argument.

::: browser/base/content/test/browser_bug599325.js
@@ -6,5 @@
> -  ok(!isElementVisible(addonBar), "addon bar initially hidden");
> -
> -  openToolbarCustomizationUI(function () {
> -    ok(isElementVisible(addonBar),
> -       "add-on bar is visible during toolbar customization");

I think it would be good to flip this test around and make it so that it checks that the add-on bar *doesn't* become visible when entering customization mode. But maybe you would prefer that to be in a separate bug? I'll let you make the judgement call here. Either way, we shouldn't reuse the file for this because the bug that it references will no longer apply.

::: browser/base/content/test/head.js
@@ +111,5 @@
>  function resetBlocklist() {
>    Services.prefs.setCharPref("extensions.blocklist.url", _originalTestBlocklistURL);
>  }
>  
> +function whenNewWindowLoaded(aOptions, aCallback){

Why the change here? It's a nitpick, but I think we should leave the space between the ) and {.

::: browser/components/customizableui/src/CustomizeMode.jsm
@@ +136,5 @@
>          self.areas.push(target);
>        }
>  
>        self.populatePalette();
> +      self.dispatchToolboxEvent("customizationready");

I'm not too fond of the mixing of SentenceCase events like CustomizationStarting and lowercase events like customizationready. I think we should standardize on all lowercase.

@@ +204,5 @@
>  
>      // And drop all area references.
>      this.areas = [];
>  
> +    // Let everybody in this window know that we're startint to

s/startint/starting/

@@ +463,5 @@
>    },
>  
> +  _onUIChange: function() {
> +    this._changed = true;
> +    this.dispatchToolboxEvent("customizationchange");

When is customizationchange used? I don't see it referenced elsewhere in this patch.
Attachment #751028 - Flags: review?(jaws) → review+
Comment on attachment 751028 [details] [diff] [review]
Patch v1

>--- a/browser/base/content/browser.css
>+++ b/browser/base/content/browser.css
>@@ -22,16 +22,22 @@ toolbar[customizable="true"]:not([nowind
>   -moz-binding: url("chrome://browser/content/customizableui/toolbar.xml#toolbar-drag");
> }
> %endif
> 
> #toolbar-menubar[autohide="true"] {
>   -moz-binding: url("chrome://browser/content/customizableui/toolbar.xml#toolbar-menubar-autohide");
> }
> 
>+%ifdef XP_UNIX
>+#toolbar-menubar {
>+  -moz-binding: url("chrome://browser/content/customizableui/toolbar.xml#toolbar-drag");
>+}
>+%endif

This seems wrong. Also, what does it have to do with this bug?
(In reply to Dão Gottwald [:dao] from comment #10)
> Comment on attachment 751028 [details] [diff] [review]
> Patch v1
> 
> >--- a/browser/base/content/browser.css
> >+++ b/browser/base/content/browser.css
> >@@ -22,16 +22,22 @@ toolbar[customizable="true"]:not([nowind
> >   -moz-binding: url("chrome://browser/content/customizableui/toolbar.xml#toolbar-drag");
> > }
> > %endif
> > 
> > #toolbar-menubar[autohide="true"] {
> >   -moz-binding: url("chrome://browser/content/customizableui/toolbar.xml#toolbar-menubar-autohide");
> > }
> > 
> >+%ifdef XP_UNIX
> >+#toolbar-menubar {
> >+  -moz-binding: url("chrome://browser/content/customizableui/toolbar.xml#toolbar-drag");
> >+}
> >+%endif
> 
> This seems wrong. Also, what does it have to do with this bug?

I need to override this toolkit rule: http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/linux/global/global.css#38

Otherwise, with the menubar not autohidden, it doesn't get registered as a customization target via our toolbar binding.

Is there something more precise that you would recommend I do instead? Perhaps a more direct override of:

toolbar[type="menubar"]:not([autohide="true"]):not(:-moz-lwtheme):-moz-system-metric(menubar-drag) {
  -moz-binding: url("chrome://browser/content/customizableui/toolbar.xml#toolbar-drag");
}

?
Flags: needinfo?(dao)
Created attachment 751154 [details] [diff] [review]
Patch v1.1 (r+'d by jaws)

Hey Dao - I updated the rule you pointed out. Does this make more sense?
Attachment #751028 - Attachment is obsolete: true
Attachment #751154 - Flags: feedback?(dao)
FWIW, the v1 of this patch is showing some improvements to our mochitests on try:

https://tbpl.mozilla.org/?tree=Try&rev=d3dce9305e6d
Comment on attachment 751154 [details] [diff] [review]
Patch v1.1 (r+'d by jaws)

>-#TabsToolbar[tabsontop=true]:not(:-moz-lwtheme):-moz-system-metric(menubar-drag) {
>+#TabsToolbar[tabsontop=true]:not(:-moz-lwtheme):-moz-system-metric(menubar-drag),
>+#toolbar-menubar:not([autohide="true"]):not(:-moz-lwtheme):-moz-system-metric(menubar-drag) {

If you add your selector before the existing one rather than after it, you won't needlessly add to this line's hg blame.
Attachment #751154 - Flags: feedback?(dao) → feedback+
Created attachment 751162 [details] [diff] [review]
Patch v1.1 (r+'d by jaws, feedback+ from dao)

Thanks Dao!

(In reply to Jared Wein [:jaws] from comment #9)
> Comment on attachment 751028 [details] [diff] [review]
> Patch v1
> 
> Review of attachment 751028 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: browser/base/content/browser.js
> @@ +1250,5 @@
> >  
> > +    gNavToolbox.addEventListener("CustomizationStarting", CustomizationHandler,
> > +                                 false);
> > +    gNavToolbox.addEventListener("CustomizationEnding", CustomizationHandler,
> > +                                 false);
> 
> The third argument here, false, can be removed since false is the default
> for that argument.
> 

Fixed.

> ::: browser/base/content/test/browser_bug599325.js
> @@ -6,5 @@
> > -  ok(!isElementVisible(addonBar), "addon bar initially hidden");
> > -
> > -  openToolbarCustomizationUI(function () {
> > -    ok(isElementVisible(addonBar),
> > -       "add-on bar is visible during toolbar customization");
> 
> I think it would be good to flip this test around and make it so that it
> checks that the add-on bar *doesn't* become visible when entering
> customization mode. But maybe you would prefer that to be in a separate bug?
> I'll let you make the judgement call here. Either way, we shouldn't reuse
> the file for this because the bug that it references will no longer apply.
>

I'll file a new bug for that.
 
> ::: browser/base/content/test/head.js
> @@ +111,5 @@
> >  function resetBlocklist() {
> >    Services.prefs.setCharPref("extensions.blocklist.url", _originalTestBlocklistURL);
> >  }
> >  
> > +function whenNewWindowLoaded(aOptions, aCallback){
> 
> Why the change here? It's a nitpick, but I think we should leave the space
> between the ) and {.
> 

Bah, just changecruft. Reverted.

> ::: browser/components/customizableui/src/CustomizeMode.jsm
> @@ +136,5 @@
> >          self.areas.push(target);
> >        }
> >  
> >        self.populatePalette();
> > +      self.dispatchToolboxEvent("customizationready");
> 
> I'm not too fond of the mixing of SentenceCase events like
> CustomizationStarting and lowercase events like customizationready. I think
> we should standardize on all lowercase.
> 

Done.

> @@ +204,5 @@
> >  
> >      // And drop all area references.
> >      this.areas = [];
> >  
> > +    // Let everybody in this window know that we're startint to
> 
> s/startint/starting/
> 

Fixed.

> @@ +463,5 @@
> >    },
> >  
> > +  _onUIChange: function() {
> > +    this._changed = true;
> > +    this.dispatchToolboxEvent("customizationchange");
> 
> When is customizationchange used? I don't see it referenced elsewhere in
> this patch.

It's an event that the old toolkit customization code used to fire when moving an item. I figured if we're going to go so far as to support the old beforecustomization aftercustomization events, we might as well fire this one too.
Attachment #751154 - Attachment is obsolete: true
Attachment #751162 - Flags: review+
Attachment #751162 - Flags: feedback+
Landed in UX as https://hg.mozilla.org/projects/ux/rev/785028b0d3fd
Whiteboard: [Australis:M5] → [Australis:M5][fixed-in-ux]

Comment 18

5 years ago
Per discussion on IRC, marking fixed. Woo! :-)
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 19

4 years ago
https://hg.mozilla.org/mozilla-central/rev/785028b0d3fd
Whiteboard: [Australis:M5][fixed-in-ux] → [Australis:M5]
You need to log in before you can comment on or make changes to this bug.