868679 - [SMS][MMS] Migrate entire Messaging app to threadId (previously used phone number)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Rick Waldron [:rwaldron]]

Previously the app used the phone number to attribute a message to a particular thread. That's not cool, and now we have threadId, so use that instead.

Comment 1

[Julien Wajsberg [:julienw]]

AFAIK we know have all the necessary support in Gecko: we have the thread id in the Thread object when getting them from getThreads, we can provide a thread id in a filter, and we have the thread id when getting a message from the system message.

Borja, am I missing a use case here ?

Marking leo? because we'll need this so that everything works as intended with multi-recipients threads.

Comment 2

[Dylan Oliver [:doliver]]

Triage: likely to block on this, but can you provide the bug that this blocks so we can understand the dependencies?

Comment 3

[Dietrich Ayala (:dietrich)]

This is part of the core MMS work for proper thread support now that multiple numbers may be involved, marking blocking.

Comment 4

[Faramarz Rashed]

last comment was 4days ago.  what's the status here?

Comment 5

[Rick Waldron [:rwaldron]]

Faramarz, sendMMS is not functional (or, no one has confirmed ever sending an MMS message successfully). If it was, this might've been done on Monday.

https://bugzilla.mozilla.org/show_bug.cgi?id=867227
https://bugzilla.mozilla.org/show_bug.cgi?id=872219
https://bugzilla.mozilla.org/show_bug.cgi?id=871772
https://bugzilla.mozilla.org/show_bug.cgi?id=869807

Comment 6

[Gene Lian (I already quit Mozilla)]

(In reply to Rick Waldron from comment #5)
> Faramarz, sendMMS is not functional (or, no one has confirmed ever sending
> an MMS message successfully). If it was, this might've been done on Monday.
> 
> https://bugzilla.mozilla.org/show_bug.cgi?id=867227
> https://bugzilla.mozilla.org/show_bug.cgi?id=869807

Just for the records, please see bug 869841, comment #8. Hope it's nothing but just a typo. ;)

> https://bugzilla.mozilla.org/show_bug.cgi?id=871772
> https://bugzilla.mozilla.org/show_bug.cgi?id=872219

At the same time, I'm looking into the above two bugs. Please stay tuned.

Comment 7

[Rick Waldron [:rwaldron]]

Attachment: Fix for 868679

Comment 8

[Julien Wajsberg [:julienw]]

Comment on attachment 750760 [details] [review]
Fix for 868679

r=me

some follow up, notably Bug 873703, but we need this to not block other people. And it works :)

waiting for Corey's thumb up, because 2 more eyes could be good for this big patch.

Comment 9

[Corey Frang [:gnarf]]

master: 2f444eefd99078cb782e227e8d16c4964c99b1f1

Comment 10

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: bda16a0