[SMS][MMS] correct l10n pluralizations

RESOLVED FIXED

Status

Firefox OS
Gaia::SMS
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: rwaldron, Assigned: kaze)

Tracking

unspecified
x86
Mac OS X
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:leo+, b2g18 fixed)

Details

(Whiteboard: u=fx-os-user c=scravag-sprint p=1)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
Address any issues with l10n pluralizations
leo? because this affects languages with several plural forms, like polish, and poland is one target country.

This is a left over from Bug 868679.
blocking-b2g: --- → leo?
NI dietrich pour leo+
Flags: needinfo?(dietrich)
(Reporter)

Comment 3

5 years ago
Created attachment 751704 [details]
page 12
(Reporter)

Comment 4

5 years ago
Sorry, I attached this to the wrong bug :(
Attachment #751704 - Attachment is obsolete: true
(Assignee)

Comment 5

5 years ago
This is a regression caused by bug 868679.
Blocks: 873477
Kaze "volunteered" to fix this today.
Assignee: felash → kaze
Blocks: 874441
(Assignee)

Comment 7

5 years ago
Created attachment 752412 [details]
link to pull request — l10n fix
Attachment #752412 - Flags: review?(felash)
(Assignee)

Updated

5 years ago
Attachment #752412 - Flags: feedback?(waldron.rick)
(Assignee)

Updated

5 years ago
Attachment #752412 - Flags: feedback?(waldron.rick) → review?(waldron.rick)
Whiteboard: u=fx-os-user c=scravag-sprint-may-20-31 p=1
Whiteboard: u=fx-os-user c=scravag-sprint-may-20-31 p=1 → u=fx-os-user c=scravag-sprint p=1
Blocks: 872039
Comment on attachment 752412 [details]
link to pull request — l10n fix

looks good -> feedback+

waiting for unit tests for l10n.js to r+.

Note that we don't reproduce the display "... and others" with the current master.
Attachment #752412 - Flags: review?(felash) → feedback+
(Assignee)

Comment 9

5 years ago
Unit tests added for l10n.js.

(In reply to Julien Wajsberg [:julienw] from comment #8)
> Note that we don't reproduce the display "... and others" with the current
> master.

I confirm: I had to force the value of `others' directly in the code to test that.
Comment on attachment 752412 [details]
link to pull request — l10n fix

r=me

thanks for the tests !
Attachment #752412 - Flags: feedback+ → review+
(Reporter)

Updated

5 years ago
Attachment #752412 - Flags: review?(waldron.rick) → review+
(Assignee)

Comment 11

5 years ago
Merged on master:
https://github.com/mozilla-b2g/gaia/commit/c200a7d49c17f549895b39d8f0cd138835fbe37f
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
blocking-b2g: leo? → leo+
Flags: needinfo?(dietrich)
Whiteboard: u=fx-os-user c=scravag-sprint p=1 → u=fx-os-user c=scravag-sprint p=1 [NO_UPLIFT]

Updated

5 years ago
Whiteboard: u=fx-os-user c=scravag-sprint p=1 [NO_UPLIFT] → u=fx-os-user c=scravag-sprint p=1
Blocks: 876964
v1-train: e792dfb
status-b2g18: --- → fixed
Depends on: 913360
You need to log in before you can comment on or make changes to this bug.