873703 - [SMS][MMS] correct l10n pluralizations

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Rick Waldron [:rwaldron]]

Address any issues with l10n pluralizations

Comment 1

[Julien Wajsberg [:julienw]]

leo? because this affects languages with several plural forms, like polish, and poland is one target country.

This is a left over from Bug 868679.

Comment 2

[Julien Wajsberg [:julienw]]

NI dietrich pour leo+

Comment 3

[Rick Waldron [:rwaldron]]

Attachment: page 12

Comment 4

[Rick Waldron [:rwaldron]]

Sorry, I attached this to the wrong bug :(

Comment 5

[Fabien Cazenave [:kaze]]

This is a regression caused by bug 868679.

Comment 6

[Julien Wajsberg [:julienw]]

Kaze "volunteered" to fix this today.

Comment 7

[Fabien Cazenave [:kaze]]

Attachment: link to pull request — l10n fix

Comment 8

[Julien Wajsberg [:julienw]]

Comment on attachment 752412 [details]
link to pull request — l10n fix

looks good -> feedback+

waiting for unit tests for l10n.js to r+.

Note that we don't reproduce the display "... and others" with the current master.

Comment 9

[Fabien Cazenave [:kaze]]

Unit tests added for l10n.js.

(In reply to Julien Wajsberg [:julienw] from comment #8)
> Note that we don't reproduce the display "... and others" with the current
> master.

I confirm: I had to force the value of `others' directly in the code to test that.

Comment 10

[Julien Wajsberg [:julienw]]

Comment on attachment 752412 [details]
link to pull request — l10n fix

r=me

thanks for the tests !

Comment 11

[Fabien Cazenave [:kaze]]

Merged on master:
https://github.com/mozilla-b2g/gaia/commit/c200a7d49c17f549895b39d8f0cd138835fbe37f

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: e792dfb