Closed
Bug 868751
Opened 11 years ago
Closed 11 years ago
Remove support for document.createEvent("AnimationEvent"), document.createEvent("TransitionEvent"), AnimationEvent.initAnimationEvent, and TransitionEvent.initTransitionEvent
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: smaug, Assigned: dbaron)
References
Details
(Keywords: dev-doc-complete, site-compat)
Attachments
(1 file)
Need to check what Webkit, Trident and Blink have and also do some search whether the feature is used in the web pages or script libraries.
Assignee | ||
Comment 1•11 years ago
|
||
At the very least, the event type argument to document.createEvent() in WebKit / blink isn't compatible, or wasn't until very recently. I think we should just remove and see if we get feedback; I have a patch to do so.
Assignee | ||
Comment 2•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=75a2adbecd62
Assignee | ||
Comment 3•11 years ago
|
||
make that https://tbpl.mozilla.org/?tree=Try&rev=c4e6644234dc
Assignee | ||
Comment 4•11 years ago
|
||
Attachment #746671 -
Flags: review?(bugs)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → dbaron
Assignee | ||
Comment 5•11 years ago
|
||
Comment on attachment 746671 [details] [diff] [review] Remove support for obsolete document.createEvent("AnimationEvent"), document.createEvent("TransitionEvent"), AnimationEvent.initAnimationEvent, and TransitionEvent.initTransitionEvent. Note that this comment: >+ // NEW EVENT TYPES SHOULD NOT BE ADDED HERE; THEY SHOULD USE ONLY EVENT >+ // CONSTRUCTORS was added based on an in-person discussion I had with annevk.
Reporter | ||
Comment 6•11 years ago
|
||
Comment on attachment 746671 [details] [diff] [review] Remove support for obsolete document.createEvent("AnimationEvent"), document.createEvent("TransitionEvent"), AnimationEvent.initAnimationEvent, and TransitionEvent.initTransitionEvent. I guess we can do this this way, although I'd probably leave init*Event method to .idl files and make them [noscript].
Attachment #746671 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 7•11 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #6) > I guess we can do this this way, although I'd probably leave init*Event > method to > .idl files and make them [noscript]. Why would you want to do that?
Reporter | ||
Comment 8•11 years ago
|
||
oh, right, creating these events in C++ outside libxul becomes hard anyway. So, removing init* from .idl makes sense.
Assignee | ||
Comment 9•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a20ea0d494a0
Assignee | ||
Updated•11 years ago
|
Keywords: dev-doc-needed
Summary: Investigate if initTransitionEvent method could be removed → Remove support for document.createEvent("AnimationEvent"), document.createEvent("TransitionEvent"), AnimationEvent.initAnimationEvent, and TransitionEvent.initTransitionEvent
Comment 10•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a20ea0d494a0
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Comment 11•11 years ago
|
||
I've added this bug to the compatibility doc. Please correct the info if wrong. https://developer.mozilla.org/en-US/docs/Site_Compatibility_for_Firefox_23
Comment 12•11 years ago
|
||
Documentation updated https://developer.mozilla.org/en-US/docs/Web/API/TransitionEvent.initTransitionEvent https://developer.mozilla.org/en-US/docs/Web/API/AnimationEvent.initAnimationEvent https://developer.mozilla.org/en-US/docs/Web/API/document.createEvent https://developer.mozilla.org/en-US/docs/Web/API/AnimationEvent https://developer.mozilla.org/en-US/docs/Web/API/TransitionEvent https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/23 https://developer.mozilla.org/en-US/docs/Site_Compatibility_for_Firefox_23
Keywords: dev-doc-needed → dev-doc-complete
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•