Last Comment Bug 868751 - Remove support for document.createEvent("AnimationEvent"), document.createEvent("TransitionEvent"), AnimationEvent.initAnimationEvent, and TransitionEvent.initTransitionEvent
: Remove support for document.createEvent("AnimationEvent"), document.createEve...
Status: RESOLVED FIXED
: dev-doc-complete, site-compat
Product: Core
Classification: Components
Component: DOM (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla23
Assigned To: David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
:
Mentors:
: 868769 (view as bug list)
Depends on: 848291
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-04 07:43 PDT by Olli Pettay [:smaug]
Modified: 2014-04-02 23:30 PDT (History)
3 users (show)
ryanvm: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Remove support for obsolete document.createEvent("AnimationEvent"), document.createEvent("TransitionEvent"), AnimationEvent.initAnimationEvent, and TransitionEvent.initTransitionEvent. (16.57 KB, patch)
2013-05-07 15:56 PDT, David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
bugs: review+
Details | Diff | Review

Description Olli Pettay [:smaug] 2013-05-04 07:43:01 PDT
Need to check what Webkit, Trident and Blink have and also do some
search whether the feature is used in the web pages or script libraries.
Comment 1 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2013-05-07 15:39:27 PDT
At the very least, the event type argument to document.createEvent() in WebKit / blink isn't compatible, or wasn't until very recently.  I think we should just remove and see if we get feedback; I have a patch to do so.
Comment 2 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2013-05-07 15:41:30 PDT
https://tbpl.mozilla.org/?tree=Try&rev=75a2adbecd62
Comment 3 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2013-05-07 15:56:16 PDT
make that https://tbpl.mozilla.org/?tree=Try&rev=c4e6644234dc
Comment 4 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2013-05-07 15:56:28 PDT
Created attachment 746671 [details] [diff] [review]
Remove support for obsolete document.createEvent("AnimationEvent"), document.createEvent("TransitionEvent"), AnimationEvent.initAnimationEvent, and TransitionEvent.initTransitionEvent.
Comment 5 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2013-05-07 15:58:53 PDT
Comment on attachment 746671 [details] [diff] [review]
Remove support for obsolete document.createEvent("AnimationEvent"), document.createEvent("TransitionEvent"), AnimationEvent.initAnimationEvent, and TransitionEvent.initTransitionEvent.

Note that this comment:
>+  // NEW EVENT TYPES SHOULD NOT BE ADDED HERE; THEY SHOULD USE ONLY EVENT
>+  // CONSTRUCTORS
was added based on an in-person discussion I had with annevk.
Comment 6 Olli Pettay [:smaug] 2013-05-08 03:07:20 PDT
Comment on attachment 746671 [details] [diff] [review]
Remove support for obsolete document.createEvent("AnimationEvent"), document.createEvent("TransitionEvent"), AnimationEvent.initAnimationEvent, and TransitionEvent.initTransitionEvent.

I guess we can do this this way, although I'd probably leave init*Event method to
.idl files and make them [noscript].
Comment 7 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2013-05-08 09:28:41 PDT
(In reply to Olli Pettay [:smaug] from comment #6)
> I guess we can do this this way, although I'd probably leave init*Event
> method to
> .idl files and make them [noscript].

Why would you want to do that?
Comment 8 Olli Pettay [:smaug] 2013-05-08 09:33:05 PDT
oh, right, creating these events in C++ outside libxul becomes hard anyway. So, removing
init* from .idl makes sense.
Comment 9 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2013-05-08 13:45:57 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/a20ea0d494a0
Comment 10 Ryan VanderMeulen [:RyanVM] 2013-05-08 21:32:04 PDT
https://hg.mozilla.org/mozilla-central/rev/a20ea0d494a0
Comment 11 Kohei Yoshino [:kohei] 2013-05-17 13:13:12 PDT
I've added this bug to the compatibility doc. Please correct the info if wrong.
https://developer.mozilla.org/en-US/docs/Site_Compatibility_for_Firefox_23
Comment 13 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2014-04-02 23:30:28 PDT
*** Bug 868769 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.