868751 - Remove support for document.createEvent("AnimationEvent"), document.createEvent("TransitionEvent"), AnimationEvent.initAnimationEvent, and TransitionEvent.initTransitionEvent

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Need to check what Webkit, Trident and Blink have and also do some
search whether the feature is used in the web pages or script libraries.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

At the very least, the event type argument to document.createEvent() in WebKit / blink isn't compatible, or wasn't until very recently.  I think we should just remove and see if we get feedback; I have a patch to do so.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://tbpl.mozilla.org/?tree=Try&rev=75a2adbecd62

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

make that https://tbpl.mozilla.org/?tree=Try&rev=c4e6644234dc

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Remove support for obsolete document.createEvent("AnimationEvent"), document.createEvent("TransitionEvent"), AnimationEvent.initAnimationEvent, and TransitionEvent.initTransitionEvent.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 746671 [details] [diff] [review]
Remove support for obsolete document.createEvent("AnimationEvent"), document.createEvent("TransitionEvent"), AnimationEvent.initAnimationEvent, and TransitionEvent.initTransitionEvent.

Note that this comment:
>+  // NEW EVENT TYPES SHOULD NOT BE ADDED HERE; THEY SHOULD USE ONLY EVENT
>+  // CONSTRUCTORS
was added based on an in-person discussion I had with annevk.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 746671 [details] [diff] [review]
Remove support for obsolete document.createEvent("AnimationEvent"), document.createEvent("TransitionEvent"), AnimationEvent.initAnimationEvent, and TransitionEvent.initTransitionEvent.

I guess we can do this this way, although I'd probably leave init*Event method to
.idl files and make them [noscript].

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(In reply to Olli Pettay [:smaug] from comment #6)
> I guess we can do this this way, although I'd probably leave init*Event
> method to
> .idl files and make them [noscript].

Why would you want to do that?

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

oh, right, creating these events in C++ outside libxul becomes hard anyway. So, removing
init* from .idl makes sense.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a20ea0d494a0

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a20ea0d494a0

Comment 11

[Kohei Yoshino]

I've added this bug to the compatibility doc. Please correct the info if wrong.
https://developer.mozilla.org/en-US/docs/Site_Compatibility_for_Firefox_23

Comment 12

[Jean-Yves Perrier [:teoli]]

Documentation updated
https://developer.mozilla.org/en-US/docs/Web/API/TransitionEvent.initTransitionEvent
https://developer.mozilla.org/en-US/docs/Web/API/AnimationEvent.initAnimationEvent
https://developer.mozilla.org/en-US/docs/Web/API/document.createEvent
https://developer.mozilla.org/en-US/docs/Web/API/AnimationEvent
https://developer.mozilla.org/en-US/docs/Web/API/TransitionEvent

https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/23
https://developer.mozilla.org/en-US/docs/Site_Compatibility_for_Firefox_23