868934 - B2G RIL: Can not select AuthType of data profile.

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Edgar Chen [:edgar]]

Current MOZ RIL is always passing "pap or chap" to network side, but if network only support "pap", the network will give a reject for this request. Then data call will fail to establish. We should let APN setting can select AuthType. Please see detailed information in bug 866003.

Comment 1

[Edgar Chen [:edgar]]

I plan to add new field in APN setting for authentication type, something like:
- ril.data.authtype
- ril.mms.authtype
- ril.supl.authtype

The possible values are "none", "pap", "chap" and "papOrChap".

Comment 2

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Edgar Chen [:edgar][:echen] from comment #1)
> I plan to add new field in APN setting for authentication type, something
> like:
> - ril.data.authtype
> - ril.mms.authtype
> - ril.supl.authtype
> 
> The possible values are "none", "pap", "chap" and "papOrChap".

SGTM, I'll use them.

BTW the WIP path I have for bug 866003 had:
- ril.{data, mms, supl}.auth.type and these possible values ['none', 'pap', 'chap', 'paporchap']

Comment 3

[José Antonio Olivera Ortega [:jaoo]]

Edgar, we should use a default option to set to ril.{data, mms, supl}.authtype setting because the user might not select the authentication method. Moreover for those APN settings coming from the `apn.json` APN setting database there is no value for such setting. I've already figured out that AOSP sets something likes 'notDefined' in that case. BTW, keep an eye to https://github.com/mozilla-b2g/gaia/pull/9583 please, it might be useful for your tests. The first WIP works fine. Thanks!

Comment 4

[Edgar Chen [:edgar]]

Attachment: Support selecting authentication type for data call request, v1

WIP patch, I will provide formal patch after bug 850555 is landed.

Comment 5

[Edgar Chen [:edgar]]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #3)
> Edgar, we should use a default option to set to ril.{data, mms,
> supl}.authtype setting because the user might not select the authentication
> method. Moreover for those APN settings coming from the `apn.json` APN
> setting database there is no value for such setting. I've already figured
> out that AOSP sets something likes 'notDefined' in that case. BTW, keep an
> eye to https://github.com/mozilla-b2g/gaia/pull/9583 please, it might be
> useful for your tests. The first WIP works fine. Thanks!
Thanks for your WIP patch. It works well with mine.

BTW, my WIP patch is only for testing purpose. I am waiting for bug 850555 landing then provide a formal patch.
In bug 850555, we plan to change apn setting architecture. Basically, we want to put all apn related setting, ril.{data, mms, supl}.{apn, user, passwd, ..}, into one setting called ril.data.apnSettings [1]. With the new architecture, a new field, 'authtype', will be added and the possible value is the same.

[1] Please see bug 850555  comment #13.

Comment 6

[José Antonio Olivera Ortega [:jaoo]]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #3)
> Edgar, we should use a default option to set to ril.{data, mms,
> supl}.authtype setting because the user might not select the authentication
> method. Moreover for those APN settings coming from the `apn.json` APN
> setting database there is no value for such setting. 

  Oops, Just noticed I was wrong here, for example, see [1]. Fixing it in current WIP.

> I've already figured
> out that AOSP sets something likes 'notDefined' in that case. BTW, keep an
> eye to https://github.com/mozilla-b2g/gaia/pull/9583 please, it might be
> useful for your tests. The first WIP works fine. Thanks!

[1] https://github.com/mozilla-b2g/gaia/blob/master/shared/resources/apn.json#L94

Comment 7

[Leo]

attached patch wasn't merged into master git yet?
if it was merged, let me know the version I can check.

Jinho Lee.

Comment 8

[Edgar Chen [:edgar]]

(In reply to Leo from comment #7)
> attached patch wasn't merged into master git yet?
> if it was merged, let me know the version I can check.
> 
> Jinho Lee.

Sure, I will let you know the this is landed.
Now we are waiting for bug 850555 land first. (please see comment#5)

Thanks

Comment 9

[Leo]

Dear Mozilla engineer,

What is the status?
bug 850555 has review+. but there is no action.
What should be done next?
We can not just wait for.
make this be proceeded, please.

BR,
Jinho Lee.

Comment 10

[Edgar Chen [:edgar]]

(In reply to Leo from comment #9)
> Dear Mozilla engineer,
> 
> What is the status?
> bug 850555 has review+. but there is no action.
> What should be done next?
> We can not just wait for.
> make this be proceeded, please.
> 
> BR,
> Jinho Lee.

Hi Jinho,

Bug 85055 is not landed because Gaia needs to do corresponding changes and we are integrating now [1].
The patch of bug 842252 and bug 85055 are all r+, it seems we are almost there.

Thanks

[1] Please see bug 842252.

Comment 11

[Edgar Chen [:edgar]]

It seems we still need more time to discuss the data call architecture, let's fix this bug first.

Comment 12

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 746824 [details] [diff] [review]
Support selecting authentication type for data call request, v1

Review of attachment 746824 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! r=me with the comment addressed, thank you~

::: dom/system/gonk/RadioInterfaceLayer.js
@@ +3088,5 @@
>      let radioTechnology = RIL.GECKO_RADIO_TECH.indexOf(radioTechType);
> +    let authType = RIL.RIL_DATACALL_AUTH_TO_GECKO.indexOf(this.dataCallSettings["authtype"]);
> +    // Use the default authType if the value in database is invalid.
> +    // For the case that user might not select the authentication type.
> +    if (authType < 0) {

let's use if (authType == -1)

Comment 13

[Edgar Chen [:edgar]]

Attachment: Support selecting authentication type for data call request, v2, r=hsinyi

1). Rebase
2). Address review comment #12
3). add r=hsinyi after r+

Comment 14

[Edgar Chen [:edgar]]

try server result: https://tbpl.mozilla.org/?tree=Try&rev=1726feab078b

Comment 15

[Edgar Chen [:edgar]]

Attachment: [b2g18] Support selecting authentication type for data call request, v2, r=hsinyi, a=leo+

Patch for mozilla-b2g18

Comment 16

[Edgar Chen [:edgar]]

CC'd Anshulj.

We add 'ril.{data, mms, supl}.authtype' for selecting authType for data call request.
Maybe QCRIL need do some corresponding changes.

Thanks

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/projects/birch/rev/66ef353a2fbc

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/66ef353a2fbc

Comment 19

[Anshul]

(In reply to Edgar Chen [:edgar][:echen] from comment #16)
> CC'd Anshulj.
> 
> We add 'ril.{data, mms, supl}.authtype' for selecting authType for data call
> request.
> Maybe QCRIL need do some corresponding changes.
> 
> Thanks

Thanks for letting us know Edgar. Appreciate it!

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/ef55f959016d

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/ef55f959016d