866003 - [B2G][LEO][settings]Can not select AuthType of data profile.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Leo]

Dear Mozilla engineer,

The problem is there is no authType(pap, chap, pap or chap) setting in UI menu.

Settings > Cellular & Data > Data settings > (custom settings)

there are Identifier field and Password field.
but there is no AuthType field in UI menu.

but AuthType field is essential when a user add new profile including Identifier and Password because Right AuthType should be chosen for the profile.
otherwise the Network will give the reject to the handset.

so make the AuthType setting in UI menu plaese.

-	Build ID : 20130421070203
-	Gaia : 5cbb19e4bb78a7ad879fbe4b9a841e1c35714f5c
-	Gecko : 950b402b6188bb2f3ce3176e620ed5249719d720

My email is [e-mail]

BR,
Jinho Lee.

Comment 1

[Ken Chang[:kenkai]]

This is a new feature and it depends on the carrier setting. Without this feature, does FFOS have problem for target carrier?

Comment 2

[Leo]

Yes.

If there are Identifier field and Password field, network will check the AuthType.
so if there is not AuthType field in handset, it doesn't make sense.

if handset sends chap type request message to network, even thought network supports pap type. then network will give reject response to the handset.

so it is critical.

AuthType can be 4 types.(none, pap, chap, pap or chap)

thanks,
Jinho Lee.

Comment 3

[Ken Chang[:kenkai]]

(In reply to Leo from comment #2)
> Yes.
> 
> if handset sends chap type request message to network, even thought network
> supports pap type. then network will give reject response to the handset.
Do you mean the carries of target market is only able to accept "pap" authType?

Comment 4

[Ken Chang[:kenkai]]

Edgar, please also create a Gaia bug.

Comment 5

[Edgar Chen [:edgar]]

(In reply to Leo from comment #2)
> Yes.
> 
> If there are Identifier field and Password field, network will check the
> AuthType.
> so if there is not AuthType field in handset, it doesn't make sense.
> 
> if handset sends chap type request message to network, even thought network
> supports pap type. then network will give reject response to the handset.

In current RIL design, we always pass 'pap or chap' to network side [1].
I think above case can be covered.
Do you think we still need to let user select auth type?

Thanks

> 
> so it is critical.
> 
> AuthType can be 4 types.(none, pap, chap, pap or chap)
> 
> thanks,
> Jinho Lee.

[1] http://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/RadioInterfaceLayer.js#3086

Comment 6

[Leo]

(In reply to Edgar Chen [:edgar][:echen] from comment #5)
> (In reply to Leo from comment #2)
In current RIL
> design, we always pass 'pap or chap' to network side [1].
I think above case
> can be covered.
Do you think we still need to let user select auth type?
> Thanks

> 
> so it is critical.
> 
> AuthType can be 4 types.(none, pap,
> chap, pap or chap)
> 
> thanks,
> Jinho Lee.

[1]
> http://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/
> RadioInterfaceLayer.js#3086

Yes, we still need the authType selectable.
I know about the RIL design but this design means the handset can send CHAP type to Newwork even if Network only supports PAP type.
The "reject by Network" issue is already reported from tester.

So please make UI and interface for the authType.

BR,
Jinho Lee.

Comment 7

[Edgar Chen [:edgar]]

(In reply to Leo from comment #6)
> (In reply to Edgar Chen [:edgar][:echen] from comment #5)
> > (In reply to Leo from comment #2)
> In current RIL
> > design, we always pass 'pap or chap' to network side [1].
> I think above case
> > can be covered.
> Do you think we still need to let user select auth type?
> > Thanks
> 
> > 
> > so it is critical.
> > 
> > AuthType can be 4 types.(none, pap,
> > chap, pap or chap)
> > 
> > thanks,
> > Jinho Lee.
> 
> [1]
> > http://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/
> > RadioInterfaceLayer.js#3086
> 
> Yes, we still need the authType selectable.
> I know about the RIL design but this design means the handset can send CHAP
> type to Newwork even if Network only supports PAP type.
> The "reject by Network" issue is already reported from tester.

got it, thanks.

> 
> So please make UI and interface for the authType.
> 
> BR,
> Jinho Lee.

Comment 8

[Edgar Chen [:edgar]]

Hi :jaoo,

I have opened a new bug 868934 for Gecko to support selecting auth type. In Gaia side, it seems we need to add a new field in APN Setting UI for auth type which can be 4 types. (none, pap, chap, pap or chap).
Could you help to take this bug for Gaia side? or I need to ask someone else?

Thanks. :)

Comment 9

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Edgar Chen [:edgar][:echen] from comment #8)
> Hi :jaoo,
> 
> I have opened a new bug 868934 for Gecko to support selecting auth type. In
> Gaia side, it seems we need to add a new field in APN Setting UI for auth
> type which can be 4 types. (none, pap, chap, pap or chap).
> Could you help to take this bug for Gaia side? or I need to ask someone else?
> 
> Thanks. :)

Sure, go for it!

Comment 10

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/9583

WIP

Comment 11

[Leo]

above commit was merged?
if it was merged, what is the version I can check?

Jinho Lee.

Comment 12

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Leo from comment #11)
> above commit was merged?
> if it was merged, what is the version I can check?
> 
> Jinho Lee.

Nope, it's not merged yet.

Comment 13

[Leo]

It looks like done in gaia part.
why isn't this commit merged yet?
this commit is waiting for gecko part's commit?
(this two commits should be merged at the sametime?)

Please let me know about this.
Jinho Lee.

Comment 14

[Edgar Chen [:edgar]]

(In reply to Leo from comment #13)
> It looks like done in gaia part.
> why isn't this commit merged yet?
> this commit is waiting for gecko part's commit?
> (this two commits should be merged at the sametime?)
> 
> Please let me know about this.
> Jinho Lee.

Yes, this is waiting for gecko part's commit, bug 868934.
For the gecko part, we are waiting for apn architecture changing [1].

Thanks

[1] please see bug 868934 comment #5.

Comment 15

[Leo]

Dear Mozilla engineer,

time has spent so long.
please land this patch fisrt, not wait for apn architecture changing.
refer to Bug 850555's comment if you have any question. 

thanks,
Jinho Lee.

Comment 16

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 746269 [details]
Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/9583

Bug 868934 will land really soon so let's review this work. Kaze, could you take a look please? Thanks.

Comment 17

[Edgar Chen [:edgar]]

Comment on attachment 746269 [details]
Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/9583

This patch looks good to me. I have did some integration test with bug 868934, it worked well. :)

Comment 18

[José Antonio Olivera Ortega [:jaoo]]

Thanks!, bug 868934 just landed in birch. We can land this work after kaze's review.

Comment 19

[Fabien Cazenave [:kaze]]

Comment on attachment 746269 [details]
Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/9583

Looks good to me.

Comment 20

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Fabien Cazenave [:kaze] from comment #19)
> Comment on attachment 746269 [details]
> Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/9583
> 
> Looks good to me.

Thanks, I'll land this work once bug 868934 reaches mozilla-central repo.

Comment 21

[José Antonio Olivera Ortega [:jaoo]]

https://github.com/mozilla-b2g/gaia/commit/e620b1766b9c029e01067ef6cdd3e9e5fc6b15e6

Comment 22

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted e620b1766b9c029e01067ef6cdd3e9e5fc6b15e6 to:
v1-train: 4ebcd4946736f552e8e8f06299ac95d93ce38572

Comment 23

[José Antonio Olivera Ortega [:jaoo]]

Setting status-b2g-v1.1hd flag as affected too.

Comment 24

[John Ford [:jhford] CET/CEST Berlin Time]

1.1hd: 4ebcd4946736f552e8e8f06299ac95d93ce38572

Comment 25

[sarsenyev]

Verified it's fixed on Leo V1.1 device
Options in the Authentication are implemented in UI (Not defined, None, PAP, CHAP, PAP or CHAP

Environmental  Variables:
Build ID: 20130717070237
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/582e3a7018b0
Gaia: c506c50adaaebcf729ac3c27887ba2931ab79040
Platform Version: 18.1
RIL Version: 01.01.00.019.138