869060 - Contact name no longer appears on the oncall screen when there is a "+" in the phone

Status: RESOLVED DUPLICATE of bug 871930

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Bob Silverberg [:bsilverberg]]

When placing a call by clicking on a Contact's phone number, in the past (prior to May 3rd), the contact's name appeared on the screen in addition to their phone number. Now when performing the same action the phone number is displayed, but the contact's name is not.

I am not sure if this is a regression or an intentional change.

Comment 1

[Marcia Knous [:marcia]]

Bob: I am not seeing this using the latest V1 train build on Inari.

Comment 2

[Bob Silverberg [:bsilverberg]]

Attachment: Screen cap of contact to be called

Comment 3

[Bob Silverberg [:bsilverberg]]

Attachment: Screen cap of oncall screen

Comment 4

[Bob Silverberg [:bsilverberg]]

Marcia, I just updated to the latest v1-train and am seeing similar results. Perhaps it has to do with the set up of the contact for our tests? I am attaching a screen cap of the contact details, as well as the oncall screen so you can see what I mean.

Comment 5

[Zac C (:zac)]

Marcia, I'm seeing this aswell on:

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/2518b2165ea1
Gaia   391b12d1a2998e2ec48608be33e597477296473b
BuildID 20130506230204
Version 18.0

Comment 6

[Zac C (:zac)]

Marcia, can you confirm this either as a bug or expected behaviour?

Comment 7

[Marcia Knous [:marcia]]

Attachment: Screenshot of name showing

This is what I see using today's V1 train build:

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/50726fbdc25e
Gaia   a503d9a1d0a588f3689243c1ddc0f016ede51b9d
BuildID 20130513070206
Version 18.0

Comment 8

[Zac C (:zac)]

hmmf.
I'll try again. Thanks Marcia!

Comment 9

[Zac C (:zac)]

I have worked it out - if it includes a "+" in the phone number the contact will not show.

Comment 10

[Zac C (:zac)]

STR:
1. Create a contact with first name, surname and phone number. In the phone number include a leadng "+" and international country code.
2. Save contact
3. Make call and note the call screen.

4. Repeat for a contact with a phone number without a "+" and international dialing code in the phone number.

Comment 11

[Marcia Knous [:marcia]]

I think I see what the bug is - the name is showing on the phone dialing, but not the phone receiving. I can see the name on the outbound phone that I am dialing on, but not the inbound phone that is receiving the call.

Comment 12

[Zac C (:zac)]

I definitely can't see it on the outbound phone.

Marcia if you change for the example in comment #7 the phone number to +1650... the +1 being the important bit then you will replicate the bug.

The only other possible difference is that the British phone number is longer.

Comment 13

[Marcia Knous [:marcia]]

I do see the issue when a "1" is added to the number.

(In reply to Zac C (:zac) from comment #12)
> I definitely can't see it on the outbound phone.
> 
> Marcia if you change for the example in comment #7 the phone number to
> +1650... the +1 being the important bit then you will replicate the bug.
> 
> The only other possible difference is that the British phone number is
> longer.

Comment 14

[Zac C (:zac)]

It has to be "+1" Marcia.

Comment 15

[Zac C (:zac)]

Attachment: Video of failure

OK I have recorded a video of the problem.

In this example there are two contacts:
* With Plus, phone number with leading +44 
* No Plus, phone number starts with '0'

Two scenarios:
When calling 'No plus', the name on the call screen displays as 'with plus' and the number is shown as correct for 'no plus'
When calling 'With Plus' the contact name is not shown at all, only the number with +44 is shown.

I think this should prove we can't remain nonplussed over this.

Comment 16

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I was able to replicate the issue in 1.1 and Master.

I believe we had changed the contacts lib or something similar in the 1.1 time frame which we decided not to take in 1.0.1 so this is a regression.

Comment 17

[Bob Silverberg [:bsilverberg]]

This seems to now be fixed on v1.0.1

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/0b6bcb1f4175
Gaia   9648799c2e45917ff150fa9eef8aeac79a9ac008
BuildID 20130515070203
Version 18.0

I will let Zac verify.

Comment 18

[Jan Jongboom [:janjongboom] (inactive)]

This is quite a same issue that we had previously with SMS as well. If you view the video you'll see that when you're calling the first contact the contact details for the second one show up (SO THE WRONG CONTACT!) because we're trying to be 'smart' about find the contact by just removing part of the phone number and then do a substring match, thus matching the number we're calling to the wrong contact.

That is not so nice. We should not do stuff like this in Gaia but rather in Gecko the moment we save the contacts phone number and only do equals matching (and let PhoneNumber.js handle conversion).

Comment 19

[Jan Jongboom [:janjongboom] (inactive)]

@albertopq: can you elaborate on this? It does the `match` op in mozContacts, but I don't quite get what that does. F.e. when calling a contact with phone no. 012345678 the current query generated is {"filterBy":["tel"],"filterOp":"match","filterValue":"12345678"} and that doesn't yield any results. Is this some variant of equals or?

Comment 20

[alberto.pastor]

We use the libphone library in contacts, so "match" (only works with the "tel" field) tries to normalize the number you are looking for, in order to find phones with international prefixes:

http://mxr.mozilla.org/mozilla-central/source/dom/contacts/fallback/ContactDB.jsm#852

That said, I think your query should return the 012345678 contact. I tried with current master, and it returns it, in fact.

Does it help?

Comment 21

[Jan Jongboom [:janjongboom] (inactive)]

That data came straight out of my adb logs for a build of today. Also complies with the issue seen in this bug. I saw the code as well and I guess we can remove all the simple_phone_match'ing code from contacts then, and let Gecko handle all the magic?

Comment 22

[alberto.pastor]

I have not been that involved in the Dialer implementation, so probably :etienne can help more than me here. I'm not sure why are we using the SimplePhoneMatcher there, probably because PHoneNumber wasn't in mozContacts yet... Any ideas etienne?

Comment 23

[Jan Jongboom [:janjongboom] (inactive)]

Checked this code out a bit, but we need to know on which phone number we matched in the mozContacts query. Doesn't seem trivial, or does it?

Comment 24

[Etienne Segonzac (:etienne)]

The new "match" keyword for the mozContacts API that was introduced isn't compatible with the SimplePhoneMatcher.