Closed Bug 869143 Opened 10 years ago Closed 10 years ago

XPCSHELL_TEST conversion cleanups

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla24

People

(Reporter: joey, Assigned: joey)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Remove DISABLED_XPCSHELL_TEST from Makefile.in.
cleanup remaining conversion items {list to be added}
Blocks: nomakefiles
Assignee: nobody → joey
Comment on attachment 747999 [details] [diff] [review]
phase2 cleanup for XPCSHELL_TEST conversion.

Phase2 conversion cleanup.  Remove scaffolding (s/XPCSHELL_/DISABLED_XPCSHELL_) and conditionals from the Makefile.in flavor of XPCSHELL_TESTS.
Attachment #747999 - Attachment description: phas2 cleanup for XPCSHELL_TEST conversion. → phase2 cleanup for XPCSHELL_TEST conversion.
Attachment #747999 - Flags: review?(mshal)
Comment on attachment 747999 [details] [diff] [review]
phase2 cleanup for XPCSHELL_TEST conversion.

>diff --git a/toolkit/components/downloads/test/Makefile.in b/toolkit/components/downloads/test/Makefile.in
>--- a/toolkit/components/downloads/test/Makefile.in
>+++ b/toolkit/components/downloads/test/Makefile.in
>@@ -1,20 +1,15 @@
> #
> # This Source Code Form is subject to the terms of the Mozilla Public
> # License, v. 2.0. If a copy of the MPL was not distributed with this
> # file, You can obtain one at http://mozilla.org/MPL/2.0/.
> 
>-DEPTH   = @DEPTH@
>+DEPTH     = @DEPTH@
> topsrcdir = @top_srcdir@
> srcdir    = @srcdir@
>-VPATH   = @srcdir@
>+VPATH     = @srcdir@
> relativesrcdir = @relativesrcdir@

Please avoid making unrelated whitespace changes to patches like this, since it makes review a bit more difficult. Other than that, looks good.
Attachment #747999 - Flags: review?(mshal) → review+
inbound push:
committed changeset 131815:2bf6dcf8c74a
https://hg.mozilla.org/integration/mozilla-inbound/rev/2bf6dcf8c74a
https://hg.mozilla.org/mozilla-central/rev/2bf6dcf8c74a
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.