Closed Bug 869266 Opened 12 years ago Closed 12 years ago

Crash provider should reduce number of needed SQL statements

Categories

(Firefox Health Report Graveyard :: Client: Desktop, defect)

Product:
Firefox Health Report Graveyard
Component:
Client: Desktop
Version:
23 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 23

People

(Reporter: vladan, Assigned: gps)

Details

Attachments

(2 files)

FHR executes thousands of INSERTs
2.04 MB, text/plain
Details
Aggregate counter increments, v1
7.83 KB, patch
rnewman
: review+
Details | Diff | Splinter Review
I have thousands of crash reports (bug 869264) which seems to cause FHR to execute thousands of INSERT statements. Can we replace the individual field increments with a single insert? I was able to reproduce this behavior by opening profiles I hadn't used in weeks/months and then navigating to about:healthreport shortly after startup.
Explanation in bug 865465 comment 16.
Summary: FHR executes 6000 SQL statements during a brief session → Crash provider should reduce number of needed SQL statements
This is the best we can do without introducing more complicated APIs. But, we don't need complicated APIs because with bug 854060, we should have a full solution to curtail the number of SQL statements.
Assignee: nobody → gps
Status: NEW → ASSIGNED
Attachment #747038 - Flags: review?(rnewman)
Attachment #747038 - Flags: review?(rnewman) → review+
https://hg.mozilla.org/mozilla-central/rev/dea5219d6b43
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed in services]
Target Milestone: --- → Firefox 23
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: